cleaned up issues/auxiliary/issue-14421.rs and issues/issue-14421.rs

Author: spencer3035

tests/ui/issues/auxiliary/issue-14421.rs

@@ -1,25 +1,33 @@
-#![crate_type="lib"]
-#![deny(warnings)]
-#![allow(dead_code)]
+//! Auxilary file for testing `dead_code` lint. This crate is compiled as a library and exposes
+//! aliased types. When used externally, there should not be warnings of `dead_code`
+//!
+//! Issue: <https://github.com/rust-lang/rust/issues/14421>
 
-pub use src::aliases::B;
-pub use src::hidden_core::make;
+// Expose internal types to be used in external test
+pub use src::aliases::ExposedType;
+pub use src::hidden_core::new;
 
 mod src {
     pub mod aliases {
-        use super::hidden_core::A;
-        pub type B = A<f32>;
+        use super::hidden_core::InternalStruct;
+        pub type ExposedType = InternalStruct<f32>;
     }
 
     pub mod hidden_core {
-        use super::aliases::B;
+        use super::aliases::ExposedType;
 
-        pub struct A<T> { t: T }
+        pub struct InternalStruct<T> {
+            _x: T,
+        }
 
-        pub fn make() -> B { A { t: 1.0 } }
+        pub fn new() -> ExposedType {
+            InternalStruct { _x: 1.0 }
+        }
 
-        impl<T> A<T> {
-            pub fn foo(&mut self) { println!("called foo"); }
+        impl<T> InternalStruct<T> {
+            pub fn foo(&mut self) {
+                println!("called foo");
+            }
         }
     }
 }

tests/ui/issues/issue-14421.rs

@@ -1,15 +1,17 @@
-//@ run-pass
-#![allow(non_snake_case)]
+//! Regression test to ensure that `dead_code` warning does not get triggered when using re-exported
+//! types that are exposed from a different crate
+//!
+//! Issue: <https://github.com/rust-lang/rust/issues/14421>
 
+//@ check-pass
 //@ aux-build:issue-14421.rs
 
-
 extern crate issue_14421 as bug_lib;
 
-use bug_lib::B;
-use bug_lib::make;
+use bug_lib::ExposedType;
+use bug_lib::new;
 
 pub fn main() {
-    let mut an_A: B = make();
-    an_A.foo();
+    let mut x: ExposedType = new();
+    x.foo();
 }