Skip to content

Commit d7dabd3

Browse files
committed
---
yaml --- r: 50421 b: refs/heads/auto c: df66e8d h: refs/heads/master i: 50419: 8b303ac v: v3
1 parent e272160 commit d7dabd3

File tree

2 files changed

+16
-3
lines changed

2 files changed

+16
-3
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,5 +14,5 @@ refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0
1414
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1515
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1616
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
17-
refs/heads/auto: 75d615d6f6d8fd8e931689106dfa22e4a6e662a2
17+
refs/heads/auto: df66e8d4a197443c214e918a858208ecc38e9f1c
1818
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167

branches/auto/src/libcore/str.rs

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1865,8 +1865,10 @@ pub struct CharRange {
18651865
* Given a byte position and a str, return the previous char and its position
18661866
*
18671867
* This function can be used to iterate over a unicode string in reverse.
1868+
*
1869+
* returns 0 for next index if called on start index 0
18681870
*/
1869-
fn char_range_at_reverse(ss: &str, start: uint) -> CharRange {
1871+
pub fn char_range_at_reverse(ss: &str, start: uint) -> CharRange {
18701872
let mut prev = start;
18711873

18721874
// while there is a previous byte == 10......
@@ -1875,7 +1877,12 @@ fn char_range_at_reverse(ss: &str, start: uint) -> CharRange {
18751877
}
18761878

18771879
// now refer to the initial byte of previous char
1878-
prev -= 1u;
1880+
if prev > 0u {
1881+
prev -= 1u;
1882+
} else {
1883+
prev = 0u;
1884+
}
1885+
18791886

18801887
let ch = char_at(ss, prev);
18811888
return CharRange {ch:ch, next:prev};
@@ -3761,4 +3768,10 @@ mod tests {
37613768
"12345555".cmp(& &"123456") == Less;
37623769
"22".cmp(& &"1234") == Greater;
37633770
}
3771+
3772+
#[test]
3773+
fn test_char_range_at_reverse_underflow() {
3774+
assert!(char_range_at_reverse("abc", 0).next == 0);
3775+
}
3776+
37643777
}

0 commit comments

Comments
 (0)