Various cleanups and optimizations in core::str

Author: marijnh

src/comp/back/link.rs

@@ -440,8 +440,7 @@ fn build_link_meta(sess: session, c: ast::crate, output: str,
               none {
                 let name =
                     {
-                        let os = str::split_byte(
-                                   fs::basename(output), '.' as u8);
+                        let os = str::split_char(fs::basename(output), '.');
                         if (vec::len(os) < 2u) {
                             sess.fatal(#fmt("Output file name %s doesn't\
                               appear to have an extension", output));
@@ -576,7 +575,7 @@ fn link_binary(sess: session,
             } else { ret filename; }
         };
         fn rmext(filename: str) -> str {
-            let parts = str::split_byte(filename, '.' as u8);
+            let parts = str::split_char(filename, '.');
             vec::pop(parts);
             ret str::connect(parts, ".");
         }

src/comp/back/rpath.rs

@@ -121,8 +121,8 @@ fn get_relative_to(abs1: fs::path, abs2: fs::path) -> fs::path {
            abs1, abs2);
     let normal1 = fs::normalize(abs1);
     let normal2 = fs::normalize(abs2);
-    let split1 = str::split_byte(normal1, os_fs::path_sep as u8);
-    let split2 = str::split_byte(normal2, os_fs::path_sep as u8);
+    let split1 = str::split_char(normal1, os_fs::path_sep);
+    let split2 = str::split_char(normal2, os_fs::path_sep);
     let len1 = vec::len(split1);
     let len2 = vec::len(split2);
     assert len1 > 0u;

src/comp/metadata/cstore.rs

@@ -119,7 +119,7 @@ fn get_used_libraries(cstore: cstore) -> [str] {
 }
 
 fn add_used_link_args(cstore: cstore, args: str) {
-    p(cstore).used_link_args += str::split_byte(args, ' ' as u8);
+    p(cstore).used_link_args += str::split_char(args, ' ');
 }
 
 fn get_used_link_args(cstore: cstore) -> [str] {

src/comp/syntax/codemap.rs

@@ -176,16 +176,16 @@ fn lookup_byte_offset(cm: codemap::codemap, chpos: uint)
 }
 
 fn span_to_snippet(sp: span, cm: codemap::codemap) -> str {
-    let begin = lookup_byte_offset(cm,sp.lo);
-    let end   = lookup_byte_offset(cm,sp.hi);
+    let begin = lookup_byte_offset(cm, sp.lo);
+    let end = lookup_byte_offset(cm, sp.hi);
     assert begin.fm == end.fm;
-    ret str::slice_chars(*begin.fm.src, begin.pos, end.pos);
+    ret str::slice(*begin.fm.src, begin.pos, end.pos);
 }
 
 fn get_snippet(cm: codemap::codemap, fidx: uint, lo: uint, hi: uint) -> str
 {
     let fm = cm.files[fidx];
-    ret str::slice_chars(*fm.src, lo, hi)
+    ret str::slice(*fm.src, lo, hi)
 }
 
 fn get_filemap(cm: codemap, filename: str) -> filemap {