---

yaml
---
r: 11897
b: refs/heads/master
c: 26b54cc
h: refs/heads/master
i:
  11895: a054e68
v: v3

Author: catamorphism

[refs]

@@ -1,5 +1,5 @@
 ---
-refs/heads/master: f67f2388f717fc474cf9af5c13b75675209df58d
+refs/heads/master: 26b54cc17e13e3d784d3f25bdbe500ec18cefd7b
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
 refs/heads/try: 2898dcc5d97da9427ac367542382b6239d9c0bbf

trunk/src/libcore/char.rs

@@ -123,21 +123,23 @@ pure fn to_digit(c: char, radix: uint) -> option<uint> {
 }
 
 /*
- FIXME: works only on ASCII
+ FIXME: works only on ASCII (Issue #1985)
 */
 #[doc = "Convert a char to the corresponding lower case."]
 pure fn to_lower(c: char) -> char {
+    assert is_ascii(c);
     alt c {
       'A' to 'Z' { ((c as u8) + 32u8) as char }
       _ { c }
     }
 }
 
 /*
- FIXME: works only on ASCII
+ FIXME: works only on ASCII (Issue 1985)
 */
 #[doc = "Convert a char to the corresponding upper case."]
 pure fn to_upper(c: char) -> char {
+    assert is_ascii(c);
     alt c {
       'a' to 'z' { ((c as u8) - 32u8) as char }
       _ { c }
@@ -208,16 +210,18 @@ fn test_to_digit() {
 fn test_to_lower() {
     assert (to_lower('H') == 'h');
     assert (to_lower('e') == 'e');
+    // non-ASCII, shouldn't work (see earlier FIXME)
     //assert (to_lower('Ö') == 'ö');
-    assert (to_lower('ß') == 'ß');
+    //assert (to_lower('ß') == 'ß');
 }
 
 #[test]
 fn test_to_upper() {
     assert (to_upper('l') == 'L');
     assert (to_upper('Q') == 'Q');
+    // non-ASCII, shouldn't work (see earlier FIXME)
     //assert (to_upper('ü') == 'Ü');
-    assert (to_upper('ß') == 'ß');
+    //assert (to_upper('ß') == 'ß');
 }
 
 #[test]