@@ -324,9 +324,9 @@ pub trait BitDenotation {
324
324
/// "transfer-function" represnting the overall-effect of the
325
325
/// block, represented via GEN and KILL sets.
326
326
///
327
- /// The statement here is `idx_stmt.1`; ` idx_stmt.0` is just
328
- /// an identifying index: namely, the index of the statement
329
- /// in the basic block .
327
+ /// The statement is identified as `bb_data[ idx_stmt]`, where
328
+ /// `bb_data` is the sequence of statements identifed by `bb` in
329
+ /// the MIR .
330
330
fn statement_effect ( & self ,
331
331
ctxt : & Self :: Ctxt ,
332
332
sets : & mut BlockSets < Self :: Idx > ,
@@ -341,10 +341,6 @@ pub trait BitDenotation {
341
341
/// "transfer-function" represnting the overall-effect of the
342
342
/// block, represented via GEN and KILL sets.
343
343
///
344
- /// The terminator here is `idx_term.1`; `idx_term.0` is just an
345
- /// identifying index: namely, the number of statements in `bb`
346
- /// itself.
347
- ///
348
344
/// The effects applied here cannot depend on which branch the
349
345
/// terminator took.
350
346
fn terminator_effect ( & self ,
@@ -367,6 +363,11 @@ pub trait BitDenotation {
367
363
/// flow-dependent, the current MIR cannot encode them via just
368
364
/// GEN and KILL sets attached to the block, and so instead we add
369
365
/// this extra machinery to represent the flow-dependent effect.
366
+ ///
367
+ /// FIXME: Right now this is a bit of a wart in the API. It might
368
+ /// be better to represent this as an additional gen- and
369
+ /// kill-sets associated with each edge coming out of the basic
370
+ /// block.
370
371
fn propagate_call_return ( & self ,
371
372
ctxt : & Self :: Ctxt ,
372
373
in_out : & mut IdxSet < Self :: Idx > ,
0 commit comments