Skip to content

Commit d9daf37

Browse files
nikomatsakisalexcrichton
authored andcommitted
---
yaml --- r: 187021 b: refs/heads/try c: 63f51ee h: refs/heads/master i: 187019: dbbb291 v: v3
1 parent 83ae14c commit d9daf37

File tree

3 files changed

+34
-5
lines changed

3 files changed

+34
-5
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
refs/heads/master: b4c965ee803a4521d8b4575f634e036f93e408f3
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: 3a96d6a9818fe2affc98a187fb1065120458cee9
5-
refs/heads/try: d6e939a2df16338e9cf63ad19d1025a15069387c
5+
refs/heads/try: 63f51ee90ccc1b7ab3a749ba7dbd4a3c76961c16
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
88
refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596

branches/try/src/librustc/middle/traits/object_safety.rs

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,11 @@ fn supertraits_reference_self<'tcx>(tcx: &ty::ctxt<'tcx>,
138138
match predicate {
139139
ty::Predicate::Trait(ref data) => {
140140
// In the case of a trait predicate, we can skip the "self" type.
141-
data.0.trait_ref.substs.types.get_slice(TypeSpace)
142-
.iter()
143-
.cloned()
144-
.any(is_self)
141+
Some(data.def_id()) != tcx.lang_items.phantom_fn() &&
142+
data.0.trait_ref.substs.types.get_slice(TypeSpace)
143+
.iter()
144+
.cloned()
145+
.any(is_self)
145146
}
146147
ty::Predicate::Projection(..) |
147148
ty::Predicate::TypeOutlives(..) |
Lines changed: 28 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,28 @@
1+
// Copyright 2014 The Rust Project Developers. See the COPYRIGHT
2+
// file at the top-level directory of this distribution and at
3+
// http://rust-lang.org/COPYRIGHT.
4+
//
5+
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or
6+
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license
7+
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your
8+
// option. This file may not be copied, modified, or distributed
9+
// except according to those terms.
10+
11+
// Check that `Self` appearing in a phantom fn does not make a trait not object safe.
12+
13+
#![feature(rustc_attrs)]
14+
15+
trait Baz : PhantomFn<Self> {
16+
}
17+
18+
fn make_bar<T:Bar<u32>>(t: &T) -> &Bar<u32> {
19+
t
20+
}
21+
22+
fn make_baz<T:Baz>(t: &T) -> &Baz {
23+
t
24+
}
25+
26+
#[rustc_error]
27+
fn main() { //~ ERROR compilation successful
28+
}

0 commit comments

Comments
 (0)