Skip to content

Commit db14d81

Browse files
committed
Remove -sASSERTIONS=1 from wasm32_unknown_emscripten default link args
This is a debug setting. We should only make debug builds if user requests a debug build. Currently this is inserted in release builds. Furthermore, it would be better to insert these settings in --pre-link-args because then it would be possible to override them if appropriate. Because these are inserted at the end, it is necessary to patch emscripten to remove them.
1 parent 1a97162 commit db14d81

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

compiler/rustc_target/src/spec/wasm32_unknown_emscripten.rs

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -20,8 +20,6 @@ pub fn target() -> Target {
2020
"-s".into(),
2121
"ERROR_ON_UNDEFINED_SYMBOLS=1".into(),
2222
"-s".into(),
23-
"ASSERTIONS=1".into(),
24-
"-s".into(),
2523
"ABORTING_MALLOC=0".into(),
2624
"-Wl,--fatal-warnings".into(),
2725
],

0 commit comments

Comments
 (0)