refresh expected ones

Author: klensy

compiler/rustc_ast/src/token.rs

@@ -209,6 +209,7 @@ impl Lit {
         }
     }
 
+    // tidy-keep-sync-with=tidy-ticket-ast-from_token
     /// Keep this in sync with `Token::can_begin_literal_maybe_minus` excluding unary negation.
     pub fn from_token(token: &Token) -> Option<Lit> {
         match token.uninterpolate().kind {
@@ -223,6 +224,7 @@ impl Lit {
             _ => None,
         }
     }
+    // tidy-keep-sync-with=tidy-ticket-ast-from_token
 }
 
 impl fmt::Display for Lit {
@@ -748,6 +750,7 @@ impl Token {
     ///
     /// In other words, would this token be a valid start of `parse_literal_maybe_minus`?
     ///
+    // tidy-keep-sync-with=tidy-ticket-ast-can_begin_literal_maybe_minus
     /// Keep this in sync with and `Lit::from_token`, excluding unary negation.
     pub fn can_begin_literal_maybe_minus(&self) -> bool {
         match self.uninterpolate().kind {
@@ -774,6 +777,7 @@ impl Token {
             _ => false,
         }
     }
+    // tidy-keep-sync-with=tidy-ticket-ast-can_begin_literal_maybe_minus
 
     pub fn can_begin_string_literal(&self) -> bool {
         match self.uninterpolate().kind {

compiler/rustc_builtin_macros/src/assert/context.rs

@@ -291,6 +291,7 @@ impl<'cx, 'a> Context<'cx, 'a> {
             }
             // Expressions that are not worth or can not be captured.
             //
+            // tidy-keep-sync-with=tidy-ticket-all-expr-kinds
             // Full list instead of `_` to catch possible future inclusions and to
             // sync with the `rfc-2011-nicer-assert-messages/all-expr-kinds.rs` test.
             ExprKind::Assign(_, _, _)
@@ -323,7 +324,7 @@ impl<'cx, 'a> Context<'cx, 'a> {
             | ExprKind::Yeet(_)
             | ExprKind::Become(_)
             | ExprKind::Yield(_)
-            | ExprKind::UnsafeBinderCast(..) => {}
+            | ExprKind::UnsafeBinderCast(..) => {} // tidy-keep-sync-with=tidy-ticket-all-expr-kinds
         }
     }
 

compiler/rustc_codegen_ssa/src/back/write.rs

@@ -754,6 +754,7 @@ impl<B: WriteBackendMethods> WorkItem<B> {
         }
     }
 
+    // tidy-keep-sync-with=tidy-ticket-short_description
     /// Generate a short description of this work item suitable for use as a thread name.
     fn short_description(&self) -> String {
         // `pthread_setname()` on *nix ignores anything beyond the first 15
@@ -801,6 +802,7 @@ impl<B: WriteBackendMethods> WorkItem<B> {
             WorkItem::LTO(m) => desc("lto", "LTO module", m.name()),
         }
     }
+    // tidy-keep-sync-with=tidy-ticket-short_description
 }
 
 /// A result produced by the backend.

compiler/rustc_const_eval/src/interpret/validity.rs

@@ -707,6 +707,7 @@ impl<'rt, 'tcx, M: Machine<'tcx>> ValidityVisitor<'rt, 'tcx, M> {
                 interp_ok(true)
             }
             ty::Float(_) | ty::Int(_) | ty::Uint(_) => {
+                // tidy-keep-sync-with=tidy-ticket-try_visit_primitive
                 // NOTE: Keep this in sync with the array optimization for int/float
                 // types below!
                 self.read_scalar(
@@ -722,6 +723,7 @@ impl<'rt, 'tcx, M: Machine<'tcx>> ValidityVisitor<'rt, 'tcx, M> {
                     self.add_data_range_place(value);
                 }
                 interp_ok(true)
+                // tidy-keep-sync-with=tidy-ticket-try_visit_primitive
             }
             ty::RawPtr(..) => {
                 let place = self.deref_pointer(value, ExpectedKind::RawPtr)?;
@@ -1188,9 +1190,10 @@ impl<'rt, 'tcx, M: Machine<'tcx>> ValueVisitor<'tcx, M> for ValidityVisitor<'rt,
                     }
                 };
 
+                // tidy-keep-sync-with=tidy-ticket-visit_value
                 // Optimization: we just check the entire range at once.
                 // NOTE: Keep this in sync with the handling of integer and float
-                // types above, in `visit_primitive`.
+                // types above, in `try_visit_primitive`.
                 // No need for an alignment check here, this is not an actual memory access.
                 let alloc = self.ecx.get_ptr_alloc(mplace.ptr(), size)?.expect("we already excluded size 0");
 
@@ -1230,6 +1233,7 @@ impl<'rt, 'tcx, M: Machine<'tcx>> ValueVisitor<'tcx, M> for ValidityVisitor<'rt,
                     // Also, mark this as containing data, not padding.
                     self.add_data_range(mplace.ptr(), size);
                 }
+                // tidy-keep-sync-with=tidy-ticket-visit_value
             }
             // Fast path for arrays and slices of ZSTs. We only need to check a single ZST element
             // of an array and not all of them, because there's only a single value of a specific

compiler/rustc_data_structures/src/profiling.rs

@@ -126,6 +126,7 @@ bitflags::bitflags! {
     }
 }
 
+// tidy-keep-sync-with=tidy-ticket-self-profile-events
 // keep this in sync with the `-Z self-profile-events` help message in rustc_session/options.rs
 const EVENT_FILTERS_BY_NAME: &[(&str, EventFilter)] = &[
     ("none", EventFilter::empty()),
@@ -143,6 +144,7 @@ const EVENT_FILTERS_BY_NAME: &[(&str, EventFilter)] = &[
     ("incr-result-hashing", EventFilter::INCR_RESULT_HASHING),
     ("artifact-sizes", EventFilter::ARTIFACT_SIZES),
 ];
+// tidy-keep-sync-with=tidy-ticket-self-profile-events
 
 /// Something that uniquely identifies a query invocation.
 pub struct QueryInvocationId(pub u32);

compiler/rustc_errors/src/json.rs

@@ -275,6 +275,8 @@ struct FutureIncompatReport<'a> {
     future_incompat_report: Vec<FutureBreakageItem<'a>>,
 }
 
+// tidy-keep-sync-with=tidy-ticket-UnusedExterns
+// FIXME: where it located in cargo?
 // NOTE: Keep this in sync with the equivalent structs in rustdoc's
 // doctest component (as well as cargo).
 // We could unify this struct the one in rustdoc but they have different
@@ -286,6 +288,7 @@ struct UnusedExterns<'a> {
     /// List of unused externs by their names.
     unused_extern_names: &'a [&'a str],
 }
+// tidy-keep-sync-with=tidy-ticket-UnusedExterns
 
 impl Diagnostic {
     /// Converts from `rustc_errors::DiagInner` to `Diagnostic`.

compiler/rustc_hir_analysis/src/check/region.rs

@@ -116,6 +116,7 @@ fn resolve_block<'tcx>(visitor: &mut ScopeResolutionVisitor<'tcx>, blk: &'tcx hi
     visitor.cx.var_parent = visitor.cx.parent;
 
     {
+        // FIXME: sync with exactly where?
         // This block should be kept approximately in sync with
         // `intravisit::walk_block`. (We manually walk the block, rather
         // than call `walk_block`, in order to maintain precise

compiler/rustc_middle/src/ty/util.rs

@@ -694,6 +694,7 @@ impl<'tcx> TyCtxt<'tcx> {
             && !self.is_foreign_item(def_id)
     }
 
+    // tidy-keep-sync-with=tidy-ticket-thread_local_ptr_ty
     /// Returns the type a reference to the thread local takes in MIR.
     pub fn thread_local_ptr_ty(self, def_id: DefId) -> Ty<'tcx> {
         let static_ty = self.type_of(def_id).instantiate_identity();
@@ -706,14 +707,17 @@ impl<'tcx> TyCtxt<'tcx> {
             Ty::new_imm_ref(self, self.lifetimes.re_static, static_ty)
         }
     }
+    // tidy-keep-sync-with=tidy-ticket-thread_local_ptr_ty
 
     /// Get the type of the pointer to the static that we use in MIR.
     pub fn static_ptr_ty(self, def_id: DefId, typing_env: ty::TypingEnv<'tcx>) -> Ty<'tcx> {
         // Make sure that any constants in the static's type are evaluated.
         let static_ty =
             self.normalize_erasing_regions(typing_env, self.type_of(def_id).instantiate_identity());
 
+        // tidy-keep-sync-with=tidy-ticket-static_ptr_ty
         // Make sure that accesses to unsafe statics end up using raw pointers.
+        // FIXME: should it said sync with thread_local_ptr_ty?
         // For thread-locals, this needs to be kept in sync with `Rvalue::ty`.
         if self.is_mutable_static(def_id) {
             Ty::new_mut_ptr(self, static_ty)
@@ -722,6 +726,7 @@ impl<'tcx> TyCtxt<'tcx> {
         } else {
             Ty::new_imm_ref(self, self.lifetimes.re_erased, static_ty)
         }
+        // tidy-keep-sync-with=tidy-ticket-static_ptr_ty
     }
 
     /// Return the set of types that should be taken into account when checking

compiler/rustc_monomorphize/src/partitioning.rs

@@ -500,13 +500,16 @@ fn merge_codegen_units<'tcx>(
         codegen_units.sort_by_key(|cgu| cmp::Reverse(cgu.size_estimate()));
         let num_digits = codegen_units.len().ilog10() as usize + 1;
         for (index, cgu) in codegen_units.iter_mut().enumerate() {
+            // tidy-keep-sync-with=tidy-ticket-short_description
+            // FIXME: is it sync?
             // Note: `WorkItem::short_description` depends on this name ending
             // with `-cgu.` followed by a numeric suffix. Please keep it in
             // sync with this code.
             let suffix = format!("{index:0num_digits$}");
             let numbered_codegen_unit_name =
                 cgu_name_builder.build_cgu_name_no_mangle(LOCAL_CRATE, &["cgu"], Some(suffix));
             cgu.set_name(numbered_codegen_unit_name);
+            // tidy-keep-sync-with=tidy-ticket-short_description
         }
     }
 }

compiler/rustc_next_trait_solver/src/solve/assembly/structural_traits.rs

@@ -255,6 +255,7 @@ where
     }
 }
 
+// tidy-keep-sync-with=tidy-ticket-extract_tupled_inputs_and_output_from_callable
 // Returns a binder of the tupled inputs types and output type from a builtin callable type.
 pub(in crate::solve) fn extract_tupled_inputs_and_output_from_callable<I: Interner>(
     cx: I,
@@ -393,6 +394,7 @@ pub(in crate::solve) fn extract_tupled_inputs_and_output_from_callable<I: Intern
         }
     }
 }
+// tidy-keep-sync-with=tidy-ticket-extract_tupled_inputs_and_output_from_callable
 
 /// Relevant types for an async callable, including its inputs, output,
 /// and the return type you get from awaiting the output.

compiler/rustc_parse/src/parser/expr.rs

@@ -2181,6 +2181,7 @@ impl<'a> Parser<'a> {
         }
     }
 
+    // tidy-keep-sync-with=tidy-ticket-rustc_parse-can_begin_literal_maybe_minus
     /// Matches `'-' lit | lit` (cf. `ast_validation::AstValidator::check_expr_within_pat`).
     /// Keep this in sync with `Token::can_begin_literal_maybe_minus`.
     pub fn parse_literal_maybe_minus(&mut self) -> PResult<'a, P<Expr>> {
@@ -2216,6 +2217,7 @@ impl<'a> Parser<'a> {
             Ok(expr)
         }
     }
+    // tidy-keep-sync-with=tidy-ticket-rustc_parse-can_begin_literal_maybe_minus
 
     fn is_array_like_block(&mut self) -> bool {
         self.look_ahead(1, |t| matches!(t.kind, TokenKind::Ident(..) | TokenKind::Literal(_)))

compiler/rustc_pattern_analysis/src/constructor.rs

@@ -782,11 +782,14 @@ impl<Cx: PatCx> Constructor<Cx> {
         }
     }
 
+    // tidy-keep-sync-with=tidy-ticket-arity
     /// The number of fields for this constructor. This must be kept in sync with
     /// `Fields::wildcards`.
+    // FIXME: this comment long ago desynced
     pub(crate) fn arity(&self, cx: &Cx, ty: &Cx::Ty) -> usize {
         cx.ctor_arity(self, ty)
     }
+    // tidy-keep-sync-with=tidy-ticket-arity
 
     /// Returns whether `self` is covered by `other`, i.e. whether `self` is a subset of `other`.
     /// For the simple cases, this is simply checking for equality. For the "grouped" constructors,

compiler/rustc_session/src/config/cfg.rs

@@ -340,6 +340,7 @@ impl CheckCfg {
         // The exceptions are where control flow forces things out of order.
         //
         // NOTE: This should be kept in sync with `default_configuration`.
+        // FIXME: what exactly sync there?
         // Note that symbols inserted conditionally in `default_configuration`
         // are inserted unconditionally here.
         //

compiler/rustc_session/src/config/sigpipe.rs

@@ -1,3 +1,4 @@
+// tidy-keep-sync-with=tidy-ticket-sigpipe
 //! NOTE: Keep these constants in sync with `library/std/src/sys/pal/unix/mod.rs`!
 
 /// The default value if `-Zon-broken-pipe=...` is not specified. This resolves
@@ -23,3 +24,4 @@ pub const SIG_IGN: u8 = 2;
 /// such as `head -n 1`.
 #[allow(dead_code)]
 pub const SIG_DFL: u8 = 3;
+// tidy-keep-sync-with=tidy-ticket-sigpipe

compiler/rustc_session/src/options.rs

@@ -2454,12 +2454,14 @@ written to standard error output)"),
         `instructions:u` (retired instructions, userspace-only)
         `instructions-minus-irqs:u` (subtracting hardware interrupt counts for extra accuracy)"
     ),
-    /// keep this in sync with the event filter names in librustc_data_structures/profiling.rs
+    // tidy-keep-sync-with=tidy-ticket-self-profile-events
+    /// keep this in sync with the event filter names in rustc_data_structures/src/profiling.rs
     self_profile_events: Option<Vec<String>> = (None, parse_opt_comma_list, [UNTRACKED],
         "specify the events recorded by the self profiler;
         for example: `-Z self-profile-events=default,query-keys`
-        all options: none, all, default, generic-activity, query-provider, query-cache-hit
-                     query-blocked, incr-cache-load, incr-result-hashing, query-keys, function-args, args, llvm, artifact-sizes"),
+        all options: none, all, default, generic-activity, query-provider, query-cache-hit,
+                     query-blocked, incr-cache-load, query-keys, function-args, args, llvm, incr-result-hashing, artifact-sizes"),
+    // tidy-keep-sync-with=tidy-ticket-self-profile-events
     share_generics: Option<bool> = (None, parse_opt_bool, [TRACKED],
         "make the current crate share its generic instantiations"),
     shell_argfiles: bool = (false, parse_bool, [UNTRACKED],

compiler/rustc_trait_selection/src/traits/project.rs

@@ -927,6 +927,7 @@ fn assemble_candidates_from_impls<'cx, 'tcx>(
         };
 
         let eligible = match &impl_source {
+            // tidy-keep-sync-with=tidy-ticket-assemble_candidates_from_impls-UserDefined
             ImplSource::UserDefined(impl_data) => {
                 // We have to be careful when projecting out of an
                 // impl because of specialization. If we are not in
@@ -991,6 +992,7 @@ fn assemble_candidates_from_impls<'cx, 'tcx>(
                     Err(ErrorGuaranteed { .. }) => true,
                 }
             }
+            // tidy-keep-sync-with=tidy-ticket-assemble_candidates_from_impls-UserDefined
             ImplSource::Builtin(BuiltinImplSource::Misc | BuiltinImplSource::Trivial, _) => {
                 // While a builtin impl may be known to exist, the associated type may not yet
                 // be known. Any type with multiple potential associated types is therefore

compiler/rustc_trait_selection/src/traits/select/candidate_assembly.rs

@@ -503,6 +503,7 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
         }
     }
 
+    // tidy-keep-sync-with=tidy-ticket-assemble_fn_pointer_candidates
     /// Implements one of the `Fn()` family for a fn pointer.
     fn assemble_fn_pointer_candidates(
         &mut self,
@@ -542,6 +543,7 @@ impl<'cx, 'tcx> SelectionContext<'cx, 'tcx> {
             _ => {}
         }
     }
+    // tidy-keep-sync-with=tidy-ticket-assemble_fn_pointer_candidates
 
     /// Searches for impls that might apply to `obligation`.
     #[instrument(level = "debug", skip(self, candidates))]

compiler/rustc_ty_utils/src/instance.rs

@@ -117,6 +117,7 @@ fn resolve_associated_item<'tcx>(
     // Now that we know which impl is being used, we can dispatch to
     // the actual function:
     Ok(match vtbl {
+        // tidy-keep-sync-with=tidy-ticket-resolve_associated_item-UserDefined
         traits::ImplSource::UserDefined(impl_data) => {
             debug!(
                 "resolving ImplSource::UserDefined: {:?}, {:?}, {:?}, {:?}",
@@ -230,6 +231,7 @@ fn resolve_associated_item<'tcx>(
 
             Some(ty::Instance::new(leaf_def.item.def_id, args))
         }
+        // tidy-keep-sync-with=tidy-ticket-resolve_associated_item-UserDefined
         traits::ImplSource::Builtin(BuiltinImplSource::Object(_), _) => {
             let trait_ref = ty::TraitRef::from_method(tcx, trait_id, rcvr_args);
             if trait_ref.has_non_region_infer() || trait_ref.has_non_region_param() {

library/alloc/src/boxed.rs

@@ -226,6 +226,7 @@ pub use thin::ThinBox;
 #[stable(feature = "rust1", since = "1.0.0")]
 #[rustc_insignificant_dtor]
 #[doc(search_unbox)]
+// FIXME: Sync with what?
 // The declaration of the `Box` struct must be kept in sync with the
 // compiler or ICEs will happen.
 pub struct Box<

library/core/src/ptr/metadata.rs

@@ -58,10 +58,12 @@ use crate::ptr::NonNull;
 pub trait Pointee {
     /// The type for metadata in pointers and references to `Self`.
     #[lang = "metadata_type"]
+    // tidy-keep-sync-with=tidy-ticket-static_assert_expected_bounds_for_metadata
     // NOTE: Keep trait bounds in `static_assert_expected_bounds_for_metadata`
-    // in `library/core/src/ptr/metadata.rs`
+    // in `library/core/tests/ptr.rs`
     // in sync with those here:
     type Metadata: fmt::Debug + Copy + Send + Sync + Ord + Hash + Unpin + Freeze;
+    // tidy-keep-sync-with=tidy-ticket-static_assert_expected_bounds_for_metadata
 }
 
 /// Pointers to types implementing this trait alias are “thin”.

library/coretests/tests/ptr.rs

@@ -586,12 +586,15 @@ fn ptr_metadata_bounds() {
         let _ = static_assert_expected_bounds_for_metadata::<<T as Pointee>::Metadata>;
     }
 
+    // tidy-keep-sync-with=tidy-ticket-static_assert_expected_bounds_for_metadata
+    // FIXME: should be core::hash::hash?
     fn static_assert_expected_bounds_for_metadata<Meta>()
     where
         // Keep this in sync with the associated type in `library/core/src/ptr/metadata.rs`
         Meta: Debug + Copy + Send + Sync + Ord + std::hash::Hash + Unpin + Freeze,
     {
     }
+    // tidy-keep-sync-with=tidy-ticket-static_assert_expected_bounds_for_metadata
 }
 
 #[test]

library/std/src/sys/pal/unix/mod.rs

@@ -164,6 +164,7 @@ pub unsafe fn init(argc: isize, argv: *const *const u8, sigpipe: u8) {
             target_vendor = "unikraft",
         )))]
         {
+            // tidy-keep-sync-with=tidy-ticket-sigpipe
             // We don't want to add this as a public type to std, nor do we
             // want to `include!` a file from the compiler (which would break
             // Miri and xargo for example), so we choose to duplicate these
@@ -176,6 +177,7 @@ pub unsafe fn init(argc: isize, argv: *const *const u8, sigpipe: u8) {
                 pub const SIG_IGN: u8 = 2;
                 pub const SIG_DFL: u8 = 3;
             }
+            // tidy-keep-sync-with=tidy-ticket-sigpipe
 
             let (sigpipe_attr_specified, handler) = match sigpipe {
                 sigpipe::DEFAULT => (false, Some(libc::SIG_IGN)),

src/librustdoc/core.rs

@@ -333,10 +333,12 @@ pub(crate) fn run_global_ctxt(
     // typeck function bodies or run the default rustc lints.
     // (see `override_queries` in the `config`)
 
+    // tidy-keep-sync-with=tidy-ticket-sess-time-item_types_checking
     // NOTE: These are copy/pasted from typeck/lib.rs and should be kept in sync with those changes.
     let _ = tcx.sess.time("wf_checking", || {
         tcx.hir().try_par_for_each_module(|module| tcx.ensure_ok().check_mod_type_wf(module))
     });
+    // tidy-keep-sync-with=tidy-ticket-sess-time-item_types_checking
 
     tcx.dcx().abort_if_errors();