tidy: extdeps.rs: Avoid an unnecessary collect()

joshtriplett · joshtriplett · commit decc3b0eba16 · 2018-09-01T16:46:40.000-07:00
diff --git a/src/tools/tidy/src/extdeps.rs b/src/tools/tidy/src/extdeps.rs
@@ -37,8 +37,7 @@ pub fn check(path: &Path, bad: &mut bool) {
         }
 
         // extract source value
-        let parts: Vec<&str> = line.splitn(2, '=').collect();
-        let source = parts[1].trim();
+        let source = line.splitn(2, '=').nth(1).unwrap().trim();
 
         // ensure source is whitelisted
         if !WHITELISTED_SOURCES.contains(&&*source) {

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,7 @@ pub fn check(path: &Path, bad: &mut bool) {`
`37`	`37`	`}`
`38`	`38`
`39`	`39`	`// extract source value`
`40`		`- let parts: Vec<&str> = line.splitn(2, '=').collect();`
`41`		`- let source = parts[1].trim();`
	`40`	`+ let source = line.splitn(2, '=').nth(1).unwrap().trim();`
`42`	`41`
`43`	`42`	`// ensure source is whitelisted`
`44`	`43`	`if !WHITELISTED_SOURCES.contains(&&*source) {`