Skip to content

Commit e2f6052

Browse files
committed
Revert "rustc: Create def IDs for region parameters"
This reverts commit 0d4cb75.
1 parent 0d4cb75 commit e2f6052

File tree

7 files changed

+841
-899
lines changed

7 files changed

+841
-899
lines changed

src/rustc/metadata/astencode.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -434,7 +434,6 @@ impl of tr for ast::def {
434434
ast::def_class_method(did0, did1) {
435435
ast::def_class_method(did0.tr(xcx), did1.tr(xcx))
436436
}
437-
ast::def_region_param(did) { ast::def_region_param(did.tr(xcx)) }
438437
}
439438
}
440439
}
@@ -1005,4 +1004,4 @@ fn test_simplification() {
10051004
}
10061005
_ { fail; }
10071006
}
1008-
}
1007+
}

src/rustc/metadata/astencode_gen.rs

Lines changed: 834 additions & 886 deletions
Large diffs are not rendered by default.

src/rustc/middle/resolve.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1711,8 +1711,7 @@ fn ns_for_def(d: def) -> namespace {
17111711
{ ns_val(value_or_enum) }
17121712
ast::def_mod(_) | ast::def_native_mod(_) { ns_module }
17131713
ast::def_ty(_) | ast::def_binding(_) | ast::def_use(_) |
1714-
ast::def_ty_param(_, _) | ast::def_prim_ty(_) | ast::def_class(_) |
1715-
ast::def_region_param(_)
1714+
ast::def_ty_param(_, _) | ast::def_prim_ty(_) | ast::def_class(_)
17161715
{ ns_type }
17171716
}
17181717
}

src/rustc/syntax/ast.rs

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,6 @@ enum ty_param_bound {
2828

2929
type ty_param = {ident: ident, id: node_id, bounds: @[ty_param_bound]};
3030

31-
type region_param = {ident: ident, id: node_id};
32-
3331
enum def {
3432
def_fn(def_id, purity),
3533
def_self(node_id),
@@ -52,8 +50,7 @@ enum def {
5250
def_class_field(def_id, def_id),
5351
// No purity allowed for now, I guess
5452
// (simpler this way, b/c presumably methods read mutable state)
55-
def_class_method(def_id, def_id),
56-
def_region_param(def_id),
53+
def_class_method(def_id, def_id)
5754
}
5855

5956
// The set of meta_items that define the compilation environment of the crate,
@@ -345,7 +342,7 @@ enum prim_ty {
345342

346343
enum region {
347344
re_inferred,
348-
re_named(region_param),
345+
re_named(ident),
349346
re_self
350347
}
351348

src/rustc/syntax/ast_util.rs

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -39,8 +39,7 @@ fn def_id_of_def(d: def) -> def_id {
3939
def_native_mod(id) | def_const(id) |
4040
def_variant(_, id) | def_ty(id) | def_ty_param(id, _) |
4141
def_use(id) |
42-
def_class(id) | def_class_field(_, id) | def_class_method(_, id) |
43-
def_region_param(id) { id }
42+
def_class(id) | def_class_field(_, id) | def_class_method(_, id) { id }
4443

4544
def_arg(id, _) | def_local(id, _) | def_self(id) |
4645
def_upvar(id, _, _) | def_binding(id) {

src/rustc/syntax/parse/parser.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -424,7 +424,7 @@ fn parse_region(p: parser) -> ast::region {
424424
if string == "self" {
425425
ast::re_self
426426
} else {
427-
ast::re_named({ ident: string, id: p.get_id()})
427+
ast::re_named(string)
428428
}
429429
}
430430
_ { ast::re_inferred }

src/rustc/syntax/print/pprust.rs

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -316,7 +316,7 @@ fn print_native_mod(s: ps, nmod: ast::native_mod, attrs: [ast::attribute]) {
316316
fn print_region(s: ps, region: ast::region) {
317317
alt region {
318318
ast::re_inferred { /* no-op */ }
319-
ast::re_named(name) { word(s.s, name.ident); word(s.s, "."); }
319+
ast::re_named(name) { word(s.s, name); word(s.s, "."); }
320320
ast::re_self { word(s.s, "self"); word(s.s, "."); }
321321
}
322322
}

0 commit comments

Comments
 (0)