Skip to content

Commit e382aa3

Browse files
committed
---
yaml --- r: 207684 b: refs/heads/auto c: 10d6ae4e7b086c2947b646f018de670087500833 h: refs/heads/master v: v3
1 parent e609b43 commit e382aa3

File tree

3 files changed

+7
-19
lines changed

3 files changed

+7
-19
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503
1010
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1111
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1212
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
13-
refs/heads/auto: d9cbea0d6aa7e9d816ba78f25c4e8db64962aad8
13+
refs/heads/auto: 10d6ae4e7b086c2947b646f018de670087500833
1414
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
1515
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1616
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/mk/docs.mk

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -77,7 +77,8 @@ ERR_IDX_GEN = $(RPATH_VAR2_T_$(CFG_BUILD)_H_$(CFG_BUILD)) $(ERR_IDX_GEN_EXE)
7777

7878
D := $(S)src/doc
7979

80-
DOC_TARGETS := trpl style error-index
80+
# FIXME (#25705) eventually may want to put error-index target back here.
81+
DOC_TARGETS := trpl style
8182
COMPILER_DOC_TARGETS :=
8283
DOC_L10N_TARGETS :=
8384

branches/auto/src/libsyntax/diagnostics/plugin.rs

Lines changed: 4 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -14,7 +14,6 @@ use std::collections::BTreeMap;
1414
use ast;
1515
use ast::{Ident, Name, TokenTree};
1616
use codemap::Span;
17-
use diagnostics::metadata::{check_uniqueness, output_metadata, Duplicate};
1817
use ext::base::{ExtCtxt, MacEager, MacResult};
1918
use ext::build::AstBuilder;
2019
use parse::token;
@@ -148,7 +147,7 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
148147
token_tree: &[TokenTree])
149148
-> Box<MacResult+'cx> {
150149
assert_eq!(token_tree.len(), 3);
151-
let (crate_name, name) = match (&token_tree[0], &token_tree[2]) {
150+
let (_crate_name, name) = match (&token_tree[0], &token_tree[2]) {
152151
(
153152
// Crate name.
154153
&ast::TtToken(_, token::Ident(ref crate_name, _)),
@@ -158,21 +157,9 @@ pub fn expand_build_diagnostic_array<'cx>(ecx: &'cx mut ExtCtxt,
158157
_ => unreachable!()
159158
};
160159

161-
// Check uniqueness of errors and output metadata.
162-
with_registered_diagnostics(|diagnostics| {
163-
match check_uniqueness(crate_name, &*diagnostics) {
164-
Ok(Duplicate(err, location)) => {
165-
ecx.span_err(span, &format!(
166-
"error {} from `{}' also found in `{}'",
167-
err, crate_name, location
168-
));
169-
},
170-
Ok(_) => (),
171-
Err(e) => panic!("{}", e.description())
172-
}
173-
174-
output_metadata(&*ecx, crate_name, &*diagnostics).ok().expect("metadata output error");
175-
});
160+
// FIXME (#25705): we used to ensure error code uniqueness and
161+
// output error description JSON metadata here, but the approach
162+
// employed was too brittle.
176163

177164
// Construct the output expression.
178165
let (count, expr) =

0 commit comments

Comments
 (0)