Skip to content

Commit e604c15

Browse files
olsonjefferybrson
authored andcommitted
bindings to get/set data field on uv_loop_t* and debug log cleanup
1 parent f06362d commit e604c15

File tree

3 files changed

+34
-12
lines changed

3 files changed

+34
-12
lines changed

src/libstd/uv_ll.rs

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -568,6 +568,9 @@ native mod rustrt {
568568
-> *uv_stream_t;
569569
fn rust_uv_get_loop_for_uv_handle(handle: *libc::c_void)
570570
-> *libc::c_void;
571+
fn rust_uv_get_data_for_uv_loop(loop_ptr: *libc::c_void) -> *libc::c_void;
572+
fn rust_uv_set_data_for_uv_loop(loop_ptr: *libc::c_void,
573+
data: *libc::c_void);
571574
fn rust_uv_get_data_for_uv_handle(handle: *libc::c_void)
572575
-> *libc::c_void;
573576
fn rust_uv_set_data_for_uv_handle(handle: *libc::c_void,
@@ -744,7 +747,12 @@ unsafe fn get_stream_handle_from_write_req(
744747
ret rustrt::rust_uv_get_stream_handle_from_write_req(
745748
write_req);
746749
}
747-
750+
unsafe fn get_data_for_uv_loop(loop_ptr: *libc::c_void) -> *libc::c_void {
751+
rustrt::rust_uv_get_data_for_uv_loop(loop_ptr)
752+
}
753+
unsafe fn set_data_for_uv_loop(loop_ptr: *libc::c_void, data: *libc::c_void) {
754+
rustrt::rust_uv_set_data_for_uv_loop(loop_ptr, data);
755+
}
748756
unsafe fn get_data_for_uv_handle(handle: *libc::c_void) -> *libc::c_void {
749757
ret rustrt::rust_uv_get_data_for_uv_handle(handle);
750758
}

src/rt/rust_uv.cpp

Lines changed: 23 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -234,17 +234,17 @@ rust_uv_tcp_connect(uv_connect_t* connect_ptr,
234234
uv_connect_cb cb,
235235
sockaddr_in* addr_ptr) {
236236
rust_task* task = rust_get_current_task();
237-
LOG(task, stdlib, "inside rust_uv_tcp_connect\n");
237+
LOG(task, stdlib, "inside rust_uv_tcp_connect");
238238
// FIXME ref #2064
239239
sockaddr_in addr = *addr_ptr;
240-
LOG(task, stdlib, "before tcp_connect .. port: %d\n",
240+
LOG(task, stdlib, "before tcp_connect .. port: %d",
241241
addr.sin_port);
242242
LOG(task, stdlib, "before tcp_connect.. tcp stream:" \
243-
"%lu cb ptr: %lu\n",
243+
"%lu cb ptr: %lu",
244244
(unsigned long int)tcp_ptr, (unsigned long int)cb);
245245
int result = uv_tcp_connect(connect_ptr, tcp_ptr, addr, cb);
246246
LOG(task, stdlib, "leaving rust_uv_tcp_connect.." \
247-
"and result: %d\n",
247+
"and result: %d",
248248
result);
249249
return result;
250250
}
@@ -255,7 +255,7 @@ rust_uv_tcp_bind(uv_tcp_t* tcp_server, sockaddr_in* addr_ptr) {
255255
rust_task* task = rust_get_current_task();
256256
sockaddr_in addr = *addr_ptr;
257257
LOG(task, stdlib, "before uv_tcp_bind .. tcp_server:" \
258-
"%lu port: %d\n",
258+
"%lu port: %d",
259259
(unsigned long int)tcp_server, addr.sin_port);
260260
return uv_tcp_bind(tcp_server, addr);
261261
}
@@ -326,12 +326,12 @@ extern "C" void
326326
rust_uv_buf_init(uv_buf_t* out_buf, char* base, size_t len) {
327327
rust_task* task = rust_get_current_task();
328328
LOG(task, stdlib,"rust_uv_buf_init: base: %lu" \
329-
"len: %lu\n",
329+
"len: %lu",
330330
(unsigned long int)base,
331331
(unsigned long int)len);
332332
*out_buf = uv_buf_init(base, len);
333333
LOG(task, stdlib, "rust_uv_buf_init: after: "
334-
"result->base: %" PRIxPTR " len: %\n" PRIxPTR,
334+
"result->base: %" PRIxPTR " len: %" PRIxPTR,
335335
(unsigned long int)(*out_buf).base,
336336
(unsigned long int)(*out_buf).len);
337337
}
@@ -341,6 +341,17 @@ rust_uv_get_loop_for_uv_handle(uv_handle_t* handle) {
341341
return handle->loop;
342342
}
343343

344+
extern "C" void*
345+
rust_uv_get_data_for_uv_loop(uv_loop_t* loop) {
346+
return loop->data;
347+
}
348+
349+
extern "C" void
350+
rust_uv_set_data_for_uv_loop(uv_loop_t* loop,
351+
void* data) {
352+
loop->data = data;
353+
}
354+
344355
extern "C" void*
345356
rust_uv_get_data_for_uv_handle(uv_handle_t* handle) {
346357
return handle->data;
@@ -420,17 +431,18 @@ extern "C" struct sockaddr_in
420431
rust_uv_ip4_addr(const char* ip, int port) {
421432
rust_task* task = rust_get_current_task();
422433
LOG(task, stdlib, "before creating addr_ptr.. ip %s" \
423-
"port %d\n", ip, port);
434+
"port %d", ip, port);
424435
struct sockaddr_in addr = uv_ip4_addr(ip, port);
425-
LOG(task, stdlib, "after creating .. port: %d\n", addr.sin_port);
436+
LOG(task, stdlib, "after creating .. port: %d", addr.sin_port);
426437
return addr;
427438
}
428439

429440
extern "C" uintptr_t*
430441
rust_uv_get_kernel_global_chan_ptr() {
431442
uintptr_t* result = rust_get_current_task()->kernel->get_global_loop();
432-
printf("global loop: %lu\n", (unsigned long int)result);
433-
printf("global loop val: %lu\n", (unsigned long int)*result);
443+
rust_task* task = rust_get_current_task();
444+
LOG(task, stdlib, "global loop: %lu", (unsigned long int)result);
445+
LOG(task, stdlib,"global loop val: %lu", (unsigned long int)*result);
434446
return result;
435447
}
436448

src/rt/rustrt.def.in

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -128,6 +128,8 @@ rust_uv_helper_uv_async_t_size
128128
rust_uv_get_stream_handle_from_connect_req
129129
rust_uv_get_stream_handle_from_write_req
130130
rust_uv_get_loop_for_uv_handle
131+
rust_uv_get_data_for_uv_loop
132+
rust_uv_set_data_for_uv_loop
131133
rust_uv_get_data_for_uv_handle
132134
rust_uv_set_data_for_uv_handle
133135
rust_uv_get_data_for_req

0 commit comments

Comments
 (0)