---

yaml
---
r: 150182
b: refs/heads/try2
c: 403e869
h: refs/heads/master
v: v3

Author: bors

[refs]

@@ -5,7 +5,7 @@ refs/heads/snap-stage3: 78a7676898d9f80ab540c6df5d4c9ce35bb50463
 refs/heads/try: 519addf6277dbafccbb4159db4b710c37eaa2ec5
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
 refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
-refs/heads/try2: 9dc357b8ed0ebc0755f7247deb8314c74e1acf80
+refs/heads/try2: 403e8695712cd9779b9cc91c61e780d3bfb8212a
 refs/heads/dist-snap: ba4081a5a8573875fed17545846f6f6902c8ba8d
 refs/tags/release-0.2: c870d2dffb391e14efb05aa27898f1f6333a9596
 refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503

branches/try2/src/libstd/os.rs

@@ -740,11 +740,16 @@ pub fn last_os_error() -> ~str {
                                      buf.len() as DWORD,
                                      ptr::null());
             if res == 0 {
-                fail!("[{}] FormatMessage failure", errno());
+                // Sometimes FormatMessageW can fail e.g. system doesn't like langId,
+                let fm_err = errno();
+                return format!("OS Error {} (FormatMessageW() returned error {})", err, fm_err);
             }
 
-            str::from_utf16(str::truncate_utf16_at_nul(buf))
-                .expect("FormatMessageW returned invalid UTF-16")
+            let msg = str::from_utf16(str::truncate_utf16_at_nul(buf));
+            match msg {
+                Some(msg) => format!("OS Error {}: {}", err, msg),
+                None => format!("OS Error {} (FormatMessageW() returned invalid UTF-16)", err),
+            }
         }
     }