Skip to content

Commit e9ad573

Browse files
author
Jonathan S
committed
---
yaml --- r: 156565 b: refs/heads/auto c: 2343e9d h: refs/heads/master i: 156563: 8608735 v: v3
1 parent 1200d00 commit e9ad573

37 files changed

+396
-531
lines changed

‎[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ refs/heads/try3: 9387340aab40a73e8424c48fd42f0c521a4875c0
1313
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1414
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1515
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
16-
refs/heads/auto: 091b9811c83d545a56a8dea8cbf9e9a2a39caa3c
16+
refs/heads/auto: 2343e9d35403022425bed612ab9a26ccec72ed97
1717
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
1818
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1919
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

‎branches/auto/configure

Lines changed: 9 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -411,7 +411,6 @@ VAL_OPTIONS=""
411411

412412
opt valgrind 0 "run tests with valgrind (memcheck by default)"
413413
opt helgrind 0 "run tests with helgrind instead of memcheck"
414-
opt valgrind-rpass 1 "run rpass-valgrind tests with valgrind"
415414
opt docs 1 "build documentation"
416415
opt optimize 1 "build optimized rust code"
417416
opt optimize-cxx 1 "build optimized C++ code"
@@ -907,7 +906,6 @@ do
907906
done
908907

909908
make_dir $h/test/run-pass
910-
make_dir $h/test/run-pass-valgrind
911909
make_dir $h/test/run-pass-fulldeps
912910
make_dir $h/test/run-fail
913911
make_dir $h/test/compile-fail
@@ -1237,6 +1235,15 @@ then
12371235
putvar CFG_PANDOC
12381236
fi
12391237

1238+
# Valgrind is only reliable on Linux. On Windows it doesn't work at all, and
1239+
# on the Mac the dynamic linker causes Valgrind to emit a huge stream of
1240+
# errors.
1241+
if [ $CFG_OSTYPE != unknown-linux-gnu ] && [ $CFG_OSTYPE != apple-darwin ]
1242+
then
1243+
CFG_BAD_VALGRIND=1
1244+
putvar CFG_BAD_VALGRIND
1245+
fi
1246+
12401247
putvar CFG_LLVM_ROOT
12411248
putvar CFG_LLVM_SRC_DIR
12421249

‎branches/auto/mk/main.mk

Lines changed: 5 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -174,20 +174,16 @@ else
174174
CFG_VALGRIND_COMPILE :=
175175
endif
176176

177-
178-
ifndef CFG_DISABLE_VALGRIND_RPASS
179-
$(info cfg: enabling valgrind run-pass tests (CFG_ENABLE_VALGRIND_RPASS))
180-
CFG_VALGRIND_RPASS :=$(CFG_VALGRIND)
181-
else
182-
CFG_VALGRIND_RPASS :=
183-
endif
184-
185-
186177
ifdef CFG_ENABLE_VALGRIND
187178
$(info cfg: enabling valgrind (CFG_ENABLE_VALGRIND))
188179
else
189180
CFG_VALGRIND :=
190181
endif
182+
ifdef CFG_BAD_VALGRIND
183+
$(info cfg: disabling valgrind due to its unreliability on this platform)
184+
CFG_VALGRIND :=
185+
endif
186+
191187

192188
######################################################################
193189
# Target-and-rule "utility variables"

‎branches/auto/mk/platform.mk

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -58,20 +58,6 @@ ifdef CFG_VALGRIND
5858
endif
5959
endif
6060

61-
# If we actually want to run Valgrind on a given platform, set this variable
62-
define DEF_GOOD_VALGRIND
63-
ifeq ($(OSTYPE_$(1)),unknown-linux-gnu)
64-
GOOD_VALGRIND_$(1) = 1
65-
endif
66-
ifneq (,$(filter $(OSTYPE_$(1)),darwin freebsd))
67-
ifeq (HOST_$(1),x86_64)
68-
GOOD_VALGRIND_$(1) = 1
69-
endif
70-
endif
71-
endef
72-
$(foreach t,$(CFG_TARGET),$(eval $(call DEF_GOOD_VALGRIND,$(t))))
73-
$(foreach t,$(CFG_TARGET),$(info cfg: good valgrind for $(t) is $(GOOD_VALGRIND_$(t))))
74-
7561
ifneq ($(findstring linux,$(CFG_OSTYPE)),)
7662
ifdef CFG_PERF
7763
ifneq ($(CFG_PERF_WITH_LOGFD),)

‎branches/auto/mk/tests.mk

Lines changed: 17 additions & 40 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
# Copyright 2012-2014 The Rust Project Developers. See the COPYRIGHT
1+
# Copyright 2012 The Rust Project Developers. See the COPYRIGHT
22
# file at the top-level directory of this distribution and at
33
# http://rust-lang.org/COPYRIGHT.
44
#
@@ -184,12 +184,12 @@ check-notidy: cleantmptestlogs cleantestlibs all check-stage2
184184
# A slightly smaller set of tests for smoke testing.
185185
check-lite: cleantestlibs cleantmptestlogs \
186186
$(foreach crate,$(TEST_TARGET_CRATES),check-stage2-$(crate)) \
187-
check-stage2-rpass check-stage2-rpass-valgrind \
187+
check-stage2-rpass \
188188
check-stage2-rfail check-stage2-cfail check-stage2-rmake
189189
$(Q)$(CFG_PYTHON) $(S)src/etc/check-summary.py tmp/*.log
190190

191191
# Only check the 'reference' tests: rpass/cfail/rfail/rmake.
192-
check-ref: cleantestlibs cleantmptestlogs check-stage2-rpass check-stage2-rpass-valgrind \
192+
check-ref: cleantestlibs cleantmptestlogs check-stage2-rpass \
193193
check-stage2-rfail check-stage2-cfail check-stage2-rmake
194194
$(Q)$(CFG_PYTHON) $(S)src/etc/check-summary.py tmp/*.log
195195

@@ -326,8 +326,7 @@ check-stage$(1)-T-$(2)-H-$(3)-exec: \
326326
check-stage$(1)-T-$(2)-H-$(3)-rpass-exec \
327327
check-stage$(1)-T-$(2)-H-$(3)-rfail-exec \
328328
check-stage$(1)-T-$(2)-H-$(3)-cfail-exec \
329-
check-stage$(1)-T-$(2)-H-$(3)-rpass-valgrind-exec \
330-
check-stage$(1)-T-$(2)-H-$(3)-rpass-full-exec \
329+
check-stage$(1)-T-$(2)-H-$(3)-rpass-full-exec \
331330
check-stage$(1)-T-$(2)-H-$(3)-cfail-full-exec \
332331
check-stage$(1)-T-$(2)-H-$(3)-rmake-exec \
333332
check-stage$(1)-T-$(2)-H-$(3)-crates-exec \
@@ -365,7 +364,6 @@ check-stage$(1)-T-$(2)-H-$(3)-doc-exec: \
365364

366365
check-stage$(1)-T-$(2)-H-$(3)-pretty-exec: \
367366
check-stage$(1)-T-$(2)-H-$(3)-pretty-rpass-exec \
368-
check-stage$(1)-T-$(2)-H-$(3)-pretty-rpass-valgrind-exec \
369367
check-stage$(1)-T-$(2)-H-$(3)-pretty-rpass-full-exec \
370368
check-stage$(1)-T-$(2)-H-$(3)-pretty-rfail-exec \
371369
check-stage$(1)-T-$(2)-H-$(3)-pretty-bench-exec \
@@ -491,11 +489,15 @@ $(foreach host,$(CFG_HOST), \
491489
# Rules for the compiletest tests (rpass, rfail, etc.)
492490
######################################################################
493491

492+
RPASS_RC := $(wildcard $(S)src/test/run-pass/*.rc)
494493
RPASS_RS := $(wildcard $(S)src/test/run-pass/*.rs)
495-
RPASS_VALGRIND_RS := $(wildcard $(S)src/test/run-pass-valgrind/*.rs)
494+
RPASS_FULL_RC := $(wildcard $(S)src/test/run-pass-fulldeps/*.rc)
496495
RPASS_FULL_RS := $(wildcard $(S)src/test/run-pass-fulldeps/*.rs)
496+
CFAIL_FULL_RC := $(wildcard $(S)src/test/compile-fail-fulldeps/*.rc)
497497
CFAIL_FULL_RS := $(wildcard $(S)src/test/compile-fail-fulldeps/*.rs)
498+
RFAIL_RC := $(wildcard $(S)src/test/run-fail/*.rc)
498499
RFAIL_RS := $(wildcard $(S)src/test/run-fail/*.rs)
500+
CFAIL_RC := $(wildcard $(S)src/test/compile-fail/*.rc)
499501
CFAIL_RS := $(wildcard $(S)src/test/compile-fail/*.rs)
500502
BENCH_RS := $(wildcard $(S)src/test/bench/*.rs)
501503
PRETTY_RS := $(wildcard $(S)src/test/pretty/*.rs)
@@ -508,12 +510,11 @@ CODEGEN_CC := $(wildcard $(S)src/test/codegen/*.cc)
508510
# a performance monitor.
509511
PERF_RS := $(wildcard $(S)src/test/bench/*.rs)
510512

511-
RPASS_TESTS := $(RPASS_RS)
512-
RPASS_VALGRIND_TESTS := $(RPASS_VALGRIND_RS)
513-
RPASS_FULL_TESTS := $(RPASS_FULL_RS)
514-
CFAIL_FULL_TESTS := $(CFAIL_FULL_RS)
515-
RFAIL_TESTS := $(RFAIL_RS)
516-
CFAIL_TESTS := $(CFAIL_RS)
513+
RPASS_TESTS := $(RPASS_RC) $(RPASS_RS)
514+
RPASS_FULL_TESTS := $(RPASS_FULL_RC) $(RPASS_FULL_RS)
515+
CFAIL_FULL_TESTS := $(CFAIL_FULL_RC) $(CFAIL_FULL_RS)
516+
RFAIL_TESTS := $(RFAIL_RC) $(RFAIL_RS)
517+
CFAIL_TESTS := $(CFAIL_RC) $(CFAIL_RS)
517518
BENCH_TESTS := $(BENCH_RS)
518519
PERF_TESTS := $(PERF_RS)
519520
PRETTY_TESTS := $(PRETTY_RS)
@@ -526,11 +527,6 @@ CTEST_BUILD_BASE_rpass = run-pass
526527
CTEST_MODE_rpass = run-pass
527528
CTEST_RUNTOOL_rpass = $(CTEST_RUNTOOL)
528529

529-
CTEST_SRC_BASE_rpass-valgrind = run-pass-valgrind
530-
CTEST_BUILD_BASE_rpass-valgrind = run-pass-valgrind
531-
CTEST_MODE_rpass-valgrind = run-pass-valgrind
532-
CTEST_RUNTOOL_rpass-valgrind = $(CTEST_RUNTOOL)
533-
534530
CTEST_SRC_BASE_rpass-full = run-pass-fulldeps
535531
CTEST_BUILD_BASE_rpass-full = run-pass-fulldeps
536532
CTEST_MODE_rpass-full = run-pass
@@ -626,7 +622,7 @@ TEST_SREQ$(1)_T_$(2)_H_$(3) = \
626622
# remove directive, if present, from CFG_RUSTC_FLAGS (issue #7898).
627623
CTEST_RUSTC_FLAGS := $$(subst --cfg ndebug,,$$(CFG_RUSTC_FLAGS))
628624

629-
# The tests cannot be optimized while the rest of the compiler is optimized, so
625+
# The tests can not be optimized while the rest of the compiler is optimized, so
630626
# filter out the optimization (if any) from rustc and then figure out if we need
631627
# to be optimized
632628
CTEST_RUSTC_FLAGS := $$(subst -O,,$$(CTEST_RUSTC_FLAGS))
@@ -638,7 +634,6 @@ endif
638634
# slow things down.
639635
CTEST_RUSTC_FLAGS += -C codegen-units=1
640636

641-
642637
CTEST_COMMON_ARGS$(1)-T-$(2)-H-$(3) := \
643638
--compile-lib-path $$(HLIB$(1)_H_$(3)) \
644639
--run-lib-path $$(TLIB$(1)_T_$(2)_H_$(3)) \
@@ -659,21 +654,7 @@ CTEST_COMMON_ARGS$(1)-T-$(2)-H-$(3) := \
659654
--target-rustcflags "$(RUSTC_FLAGS_$(2)) $$(CTEST_RUSTC_FLAGS) -L $$(RT_OUTPUT_DIR_$(2))" \
660655
$$(CTEST_TESTARGS)
661656

662-
ifdef CFG_VALGRIND_RPASS
663-
ifdef GOOD_VALGRIND_$(2)
664-
$(info cfg: valgrind-path set to $(CFG_VALGRIND_RPASS))
665-
CTEST_COMMON_ARGS$(1)-T-$(2)-H-$(3) += --valgrind-path "$(CFG_VALGRIND_RPASS)"
666-
endif
667-
endif
668-
669-
ifndef CFG_DISABLE_VALGRIND_RPASS
670-
ifdef GOOD_VALGRIND_$(2)
671-
CTEST_COMMON_ARGS$(1)-T-$(2)-H-$(3) += --force-valgrind
672-
endif
673-
endif
674-
675657
CTEST_DEPS_rpass_$(1)-T-$(2)-H-$(3) = $$(RPASS_TESTS)
676-
CTEST_DEPS_rpass-valgrind_$(1)-T-$(2)-H-$(3) = $$(RPASS_VALGRIND_TESTS)
677658
CTEST_DEPS_rpass-full_$(1)-T-$(2)-H-$(3) = $$(RPASS_FULL_TESTS) $$(CSREQ$(1)_T_$(3)_H_$(3)) $$(SREQ$(1)_T_$(2)_H_$(3))
678659
CTEST_DEPS_cfail-full_$(1)-T-$(2)-H-$(3) = $$(CFAIL_FULL_TESTS) $$(CSREQ$(1)_T_$(3)_H_$(3)) $$(SREQ$(1)_T_$(2)_H_$(3))
679660
CTEST_DEPS_rfail_$(1)-T-$(2)-H-$(3) = $$(RFAIL_TESTS)
@@ -745,17 +726,16 @@ endif
745726

746727
endef
747728

748-
CTEST_NAMES = rpass rpass-valgrind rpass-full cfail-full rfail cfail bench perf debuginfo-gdb debuginfo-lldb codegen
729+
CTEST_NAMES = rpass rpass-full cfail-full rfail cfail bench perf debuginfo-gdb debuginfo-lldb codegen
749730

750731
$(foreach host,$(CFG_HOST), \
751732
$(eval $(foreach target,$(CFG_TARGET), \
752733
$(eval $(foreach stage,$(STAGES), \
753734
$(eval $(foreach name,$(CTEST_NAMES), \
754735
$(eval $(call DEF_RUN_COMPILETEST,$(stage),$(target),$(host),$(name))))))))))
755736

756-
PRETTY_NAMES = pretty-rpass pretty-rpass-valgrind pretty-rpass-full pretty-rfail pretty-bench pretty-pretty
737+
PRETTY_NAMES = pretty-rpass pretty-rpass-full pretty-rfail pretty-bench pretty-pretty
757738
PRETTY_DEPS_pretty-rpass = $(RPASS_TESTS)
758-
PRETTY_DEPS_pretty-rpass-valgrind = $(RPASS_VALGRIND_TESTS)
759739
PRETTY_DEPS_pretty-rpass-full = $(RPASS_FULL_TESTS)
760740
PRETTY_DEPS_pretty-rfail = $(RFAIL_TESTS)
761741
PRETTY_DEPS_pretty-bench = $(BENCH_TESTS)
@@ -768,7 +748,6 @@ PRETTY_DEPS$(1)_H_$(3)_pretty-rfail =
768748
PRETTY_DEPS$(1)_H_$(3)_pretty-bench =
769749
PRETTY_DEPS$(1)_H_$(3)_pretty-pretty =
770750
PRETTY_DIRNAME_pretty-rpass = run-pass
771-
PRETTY_DIRNAME_pretty-rpass-valgrind = run-pass-valgrind
772751
PRETTY_DIRNAME_pretty-rpass-full = run-pass-fulldeps
773752
PRETTY_DIRNAME_pretty-rfail = run-fail
774753
PRETTY_DIRNAME_pretty-bench = bench
@@ -916,7 +895,6 @@ TEST_GROUPS = \
916895
$(foreach crate,$(TEST_CRATES),$(crate)) \
917896
$(foreach crate,$(TEST_DOC_CRATES),doc-crate-$(crate)) \
918897
rpass \
919-
rpass-valgrind \
920898
rpass-full \
921899
cfail-full \
922900
rfail \
@@ -931,7 +909,6 @@ TEST_GROUPS = \
931909
$(foreach docname,$(DOCS),doc-$(docname)) \
932910
pretty \
933911
pretty-rpass \
934-
pretty-rpass-valgrind \
935912
pretty-rpass-full \
936913
pretty-rfail \
937914
pretty-bench \

‎branches/auto/src/compiletest/common.rs

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,6 @@ pub enum Mode {
1717
CompileFail,
1818
RunFail,
1919
RunPass,
20-
RunPassValgrind,
2120
Pretty,
2221
DebugInfoGdb,
2322
DebugInfoLldb,
@@ -30,7 +29,6 @@ impl FromStr for Mode {
3029
"compile-fail" => Some(CompileFail),
3130
"run-fail" => Some(RunFail),
3231
"run-pass" => Some(RunPass),
33-
"run-pass-valgrind" => Some(RunPassValgrind),
3432
"pretty" => Some(Pretty),
3533
"debuginfo-lldb" => Some(DebugInfoLldb),
3634
"debuginfo-gdb" => Some(DebugInfoGdb),
@@ -46,7 +44,6 @@ impl fmt::Show for Mode {
4644
CompileFail => "compile-fail",
4745
RunFail => "run-fail",
4846
RunPass => "run-pass",
49-
RunPassValgrind => "run-pass-valgrind",
5047
Pretty => "pretty",
5148
DebugInfoGdb => "debuginfo-gdb",
5249
DebugInfoLldb => "debuginfo-lldb",
@@ -73,13 +70,6 @@ pub struct Config {
7370
// The llvm binaries path
7471
pub llvm_bin_path: Option<Path>,
7572

76-
// The valgrind path
77-
pub valgrind_path: Option<String>,
78-
79-
// Whether to fail if we can't run run-pass-valgrind tests under valgrind
80-
// (or, alternatively, to silently run them like regular run-pass tests).
81-
pub force_valgrind: bool,
82-
8373
// The directory containing the tests to run
8474
pub src_base: Path,
8575

‎branches/auto/src/compiletest/compiletest.rs

Lines changed: 2 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -39,11 +39,6 @@ pub mod errors;
3939
pub fn main() {
4040
let args = os::args();
4141
let config = parse_config(args);
42-
43-
if config.valgrind_path.is_none() && config.force_valgrind {
44-
fail!("Can't find Valgrind to run Valgrind tests");
45-
}
46-
4742
log_config(&config);
4843
run_tests(&config);
4944
}
@@ -55,15 +50,13 @@ pub fn parse_config(args: Vec<String> ) -> Config {
5550
reqopt("", "run-lib-path", "path to target shared libraries", "PATH"),
5651
reqopt("", "rustc-path", "path to rustc to use for compiling", "PATH"),
5752
optopt("", "clang-path", "path to executable for codegen tests", "PATH"),
58-
optopt("", "valgrind-path", "path to Valgrind executable for Valgrind tests", "PROGRAM"),
59-
optflag("", "force-valgrind", "fail if Valgrind tests cannot be run under Valgrind"),
6053
optopt("", "llvm-bin-path", "path to directory holding llvm binaries", "DIR"),
6154
reqopt("", "src-base", "directory to scan for test files", "PATH"),
6255
reqopt("", "build-base", "directory to deposit test outputs", "PATH"),
6356
reqopt("", "aux-base", "directory to find auxiliary test files", "PATH"),
6457
reqopt("", "stage-id", "the target-stage identifier", "stageN-TARGET"),
6558
reqopt("", "mode", "which sort of compile tests to run",
66-
"(compile-fail|run-fail|run-pass|run-pass-valgrind|pretty|debug-info)"),
59+
"(compile-fail|run-fail|run-pass|pretty|debug-info)"),
6760
optflag("", "ignored", "run tests marked as ignored"),
6861
optopt("", "runtool", "supervisor program to run tests under \
6962
(eg. emulator, valgrind)", "PROGRAM"),
@@ -132,8 +125,6 @@ pub fn parse_config(args: Vec<String> ) -> Config {
132125
run_lib_path: matches.opt_str("run-lib-path").unwrap(),
133126
rustc_path: opt_path(matches, "rustc-path"),
134127
clang_path: matches.opt_str("clang-path").map(|s| Path::new(s)),
135-
valgrind_path: matches.opt_str("valgrind-path"),
136-
force_valgrind: matches.opt_present("force-valgrind"),
137128
llvm_bin_path: matches.opt_str("llvm-bin-path").map(|s| Path::new(s)),
138129
src_base: opt_path(matches, "src-base"),
139130
build_base: opt_path(matches, "build-base"),
@@ -171,7 +162,7 @@ pub fn parse_config(args: Vec<String> ) -> Config {
171162
!opt_str2(matches.opt_str("adb-test-dir")).is_empty(),
172163
lldb_python_dir: matches.opt_str("lldb-python-dir"),
173164
test_shard: test::opt_shard(matches.opt_str("test-shard")),
174-
verbose: matches.opt_present("verbose"),
165+
verbose: matches.opt_present("verbose")
175166
}
176167
}
177168

‎branches/auto/src/compiletest/runtest.rs

Lines changed: 2 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99
// except according to those terms.
1010

1111
use common::Config;
12-
use common::{CompileFail, Pretty, RunFail, RunPass, RunPassValgrind, DebugInfoGdb};
12+
use common::{CompileFail, Pretty, RunFail, RunPass, DebugInfoGdb};
1313
use common::{Codegen, DebugInfoLldb};
1414
use errors;
1515
use header::TestProps;
@@ -35,6 +35,7 @@ use std::time::Duration;
3535
use test::MetricMap;
3636

3737
pub fn run(config: Config, testfile: String) {
38+
3839
match config.target.as_slice() {
3940

4041
"arm-linux-androideabi" => {
@@ -63,7 +64,6 @@ pub fn run_metrics(config: Config, testfile: String, mm: &mut MetricMap) {
6364
CompileFail => run_cfail_test(&config, &props, &testfile),
6465
RunFail => run_rfail_test(&config, &props, &testfile),
6566
RunPass => run_rpass_test(&config, &props, &testfile),
66-
RunPassValgrind => run_valgrind_test(&config, &props, &testfile),
6767
Pretty => run_pretty_test(&config, &props, &testfile),
6868
DebugInfoGdb => run_debuginfo_gdb_test(&config, &props, &testfile),
6969
DebugInfoLldb => run_debuginfo_lldb_test(&config, &props, &testfile),
@@ -164,27 +164,6 @@ fn run_rpass_test(config: &Config, props: &TestProps, testfile: &Path) {
164164
}
165165
}
166166

167-
fn run_valgrind_test(config: &Config, props: &TestProps, testfile: &Path) {
168-
if config.valgrind_path.is_none() {
169-
assert!(!config.force_valgrind);
170-
return run_rpass_test(config, props, testfile);
171-
}
172-
173-
let mut proc_res = compile_test(config, props, testfile);
174-
175-
if !proc_res.status.success() {
176-
fatal_proc_rec("compilation failed!", &proc_res);
177-
}
178-
179-
let mut new_config = config.clone();
180-
new_config.runtool = new_config.valgrind_path.clone();
181-
proc_res = exec_compiled_test(&new_config, props, testfile);
182-
183-
if !proc_res.status.success() {
184-
fatal_proc_rec("test run failed!", &proc_res);
185-
}
186-
}
187-
188167
fn run_pretty_test(config: &Config, props: &TestProps, testfile: &Path) {
189168
if props.pp_exact.is_some() {
190169
logv(config, "testing for exact pretty-printing".to_string());

0 commit comments

Comments
 (0)