Skip to content

Commit ec5eee6

Browse files
---
yaml --- r: 231916 b: refs/heads/auto c: a056d58 h: refs/heads/master v: v3
1 parent d0e0939 commit ec5eee6

File tree

3 files changed

+28
-4
lines changed

3 files changed

+28
-4
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@ refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503
88
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
99
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1010
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
11-
refs/heads/auto: 6090cea18479f3a3bf12fe63034966cbe6eed2f7
11+
refs/heads/auto: a056d5869e808b7f26cb536eca1aadda26a8188f
1212
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1313
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336
1414
refs/tags/0.2: 1754d02027f2924bed83b0160ee340c7f41d5ea1

branches/auto/src/librustc_privacy/diagnostics.rs

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -125,4 +125,28 @@ To fix this error, please remove the visibility qualifier when it is not
125125
required.
126126
"##,
127127

128+
E0450: r##"
129+
A tuple constructor was invoked while some of its fields are private. Erroneous
130+
code example:
131+
132+
```
133+
mod Bar {
134+
pub struct Foo(isize);
135+
}
136+
137+
let f = Bar::Foo(0); // error: cannot invoke tuple struct constructor with
138+
// private fields
139+
```
140+
141+
To solve this issue, please ensure that all tuple's fields are public. Example:
142+
143+
```
144+
mod Bar {
145+
pub struct Foo(pub isize); // we set its field to public
146+
}
147+
148+
let f = Bar::Foo(0); // ok!
149+
```
150+
"##,
151+
128152
}

branches/auto/src/librustc_privacy/lib.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -931,9 +931,9 @@ impl<'a, 'tcx, 'v> Visitor<'v> for PrivacyVisitor<'a, 'tcx> {
931931
});
932932

933933
if any_priv {
934-
self.tcx.sess.span_err(expr.span,
935-
"cannot invoke tuple struct constructor \
936-
with private fields");
934+
span_err!(self.tcx.sess, expr.span, E0450,
935+
"cannot invoke tuple struct constructor with private \
936+
fields");
937937
}
938938
}
939939
}

0 commit comments

Comments
 (0)