Skip to content

Commit ed3145b

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 2f35916 commit ed3145b

File tree

1 file changed

+273
-0
lines changed

1 file changed

+273
-0
lines changed

‎triage/2023-09-05.md

Lines changed: 273 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,273 @@
1+
# 2023-09-05 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [cedbe5c715c1fa9359683c5f108bed2054ac258b..15e52b05ca8f63e0da27c808680388717e5b997e](https://perf.rust-lang.org/?start=cedbe5c715c1fa9359683c5f108bed2054ac258b&end=15e52b05ca8f63e0da27c808680388717e5b997e&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:---------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.2%] | 11 |
13+
| Regressions ❌ <br /> (secondary) | 1.0% | [0.2%, 2.0%] | 40 |
14+
| Improvements ✅ <br /> (primary) | -1.9% | [-10.2%, -0.3%] | 69 |
15+
| Improvements ✅ <br /> (secondary) | -1.5% | [-3.7%, -0.4%] | 26 |
16+
| All ❌✅ (primary) | -1.5% | [-10.2%, 1.2%] | 80 |
17+
18+
19+
4 Regressions, 7 Improvements, 8 Mixed; ??? of them in rollups
20+
66 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Adapt table sizes to the contents, accommodating u64 rmeta offsets [#113542](https://github.com/rust-lang/rust/pull/113542) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6e8f677c6a20bee7025f6c0a93a7dc9daced92bc&end=d64c84562f634efde5eb5506942b6af293d8358d&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 1.2%] | 11 |
29+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.2%, 1.3%] | 26 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.5% | [0.2%, 1.2%] | 11 |
33+
34+
35+
Use conditional synchronization for Lock [#111713](https://github.com/rust-lang/rust/pull/111713) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7659abc63d33223fa366c8781c81698e28a21e6c&end=61efe9d2981b87ec7f2800d62f98c594de151713&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 2.3% | [2.3%, 2.3%] | 1 |
40+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 2.3% | [2.3%, 2.3%] | 1 |
44+
45+
46+
update Miri [#115496](https://github.com/rust-lang/rust/pull/115496) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7cc5ac267f536ee2cf2f38961d9db8304a419d5a&end=b89d7d6882532686fd90a89cec1a0fd386f0ade3&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.4%] | 4 |
51+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.3%, 0.6%] | 5 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.4%] | 4 |
55+
56+
57+
Rollup of 5 pull requests [#115553](https://github.com/rust-lang/rust/pull/115553) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=626a6ab93fafd01b37b1e26c96cb6eec0d39f3eb&end=8cfaf70c320297dd1831a12351fcfeab7a231328&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:----:|:------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | 0.7% | [0.7%, 0.8%] | 6 |
62+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
63+
| Improvements ✅ <br /> (primary) | - | - | 0 |
64+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
65+
| All ❌✅ (primary) | 0.7% | [0.7%, 0.8%] | 6 |
66+
67+
68+
#### Improvements
69+
70+
Don't record spans for predicates in coherence [#115392](https://github.com/rust-lang/rust/pull/115392) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b1b244da6527cf2ba36e88d02275f4c64a0c90d8&end=e51c5ea16f84ef811bf0aecbdc0ac48821d52cc9&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -1.1% | [-2.5%, -0.3%] | 18 |
77+
| Improvements ✅ <br /> (secondary) | -0.8% | [-1.0%, -0.2%] | 8 |
78+
| All ❌✅ (primary) | -1.1% | [-2.5%, -0.3%] | 18 |
79+
80+
81+
Use `OnceLock` for `SingleCache` [#115422](https://github.com/rust-lang/rust/pull/115422) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f9ba43ce147707fb90d038983789d8e57451eb6d&end=9dc11a13fa848c1b09b7248c540528190dcb79c5&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 2 |
88+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.3%] | 8 |
89+
| All ❌✅ (primary) | -0.4% | [-0.4%, -0.4%] | 2 |
90+
91+
92+
Fall through when resolving elided assoc const lifetimes [#115429](https://github.com/rust-lang/rust/pull/115429) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=585bb5e68d85c1e4f32da3e2499343372626a436&end=9229b1eab44046253971445be47423ef779b178f&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.5%, -0.6%] | 7 |
99+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
100+
| All ❌✅ (primary) | -1.0% | [-1.5%, -0.6%] | 7 |
101+
102+
103+
Don't manually compute param indices when adding implicit `Sized` and `ConstParamHasTy` [#115361](https://github.com/rust-lang/rust/pull/115361) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b89d7d6882532686fd90a89cec1a0fd386f0ade3&end=53a03978a7402d20ce8254fa1493929d67e01d07&stat=instructions:u)
104+
105+
| (instructions:u) | mean | range | count |
106+
|:----------------------------------:|:-----:|:--------------:|:-----:|
107+
| Regressions ❌ <br /> (primary) | - | - | 0 |
108+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
109+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.5%, -0.2%] | 5 |
110+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.4%] | 2 |
111+
| All ❌✅ (primary) | -0.3% | [-0.5%, -0.2%] | 5 |
112+
113+
114+
Encode DepKind as u16 [#115391](https://github.com/rust-lang/rust/pull/115391) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=abfc6c44381fb033c6b3b0a6bfb804a799f39afd&end=b14b0745ad4913a21f00795738c047d0107dff4a&stat=instructions:u)
115+
116+
| (instructions:u) | mean | range | count |
117+
|:----------------------------------:|:-----:|:--------------:|:-----:|
118+
| Regressions ❌ <br /> (primary) | - | - | 0 |
119+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
120+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 5 |
121+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 3 |
122+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.3%] | 5 |
123+
124+
125+
Move RawOsError defination to sys [#115493](https://github.com/rust-lang/rust/pull/115493) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=b14b0745ad4913a21f00795738c047d0107dff4a&end=ce798a52c30528366764a5993783b4e9ccfa46ee&stat=instructions:u)
126+
127+
| (instructions:u) | mean | range | count |
128+
|:----------------------------------:|:-----:|:--------------:|:-----:|
129+
| Regressions ❌ <br /> (primary) | - | - | 0 |
130+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
131+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.6%, -0.6%] | 3 |
132+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
133+
| All ❌✅ (primary) | -0.6% | [-0.6%, -0.6%] | 3 |
134+
135+
136+
read_via_copy: don't prematurely optimize away the read [#115531](https://github.com/rust-lang/rust/pull/115531) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9c609ae158aab27f1e7df446de6f2c09414012a9&end=626a6ab93fafd01b37b1e26c96cb6eec0d39f3eb&stat=instructions:u)
137+
138+
| (instructions:u) | mean | range | count |
139+
|:----------------------------------:|:-----:|:--------------:|:-----:|
140+
| Regressions ❌ <br /> (primary) | - | - | 0 |
141+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
142+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.7%, -0.7%] | 5 |
143+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
144+
| All ❌✅ (primary) | -0.7% | [-0.7%, -0.7%] | 5 |
145+
146+
147+
#### Mixed
148+
149+
interpret: fix projecting into an unsized field of a local [#114483](https://github.com/rust-lang/rust/pull/114483) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=61efe9d2981b87ec7f2800d62f98c594de151713&end=26089ba0a2d9dab8381ccb0d7b99e704bc5cb3ed&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | - | - | 0 |
154+
| Regressions ❌ <br /> (secondary) | 2.0% | [1.9%, 2.1%] | 6 |
155+
| Improvements ✅ <br /> (primary) | -2.2% | [-2.2%, -2.2%] | 1 |
156+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.4%] | 3 |
157+
| All ❌✅ (primary) | -2.2% | [-2.2%, -2.2%] | 1 |
158+
159+
160+
Lower `Or` pattern without allocating place [#111752](https://github.com/rust-lang/rust/pull/111752) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d6b4d35d5e94f6a1577e0e645fb23afc84615a6c&end=f4555ef5e14e8f0630fc5ad4e8efaef56d4acd4b&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 1.0%] | 8 |
165+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.5%, 1.6%] | 21 |
166+
| Improvements ✅ <br /> (primary) | -1.0% | [-3.7%, -0.3%] | 10 |
167+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 3 |
168+
| All ❌✅ (primary) | -0.3% | [-3.7%, 1.0%] | 18 |
169+
170+
171+
Skip rendering metadata strings from include_str!/include_bytes! [#115286](https://github.com/rust-lang/rust/pull/115286) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9dc11a13fa848c1b09b7248c540528190dcb79c5&end=1fb6947abc68683db05f837f07531a2f7d7ed8b3&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:---------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 1 |
176+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.7%] | 6 |
177+
| Improvements ✅ <br /> (primary) | -2.9% | [-10.3%, -0.3%] | 28 |
178+
| Improvements ✅ <br /> (secondary) | -2.6% | [-3.7%, -1.7%] | 9 |
179+
| All ❌✅ (primary) | -2.8% | [-10.3%, 0.3%] | 29 |
180+
181+
182+
bootstrap: use git merge-base for LLVM CI download logic [#115409](https://github.com/rust-lang/rust/pull/115409) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ad8f601ca2ba6186de6e1b2b5f46f47e18013961&end=585bb5e68d85c1e4f32da3e2499343372626a436&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 1.0% | [0.6%, 1.5%] | 7 |
187+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
188+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
189+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 2 |
190+
| All ❌✅ (primary) | 0.8% | [-0.4%, 1.5%] | 8 |
191+
192+
193+
Add note on non-exhaustiveness when matching on str and nested non-exhaustive enums [#115270](https://github.com/rust-lang/rust/pull/115270) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2a1af898b2cb535a45cefe67acf9d023eff16b27&end=21305f4d5f32bcbc97f3b8e66dc23b03f3d948c4&stat=instructions:u)
194+
195+
| (instructions:u) | mean | range | count |
196+
|:----------------------------------:|:-----:|:--------------:|:-----:|
197+
| Regressions ❌ <br /> (primary) | 1.1% | [0.8%, 1.4%] | 6 |
198+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
199+
| Improvements ✅ <br /> (primary) | - | - | 0 |
200+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.5%, -0.5%] | 1 |
201+
| All ❌✅ (primary) | 1.1% | [0.8%, 1.4%] | 6 |
202+
203+
204+
Rollup of 5 pull requests [#115518](https://github.com/rust-lang/rust/pull/115518) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=21305f4d5f32bcbc97f3b8e66dc23b03f3d948c4&end=58e967a9cc3bd39122e8cb728e8cec6e3a4eeef2&stat=instructions:u)
205+
206+
| (instructions:u) | mean | range | count |
207+
|:----------------------------------:|:-----:|:--------------:|:-----:|
208+
| Regressions ❌ <br /> (primary) | 7.1% | [0.7%, 13.6%] | 2 |
209+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
210+
| Improvements ✅ <br /> (primary) | -1.1% | [-1.5%, -0.7%] | 7 |
211+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
212+
| All ❌✅ (primary) | 0.8% | [-1.5%, 13.6%] | 9 |
213+
214+
215+
Outline panicking code for `RefCell::borrow` and `RefCell::borrow_mut` [#115491](https://github.com/rust-lang/rust/pull/115491) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=58e967a9cc3bd39122e8cb728e8cec6e3a4eeef2&end=abfc6c44381fb033c6b3b0a6bfb804a799f39afd&stat=instructions:u)
216+
217+
| (instructions:u) | mean | range | count |
218+
|:----------------------------------:|:-----:|:---------------:|:-----:|
219+
| Regressions ❌ <br /> (primary) | 1.0% | [0.6%, 1.5%] | 8 |
220+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
221+
| Improvements ✅ <br /> (primary) | -6.3% | [-12.0%, -0.6%] | 2 |
222+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.5%] | 4 |
223+
| All ❌✅ (primary) | -0.4% | [-12.0%, 1.5%] | 10 |
224+
225+
226+
Do not require associated types with Self: Sized to uphold bounds when confirming object candidate [#115467](https://github.com/rust-lang/rust/pull/115467) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=04374cd74264b9d3b7d2d3df08ae38df8af4d020&end=9c609ae158aab27f1e7df446de6f2c09414012a9&stat=instructions:u)
227+
228+
| (instructions:u) | mean | range | count |
229+
|:----------------------------------:|:-----:|:--------------:|:-----:|
230+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.6%] | 2 |
231+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
232+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.2%, -0.8%] | 5 |
233+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
234+
| All ❌✅ (primary) | -0.6% | [-1.2%, 0.6%] | 7 |
235+
236+
237+
#### Untriaged Pull Requests
238+
239+
- [#115553 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/115553)
240+
- [#115518 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/115518)
241+
- [#115496 update Miri](https://github.com/rust-lang/rust/pull/115496)
242+
- [#115491 Outline panicking code for `RefCell::borrow` and `RefCell::borrow_mut`](https://github.com/rust-lang/rust/pull/115491)
243+
- [#115467 Do not require associated types with Self: Sized to uphold bounds when confirming object candidate](https://github.com/rust-lang/rust/pull/115467)
244+
- [#115409 bootstrap: use git merge-base for LLVM CI download logic](https://github.com/rust-lang/rust/pull/115409)
245+
- [#115270 Add note on non-exhaustiveness when matching on str and nested non-exhaustive enums](https://github.com/rust-lang/rust/pull/115270)
246+
- [#115082 Fix races conditions with `SyntaxContext` decoding](https://github.com/rust-lang/rust/pull/115082)
247+
- [#114892 Remove conditional use of `Sharded` from query caches](https://github.com/rust-lang/rust/pull/114892)
248+
- [#114483 interpret: fix projecting into an unsized field of a local](https://github.com/rust-lang/rust/pull/114483)
249+
- [#114481 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/114481)
250+
- [#114459 Do not run ConstProp on mir_for_ctfe.](https://github.com/rust-lang/rust/pull/114459)
251+
- [#114321 get auto traits for parallel rustc](https://github.com/rust-lang/rust/pull/114321)
252+
- [#114023 Warn on inductive cycle in coherence leading to impls being considered not overlapping](https://github.com/rust-lang/rust/pull/114023)
253+
- [#114004 Add `riscv64gc-unknown-hermit` target](https://github.com/rust-lang/rust/pull/114004)
254+
- [#113858 Always const-prop scalars and scalar pairs](https://github.com/rust-lang/rust/pull/113858)
255+
- [#113758 Turn copy into moves during DSE.](https://github.com/rust-lang/rust/pull/113758)
256+
- [#113485 Bump version to 1.73](https://github.com/rust-lang/rust/pull/113485)
257+
- [#113370 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/113370)
258+
- [#113320 Add some extra information to opaque type cycle errors](https://github.com/rust-lang/rust/pull/113320)
259+
- [#113306 Update debuginfo test runner to provide more useful output](https://github.com/rust-lang/rust/pull/113306)
260+
- [#113304 Upgrade to indexmap 2.0.0](https://github.com/rust-lang/rust/pull/113304)
261+
- [#113270 perform TokenStream replacement in-place when possible in expand_macro](https://github.com/rust-lang/rust/pull/113270)
262+
- [#113057 Rollup of 2 pull requests](https://github.com/rust-lang/rust/pull/113057)
263+
- [#112963 Stop bubbling out hidden types from the eval obligation queries](https://github.com/rust-lang/rust/pull/112963)
264+
- [#112882 Rewrite `UnDerefer`](https://github.com/rust-lang/rust/pull/112882)
265+
- [#112420 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/112420)
266+
- [#112157 Resurrect: rustc_target: Add alignment to indirectly-passed by-value types, correcting the alignment of byval on x86 in the process.](https://github.com/rust-lang/rust/pull/112157)
267+
- [#112083 Make `TrustedStep` require `Copy`](https://github.com/rust-lang/rust/pull/112083)
268+
- [#112016 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/112016)
269+
270+
#### Nags requiring follow up
271+
272+
TODO: Nags
273+

0 commit comments

Comments
 (0)