Skip to content

Commit f0b9632

Browse files
committed
---
yaml --- r: 12523 b: refs/heads/master c: 9604544 h: refs/heads/master i: 12521: d8a3e42 12519: f1f35f0 v: v3
1 parent 070ac10 commit f0b9632

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
11
---
2-
refs/heads/master: 75cf13ec7279ff7a56e3329ab6d6d8fc03e66e4f
2+
refs/heads/master: 9604544e234b30673ffe1bbcd24809e91bd39867
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
55
refs/heads/try: 2898dcc5d97da9427ac367542382b6239d9c0bbf

trunk/src/rt/rust_upcall.cpp

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -71,8 +71,8 @@ upcall_call_shim_on_c_stack(void *args, void *fn_ptr) {
7171
try {
7272
task->call_on_c_stack(args, fn_ptr);
7373
} catch (...) {
74-
LOG_ERR(task, task, "Native code threw an exception");
75-
abort();
74+
// Logging here is not reliable
75+
assert(false && "Native code threw an exception");
7676
}
7777

7878
task->record_stack_limit();
@@ -96,9 +96,8 @@ upcall_call_shim_on_rust_stack(void *args, void *fn_ptr) {
9696
} catch (...) {
9797
// We can't count on being able to unwind through arbitrary
9898
// code. Our best option is to just fail hard.
99-
LOG_ERR(task, task,
100-
"Rust task failed after reentering the Rust stack");
101-
abort();
99+
// Logging here is not reliable
100+
assert(false && "Rust task failed after reentering the Rust stack");
102101
}
103102

104103
// FIXME: As above

0 commit comments

Comments
 (0)