Skip to content

Commit f1af56c

Browse files
committed
Remove RISCV from LLVM_ALL_TARGETS in CMakeLists.txt
It was mistakenly added to that list in D23560 (committed in rL285712). RISCV is an experimental backend and should never have been in that list, I mistakenly interpreted LLVM_ALL_TARGETS as a list of all targets rather than targets to build by default. Unfortunately, because of this the RISCV backend has been building by default when it shouldn't be. This commet adds a description comment, which should help to avoid such mistakes in the future. See my message to llvm-dev for more information and analysis <http://lists.llvm.org/pipermail/llvm-dev/2017-August/116347.html>. Differential Revision: https://reviews.llvm.org/D36538 llvm-svn: 310796
1 parent 6e78cc6 commit f1af56c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

llvm/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -309,6 +309,7 @@ set(LLVM_CMAKE_PATH ${LLVM_MAIN_SRC_DIR}/cmake/modules)
309309
set(LLVM_EXAMPLES_BINARY_DIR ${LLVM_BINARY_DIR}/examples)
310310
set(LLVM_INCLUDE_DIR ${CMAKE_CURRENT_BINARY_DIR}/include)
311311

312+
# List of all targets to be built by default:
312313
set(LLVM_ALL_TARGETS
313314
AArch64
314315
AMDGPU
@@ -320,7 +321,6 @@ set(LLVM_ALL_TARGETS
320321
MSP430
321322
NVPTX
322323
PowerPC
323-
RISCV
324324
Sparc
325325
SystemZ
326326
X86

0 commit comments

Comments
 (0)