---

yaml
---
r: 190719
b: refs/heads/master
c: 1fd38c1
h: refs/heads/master
i:
  190717: a760fb4
  190715: d80b99b
  190711: 2cbb0d9
  190703: eb6ce5c
  190687: 59c6b60
  190655: d51b738
  190591: 5ebdcfe
  190463: f55a205
v: v3

Author: nrc

[refs]

@@ -1,5 +1,5 @@
 ---
-refs/heads/master: 2df1ceb001662845e14e210f22adfe02dd88112b
+refs/heads/master: 1fd38c181a5cadb854dd8eb22d1ba1b7f009a12f
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: c64d671671aea2e44ee7fc6eb00ee75fc30ed7b9
 refs/heads/try: 1c28ab65017d74fc13d003f7c7a73d1a48e5406f

trunk/src/librustc_resolve/build_reduced_graph.rs

@@ -372,7 +372,7 @@ impl<'a, 'b:'a, 'tcx:'b> GraphBuilder<'a, 'b, 'tcx> {
 
             ItemExternCrate(_) => {
                 // n.b. we don't need to look at the path option here, because cstore already did
-                for &crate_id in self.session.cstore.find_extern_mod_stmt_cnum(item.id).iter() {
+                if let Some(crate_id) = self.session.cstore.find_extern_mod_stmt_cnum(item.id) {
                     let def_id = DefId { krate: crate_id, node: 0 };
                     self.external_exports.insert(def_id);
                     let parent_link = ModuleParentLink(parent.downgrade(), name);

trunk/src/libsyntax/test.rs

@@ -144,9 +144,10 @@ impl<'a> fold::Folder for TestHarnessGenerator<'a> {
                     // Make all tests public so we can call them from outside
                     // the module (note that the tests are re-exported and must
                     // be made public themselves to avoid privacy errors).
-                    let mut result = (*i).clone();
-                    result.vis = ast::Public;
-                    P(result)
+                    i.map(|mut i| {
+                        i.vis = ast::Public;
+                        i
+                    })
                 }
             }
         } else {