Skip to content

Commit f3ff815

Browse files
author
Jorge Aparicio
committed
---
yaml --- r: 162257 b: refs/heads/auto c: 09f7713 h: refs/heads/master i: 162255: 347758f v: v3
1 parent 82ad672 commit f3ff815

File tree

4 files changed

+31
-39
lines changed

4 files changed

+31
-39
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@ refs/tags/release-0.3: b5f0d0f648d9a6153664837026ba1be43d3e2503
1010
refs/tags/release-0.3.1: 495bae036dfe5ec6ceafd3312b4dca48741e845b
1111
refs/tags/release-0.4: e828ea2080499553b97dfe33b3f4d472b4562ad7
1212
refs/tags/release-0.5: 7e3bcfbf21278251ee936ad53e92e9b719702d73
13-
refs/heads/auto: e6bd217ce8cf3384bdf47b63833a8b04e40e0753
13+
refs/heads/auto: 09f7713dd45c3a0b37073115575697c256238b18
1414
refs/heads/servo: af82457af293e2a842ba6b7759b70288da276167
1515
refs/tags/release-0.6: b4ebcfa1812664df5e142f0134a5faea3918544c
1616
refs/tags/0.1: b19db808c2793fe2976759b85a355c3ad8c8b336

branches/auto/src/libserialize/base64.rs

Lines changed: 16 additions & 20 deletions
Original file line numberDiff line numberDiff line change
@@ -298,7 +298,6 @@ mod tests {
298298
#[test]
299299
fn test_to_base64_line_break() {
300300
assert!(![0u8, ..1000].to_base64(Config {line_length: None, ..STANDARD})
301-
.as_slice()
302301
.contains("\r\n"));
303302
assert_eq!("foobar".as_bytes().to_base64(Config {line_length: Some(4),
304303
..STANDARD}),
@@ -319,26 +318,26 @@ mod tests {
319318

320319
#[test]
321320
fn test_from_base64_basic() {
322-
assert_eq!("".from_base64().unwrap().as_slice(), "".as_bytes());
323-
assert_eq!("Zg==".from_base64().unwrap().as_slice(), "f".as_bytes());
324-
assert_eq!("Zm8=".from_base64().unwrap().as_slice(), "fo".as_bytes());
325-
assert_eq!("Zm9v".from_base64().unwrap().as_slice(), "foo".as_bytes());
326-
assert_eq!("Zm9vYg==".from_base64().unwrap().as_slice(), "foob".as_bytes());
327-
assert_eq!("Zm9vYmE=".from_base64().unwrap().as_slice(), "fooba".as_bytes());
328-
assert_eq!("Zm9vYmFy".from_base64().unwrap().as_slice(), "foobar".as_bytes());
321+
assert_eq!("".from_base64().unwrap(), b"");
322+
assert_eq!("Zg==".from_base64().unwrap(), b"f");
323+
assert_eq!("Zm8=".from_base64().unwrap(), b"fo");
324+
assert_eq!("Zm9v".from_base64().unwrap(), b"foo");
325+
assert_eq!("Zm9vYg==".from_base64().unwrap(), b"foob");
326+
assert_eq!("Zm9vYmE=".from_base64().unwrap(), b"fooba");
327+
assert_eq!("Zm9vYmFy".from_base64().unwrap(), b"foobar");
329328
}
330329

331330
#[test]
332331
fn test_from_base64_bytes() {
333-
assert_eq!(b"Zm9vYmFy".from_base64().unwrap().as_slice(), "foobar".as_bytes());
332+
assert_eq!(b"Zm9vYmFy".from_base64().unwrap(), b"foobar");
334333
}
335334

336335
#[test]
337336
fn test_from_base64_newlines() {
338-
assert_eq!("Zm9v\r\nYmFy".from_base64().unwrap().as_slice(),
339-
"foobar".as_bytes());
340-
assert_eq!("Zm9vYg==\r\n".from_base64().unwrap().as_slice(),
341-
"foob".as_bytes());
337+
assert_eq!("Zm9v\r\nYmFy".from_base64().unwrap(),
338+
b"foobar");
339+
assert_eq!("Zm9vYg==\r\n".from_base64().unwrap(),
340+
b"foob");
342341
}
343342

344343
#[test]
@@ -364,13 +363,10 @@ mod tests {
364363
for _ in range(0u, 1000) {
365364
let times = task_rng().gen_range(1u, 100);
366365
let v = Vec::from_fn(times, |_| random::<u8>());
367-
assert_eq!(v.as_slice()
368-
.to_base64(STANDARD)
369-
.as_slice()
366+
assert_eq!(v.to_base64(STANDARD)
370367
.from_base64()
371-
.unwrap()
372-
.as_slice(),
373-
v.as_slice());
368+
.unwrap(),
369+
v);
374370
}
375371
}
376372

@@ -390,7 +386,7 @@ mod tests {
390386
ウヰノオクヤマ ケフコエテ アサキユメミシ ヱヒモセスン";
391387
let sb = s.as_bytes().to_base64(STANDARD);
392388
b.iter(|| {
393-
sb.as_slice().from_base64().unwrap();
389+
sb.from_base64().unwrap();
394390
});
395391
b.bytes = sb.len() as u64;
396392
}

branches/auto/src/libserialize/hex.rs

Lines changed: 11 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -163,10 +163,10 @@ mod tests {
163163

164164
#[test]
165165
pub fn test_from_hex_okay() {
166-
assert_eq!("666f6f626172".from_hex().unwrap().as_slice(),
167-
"foobar".as_bytes());
168-
assert_eq!("666F6F626172".from_hex().unwrap().as_slice(),
169-
"foobar".as_bytes());
166+
assert_eq!("666f6f626172".from_hex().unwrap(),
167+
b"foobar");
168+
assert_eq!("666F6F626172".from_hex().unwrap(),
169+
b"foobar");
170170
}
171171

172172
#[test]
@@ -182,8 +182,8 @@ mod tests {
182182

183183
#[test]
184184
pub fn test_from_hex_ignores_whitespace() {
185-
assert_eq!("666f 6f6\r\n26172 ".from_hex().unwrap().as_slice(),
186-
"foobar".as_bytes());
185+
assert_eq!("666f 6f6\r\n26172 ".from_hex().unwrap(),
186+
b"foobar");
187187
}
188188

189189
#[test]
@@ -197,15 +197,11 @@ mod tests {
197197
pub fn test_from_hex_all_bytes() {
198198
for i in range(0u, 256) {
199199
let ii: &[u8] = &[i as u8];
200-
assert_eq!(format!("{:02x}", i as uint).as_slice()
201-
.from_hex()
202-
.unwrap()
203-
.as_slice(),
200+
assert_eq!(format!("{:02x}", i as uint).from_hex()
201+
.unwrap(),
204202
ii);
205-
assert_eq!(format!("{:02X}", i as uint).as_slice()
206-
.from_hex()
207-
.unwrap()
208-
.as_slice(),
203+
assert_eq!(format!("{:02X}", i as uint).from_hex()
204+
.unwrap(),
209205
ii);
210206
}
211207
}
@@ -226,7 +222,7 @@ mod tests {
226222
ウヰノオクヤマ ケフコエテ アサキユメミシ ヱヒモセスン";
227223
let sb = s.as_bytes().to_hex();
228224
b.iter(|| {
229-
sb.as_slice().from_hex().unwrap();
225+
sb.from_hex().unwrap();
230226
});
231227
b.bytes = sb.len() as u64;
232228
}

branches/auto/src/libserialize/json.rs

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2039,7 +2039,7 @@ impl ::Decoder<DecoderError> for Decoder {
20392039
fn read_char(&mut self) -> DecodeResult<char> {
20402040
let s = try!(self.read_str());
20412041
{
2042-
let mut it = s.as_slice().chars();
2042+
let mut it = s.chars();
20432043
match (it.next(), it.next()) {
20442044
// exactly one character
20452045
(Some(c), None) => return Ok(c),
@@ -2860,7 +2860,7 @@ mod tests {
28602860

28612861
for &(i, o) in s.iter() {
28622862
let v: string::String = super::decode(i).unwrap();
2863-
assert_eq!(v.as_slice(), o);
2863+
assert_eq!(v, o);
28642864
}
28652865
}
28662866

@@ -3778,7 +3778,7 @@ mod tests {
37783778
fn bench_streaming_large(b: &mut Bencher) {
37793779
let src = big_json();
37803780
b.iter( || {
3781-
let mut parser = Parser::new(src.as_slice().chars());
3781+
let mut parser = Parser::new(src.chars());
37823782
loop {
37833783
match parser.next() {
37843784
None => return,

0 commit comments

Comments
 (0)