---

yaml
---
r: 5995
b: refs/heads/master
c: 1a89e58
h: refs/heads/master
i:
  5993: f95e275
  5991: 8627909
v: v3

Author: brson

[refs]

@@ -1,2 +1,2 @@
 ---
-refs/heads/master: b5ed1c46c0407c6a6c3354d1c8da8531d992064c
+refs/heads/master: 1a89e589a4c3d8c0119d81c45634dced10f1c541

trunk/src/lib/vec.rs

@@ -433,14 +433,14 @@ fn filter<T>(f: block(T) -> bool, v: [mutable? T]) -> [T] {
 /*
 Function: foldl
 
-FIXME: This looks like it's actually foldr
+Reduce a vector from left to right
 */
 fn foldl<T, U>(p: block(U, T) -> U, z: U, v: [mutable? T]) -> U {
-    let sz = len(v);
-    if sz == 0u { ret z; }
-    let first = v[0];
-    let rest = slice(v, 1u, sz);
-    ret p(foldl(p, z, rest), first);
+    let accum = z;
+    iter(v) { |elt|
+        accum = p(accum, elt);
+    }
+    ret accum;
 }
 
 /*

trunk/src/test/stdtest/vec.rs

@@ -292,6 +292,16 @@ fn test_foldl() {
     assert (sum == 15u);
 }
 
+#[test]
+fn test_foldl2() {
+    fn sub(&&a: int, &&b: int) -> int {
+        a - b
+    }
+    let v = [1, 2, 3, 4];
+    let sum = vec::foldl(sub, 0, v);
+    assert sum == -10;
+}
+
 #[test]
 fn iter_empty() {
     let i = 0;