Skip to content

Commit f900df3

Browse files
committed
---
yaml --- r: 57303 b: refs/heads/try c: bf67eb2 h: refs/heads/master i: 57301: 9416b6e 57299: 237b73d 57295: 6b99f3e v: v3
1 parent 38edf0b commit f900df3

File tree

2 files changed

+25
-1
lines changed

2 files changed

+25
-1
lines changed

[refs]

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
refs/heads/master: c081ffbd1e845687202a975ea2e698b623e5722f
33
refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
44
refs/heads/snap-stage3: 79a2b2eafc3c766cecec8a5f76317693bae9ed17
5-
refs/heads/try: d129362b56a33cada2b4053cd31807bee627a186
5+
refs/heads/try: bf67eb2362b7d0f37012f2d6dac604c3bbacd2c6
66
refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105
77
refs/heads/ndm: f3868061cd7988080c30d6d5bf352a5a5fe2460b
88
refs/heads/try2: 147ecfdd8221e4a4d4e090486829a06da1e0ca3c

branches/try/src/test/run-pass/issue-2185.rs

Lines changed: 24 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,31 @@
88
// option. This file may not be copied, modified, or distributed
99
// except according to those terms.
1010

11+
// does the second one subsume the first?
12+
// xfail-test
1113
// xfail-fast
14+
15+
// notes on this test case:
16+
// On Thu, Apr 18, 2013 at 6:30 PM, John Clements <[email protected]> wrote:
17+
// the "issue-2185.rs" test was xfailed with a ref to #2263. Issue #2263 is now fixed, so I tried it again, and after adding some &self parameters, I got this error:
18+
//
19+
// Running /usr/local/bin/rustc:
20+
// issue-2185.rs:24:0: 26:1 error: conflicting implementations for a trait
21+
// issue-2185.rs:24 impl iterable<uint> for @fn(&fn(uint)) {
22+
// issue-2185.rs:25 fn iter(&self, blk: &fn(v: uint)) { self( |i| blk(i) ) }
23+
// issue-2185.rs:26 }
24+
// issue-2185.rs:20:0: 22:1 note: note conflicting implementation here
25+
// issue-2185.rs:20 impl<A> iterable<A> for @fn(&fn(A)) {
26+
// issue-2185.rs:21 fn iter(&self, blk: &fn(A)) { self(blk); }
27+
// issue-2185.rs:22 }
28+
//
29+
// … so it looks like it's just not possible to implement both the generic iterable<uint> and iterable<A> for the type iterable<uint>. Is it okay if I just remove this test?
30+
//
31+
// but Niko responded:
32+
// think it's fine to remove this test, just because it's old and cruft and not hard to reproduce. *However* it should eventually be possible to implement the same interface for the same type multiple times with different type parameters, it's just that our current trait implementation has accidental limitations.
33+
34+
// so I'm leaving it in.
35+
1236
// This test had to do with an outdated version of the iterable trait.
1337
// However, the condition it was testing seemed complex enough to
1438
// warrant still having a test, so I inlined the old definitions.

0 commit comments

Comments
 (0)