---

yaml
---
r: 15738
b: refs/heads/try
c: f029e1f
h: refs/heads/master
v: v3

Author: catamorphism

[refs]

@@ -2,5 +2,5 @@
 refs/heads/master: 61b1875c16de39c166b0f4d54bba19f9c6777d1a
 refs/heads/snap-stage1: e33de59e47c5076a89eadeb38f4934f58a3618a6
 refs/heads/snap-stage3: 4a81779abd786ff22d71434c6d9a5917ea4cdfff
-refs/heads/try: cfa09d35a355dee59008306f98330ff0472eb09d
+refs/heads/try: f029e1f486d965c0a20410644e9faa9b294e03c9
 refs/tags/release-0.1: 1f5c5126e96c79d22cb7862f75304136e204f105

branches/try/src/libstd/bitv.rs

@@ -20,6 +20,7 @@ export eq_vec;
 //        union, intersection, and difference. At that point, we could write
 //        an optimizing version of this module that produces a different obj
 //        for the case where nbits <= 32.
+// (Issue #2341)
 
 #[doc = "The bitvector type"]
 type bitv = @{storage: [mut uint], nbits: uint};
@@ -104,24 +105,18 @@ pure fn get(v: bitv, i: uint) -> bool {
 }
 
 // FIXME: This doesn't account for the actual size of the vectors,
-// so it could end up comparing garbage bits
+// so it could end up comparing garbage bits (#2342)
 #[doc = "
 Compares two bitvectors
 
 Both bitvectors must be the same length. Returns `true` if both bitvectors
 contain identical elements.
 "]
 fn equal(v0: bitv, v1: bitv) -> bool {
-    // FIXME: when we can break or return from inside an iterator loop,
-    //        we can eliminate this painful while-loop
-
     let len = vec::len(v1.storage);
-    let mut i = 0u;
-    while i < len {
+    for uint::iterate(0u, len) {|i|
         if v0.storage[i] != v1.storage[i] { ret false; }
-        i = i + 1u;
     }
-    ret true;
 }
 
 #[doc = "Set all bits to 0"]