@@ -9,20 +9,24 @@ design.
9
9
10
10
## Rust compiler meeting
11
11
12
- The compiler team has a weekly meeting where we do triage and try to generally
13
- stay on top of new bugs, regressions, and other things. This general plan for
14
- this meeting can be found in [ the rust-compiler-meeting etherpad] [ etherpad ] . It works
15
- roughly as follows:
16
-
17
- - ** Review P-high bugs:** P-high bugs are those that are sufficiently important for us
18
- to actively track progress. P-high bugs should ideally always have an assignee.
12
+ The compiler team has a weekly meeting where we do triage and try to
13
+ generally stay on top of new bugs, regressions, and other things. This
14
+ general plan for this meeting can be found in
15
+ [ the rust-compiler-meeting etherpad] [ etherpad ] . It works roughly as
16
+ follows:
17
+
18
+ - ** Review P-high bugs:** P-high bugs are those that are sufficiently
19
+ important for us to actively track progress. P-high bugs should
20
+ ideally always have an assignee.
19
21
- ** Look over new regressions:** we then look for new cases where the
20
22
compiler broke previously working code in the wild. Regressions are
21
23
almost always marked as P-high; the major exception would be bug
22
24
fixes (though even there we often
23
25
[ aim to give warnings first] [ procedure ] ).
24
- - ** Check I-nominated issues:** These are issues where feedback from the team is desired.
25
- - ** Check for beta nominations:** These are nominations of things to backport to beta.
26
+ - ** Check I-nominated issues:** These are issues where feedback from
27
+ the team is desired.
28
+ - ** Check for beta nominations:** These are nominations of things to
29
+ backport to beta.
26
30
27
31
The meeting currently takes place on Thursdays at 10am Boston time
28
32
(UTC-4 typically, but daylight savings time sometimes makes things
@@ -61,14 +65,16 @@ merge a PR
61
65
62
66
The guidelines for reviewers are as follows:
63
67
64
- - You are always welcome to review any PR, regardless of who it is assigned to.
65
- However, do not r+ PRs unless:
68
+ - You are always welcome to review any PR, regardless of who it is
69
+ assigned to. However, do not r+ PRs unless:
66
70
- You are confident in that part of the code.
67
71
- You are confident that nobody else wants to review it first.
68
- - For example, sometimes people will express a desire to review a PR before it lands,
69
- perhaps because it touches a particularly sensitive part of the code.
70
- - Always be polite when reviewing: you are a representative of the Rust project,
71
- so it is expected that you will go above and beyond when it comes to the [ Code of Conduct] .
72
+ - For example, sometimes people will express a desire to review a
73
+ PR before it lands, perhaps because it touches a particularly
74
+ sensitive part of the code.
75
+ - Always be polite when reviewing: you are a representative of the
76
+ Rust project, so it is expected that you will go above and beyond
77
+ when it comes to the [ Code of Conduct] .
72
78
73
79
[ Code of Conduct ] : https://www.rust-lang.org/en-US/conduct.html
74
80
0 commit comments