Skip to content

Commit 01d9a53

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent b69afe7 commit 01d9a53

File tree

1 file changed

+185
-0
lines changed

1 file changed

+185
-0
lines changed

‎triage/2023-11-28.md

Lines changed: 185 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,185 @@
1+
# 2023-11-28 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [4f3da903a43f22ea33d2ca4435a24b42fc1f842a..df0295f07175acc7325ce3ca4152eb05752af1f2](https://perf.rust-lang.org/?start=4f3da903a43f22ea33d2ca4435a24b42fc1f842a&end=df0295f07175acc7325ce3ca4152eb05752af1f2&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.6% | [0.1%, 1.5%] | 15 |
13+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.2%, 2.4%] | 16 |
14+
| Improvements ✅ <br /> (primary) | -0.7% | [-2.1%, -0.3%] | 66 |
15+
| Improvements ✅ <br /> (secondary) | -1.7% | [-8.1%, -0.2%] | 43 |
16+
| All ❌✅ (primary) | -0.5% | [-2.1%, 1.5%] | 81 |
17+
18+
19+
1 Regressions, 5 Improvements, 5 Mixed; ??? of them in rollups
20+
84 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 4 pull requests [#118319](https://github.com/rust-lang/rust/pull/118319) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3dbb4da04267b19bc8c403c0bb2b41c5b8010a61&end=3bb0171999a65b0650d9405a7b2e8e7dc3476dec&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.4% | [0.1%, 0.8%] | 23 |
29+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 1.0%] | 11 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.4% | [0.1%, 0.8%] | 23 |
33+
34+
35+
#### Improvements
36+
37+
Remove `PredicateKind::ClosureKind` [#118120](https://github.com/rust-lang/rust/pull/118120) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=06d1afe5189bc0830b9b5654fd0ba89e9829f4cd&end=1e9dda77b5b8e690c7e21871bbd2dcf182e1a841&stat=instructions:u)
38+
39+
| (instructions:u) | mean | range | count |
40+
|:----------------------------------:|:-----:|:--------------:|:-----:|
41+
| Regressions ❌ <br /> (primary) | - | - | 0 |
42+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
43+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 4 |
44+
| Improvements ✅ <br /> (secondary) | -3.8% | [-8.1%, -0.5%] | 14 |
45+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 4 |
46+
47+
48+
Cache flags for `ty::Const` [#118189](https://github.com/rust-lang/rust/pull/118189) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eab8c7d5fd335d673bb96bb4aef86c74006cef4b&end=41fe75ec6b824d51e5365098c4af9de45e5a2723&stat=instructions:u)
49+
50+
| (instructions:u) | mean | range | count |
51+
|:----------------------------------:|:-----:|:--------------:|:-----:|
52+
| Regressions ❌ <br /> (primary) | - | - | 0 |
53+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
54+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 10 |
55+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.2%] | 3 |
56+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.2%] | 10 |
57+
58+
59+
Indicate that multiplication in Layout::array cannot overflow [#118228](https://github.com/rust-lang/rust/pull/118228) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f74f700952f105536446e415b8df8061bddfb25e&end=b06258cde4b0dd131cdbf289349ebf51b3b6388a&stat=instructions:u)
60+
61+
| (instructions:u) | mean | range | count |
62+
|:----------------------------------:|:-----:|:--------------:|:-----:|
63+
| Regressions ❌ <br /> (primary) | - | - | 0 |
64+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
65+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.3%] | 3 |
66+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
67+
| All ❌✅ (primary) | -0.4% | [-0.5%, -0.3%] | 3 |
68+
69+
70+
`AmbiguityCause` should not eagerly format strings [#118267](https://github.com/rust-lang/rust/pull/118267) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3acb261e214cd13ae54346af30eae5807501ec37&end=0b8a61b235662d397721d1b88ddefdfc147ba39a&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.8%, -0.2%] | 5 |
77+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
78+
| All ❌✅ (primary) | -0.4% | [-0.8%, -0.2%] | 5 |
79+
80+
81+
resolve: Feed the `def_kind` query immediately on `DefId` creation [#118188](https://github.com/rust-lang/rust/pull/118188) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=df0295f07175acc7325ce3ca4152eb05752af1f2&end=5facb422f8a5a61df515572fe79b02433639d565&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.5%, -0.2%] | 58 |
88+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.0%, -0.1%] | 34 |
89+
| All ❌✅ (primary) | -0.3% | [-0.5%, -0.2%] | 58 |
90+
91+
92+
#### Mixed
93+
94+
Refactor `binary_search_by` to use conditional moves [#117722](https://github.com/rust-lang/rust/pull/117722) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=41fe75ec6b824d51e5365098c4af9de45e5a2723&end=8abf920985368264ed4d46e62e1730232e161292&stat=instructions:u)
95+
96+
| (instructions:u) | mean | range | count |
97+
|:----------------------------------:|:-----:|:--------------:|:-----:|
98+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 1 |
99+
| Regressions ❌ <br /> (secondary) | 1.3% | [1.3%, 1.4%] | 2 |
100+
| Improvements ✅ <br /> (primary) | -1.4% | [-1.9%, -0.2%] | 5 |
101+
| Improvements ✅ <br /> (secondary) | -1.8% | [-2.6%, -1.3%] | 8 |
102+
| All ❌✅ (primary) | -1.1% | [-1.9%, 0.4%] | 6 |
103+
104+
105+
Rewrite exhaustiveness in one pass [#117611](https://github.com/rust-lang/rust/pull/117611) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f5dc2653fdd8b5d177b2ccbd84057954340a89fc&end=ee80c8d0a8bc63b69f68216c5d37f9ab837eedd0&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | 1.1% | [1.0%, 1.1%] | 2 |
110+
| Regressions ❌ <br /> (secondary) | 1.6% | [0.3%, 2.4%] | 9 |
111+
| Improvements ✅ <br /> (primary) | -0.9% | [-2.0%, -0.2%] | 11 |
112+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.2%] | 1 |
113+
| All ❌✅ (primary) | -0.6% | [-2.0%, 1.1%] | 13 |
114+
115+
116+
rustc: Make `def_kind` mandatory for all `DefId`s [#118250](https://github.com/rust-lang/rust/pull/118250) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=33f6af805257c6d462ad45c5de32da3fb38bfaf7&end=5c97719393b093997a03d7bb5d8a01d712c66c0e&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | - | - | 0 |
121+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.5%] | 2 |
122+
| Improvements ✅ <br /> (primary) | -0.1% | [-0.1%, -0.1%] | 5 |
123+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.5%, -0.2%] | 9 |
124+
| All ❌✅ (primary) | -0.1% | [-0.1%, -0.1%] | 5 |
125+
126+
127+
Add `debug_assert_nounwind` and convert `assert_unsafe_precondition` [#110303](https://github.com/rust-lang/rust/pull/110303) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5c97719393b093997a03d7bb5d8a01d712c66c0e&end=9529a5d2655f6974c2ee16e91c5db548a3daea03&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | 0.5% | [0.4%, 0.6%] | 4 |
132+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 2 |
133+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.4%, -0.4%] | 1 |
134+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.6%, -0.6%] | 2 |
135+
| All ❌✅ (primary) | 0.3% | [-0.4%, 0.6%] | 5 |
136+
137+
138+
Rollup of 7 pull requests [#118405](https://github.com/rust-lang/rust/pull/118405) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e06c94d6cb61ef2fa28370fb69a8d2e11b6678c4&end=46a24ed2f4b4bdfccca36fb20b1574a6164893d8&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | 0.5% | [0.4%, 0.6%] | 3 |
143+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
144+
| Improvements ✅ <br /> (primary) | - | - | 0 |
145+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.3%, -0.2%] | 4 |
146+
| All ❌✅ (primary) | 0.5% | [0.4%, 0.6%] | 3 |
147+
148+
149+
#### Untriaged Pull Requests
150+
151+
- [#118405 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/118405)
152+
- [#118319 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/118319)
153+
- [#117769 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/117769)
154+
- [#117736 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/117736)
155+
- [#117722 Refactor `binary_search_by` to use conditional moves](https://github.com/rust-lang/rust/pull/117722)
156+
- [#117180 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/117180)
157+
- [#116940 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/116940)
158+
- [#116889 Eat close paren if capture_cfg to avoid unbalanced parens](https://github.com/rust-lang/rust/pull/116889)
159+
- [#116492 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/116492)
160+
- [#116391 exhaustiveness: Rework constructor splitting](https://github.com/rust-lang/rust/pull/116391)
161+
- [#116183 Always preserve DebugInfo in DeadStoreElimination.](https://github.com/rust-lang/rust/pull/116183)
162+
- [#116033 report `unused_import` for empty reexports even it is pub](https://github.com/rust-lang/rust/pull/116033)
163+
- [#115762 Explain revealing of opaque types in layout_of ParamEnv](https://github.com/rust-lang/rust/pull/115762)
164+
- [#115751 some inspect improvements](https://github.com/rust-lang/rust/pull/115751)
165+
- [#115740 Cache reachable_set on disk](https://github.com/rust-lang/rust/pull/115740)
166+
- [#115252 Represent MIR composite debuginfo as projections instead of aggregates](https://github.com/rust-lang/rust/pull/115252)
167+
- [#115082 Fix races conditions with `SyntaxContext` decoding](https://github.com/rust-lang/rust/pull/115082)
168+
- [#115025 Make subtyping explicit in MIR](https://github.com/rust-lang/rust/pull/115025)
169+
- [#114892 Remove conditional use of `Sharded` from query caches](https://github.com/rust-lang/rust/pull/114892)
170+
- [#114481 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/114481)
171+
- [#114459 Do not run ConstProp on mir_for_ctfe.](https://github.com/rust-lang/rust/pull/114459)
172+
- [#114321 get auto traits for parallel rustc](https://github.com/rust-lang/rust/pull/114321)
173+
- [#114023 Warn on inductive cycle in coherence leading to impls being considered not overlapping](https://github.com/rust-lang/rust/pull/114023)
174+
- [#114004 Add `riscv64gc-unknown-hermit` target](https://github.com/rust-lang/rust/pull/114004)
175+
- [#113858 Always const-prop scalars and scalar pairs](https://github.com/rust-lang/rust/pull/113858)
176+
- [#113758 Turn copy into moves during DSE.](https://github.com/rust-lang/rust/pull/113758)
177+
- [#113485 Bump version to 1.73](https://github.com/rust-lang/rust/pull/113485)
178+
- [#113370 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/113370)
179+
- [#113320 Add some extra information to opaque type cycle errors](https://github.com/rust-lang/rust/pull/113320)
180+
- [#113306 Update debuginfo test runner to provide more useful output](https://github.com/rust-lang/rust/pull/113306)
181+
182+
#### Nags requiring follow up
183+
184+
TODO: Nags
185+

0 commit comments

Comments
 (0)