Skip to content

Commit 27e726b

Browse files
committed
Use - instead of N/A for "no results".
Because it's easier to ignore in favour of the interesting results.
1 parent f3acd04 commit 27e726b

File tree

1 file changed

+23
-23
lines changed

1 file changed

+23
-23
lines changed

site/src/comparison.rs

Lines changed: 23 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -491,7 +491,7 @@ pub fn write_summary_table(
491491
let value = if count > 0 { calculate() } else { None };
492492
value
493493
.map(|value| format!("{value:.1}%"))
494-
.unwrap_or_else(|| "N/A".to_string())
494+
.unwrap_or_else(|| "-".to_string())
495495
}
496496

497497
// (label, mean, max, count)
@@ -521,14 +521,14 @@ pub fn write_summary_table(
521521
Some(secondary.arithmetic_mean_of_improvements())
522522
}),
523523
if primary.is_empty() {
524-
"N/A".to_string()
524+
"-".to_string()
525525
} else {
526526
format!("{:.1}%", primary.arithmetic_mean_of_changes())
527527
},
528528
]);
529529

530530
let largest_change = if primary.is_empty() {
531-
"N/A".to_string()
531+
"-".to_string()
532532
} else {
533533
let largest_improvement = primary
534534
.largest_improvement()
@@ -1341,9 +1341,9 @@ mod tests {
13411341
| | mean[^1] | max | count[^2] |
13421342
|:----------:|:--------:|:---:|:---------:|
13431343
| Regressions ❌ <br /> (primary) | 146.7% | 200.0% | 3 |
1344-
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1345-
| Improvements ✅ <br /> (primary) | N/A | N/A | 0 |
1346-
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1344+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
1345+
| Improvements ✅ <br /> (primary) | - | - | 0 |
1346+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
13471347
| All ❌✅ (primary) | 146.7% | 200.0% | 3 |
13481348
"#
13491349
.trim_start(),
@@ -1361,10 +1361,10 @@ mod tests {
13611361
r#"
13621362
| | mean[^1] | max | count[^2] |
13631363
|:----------:|:--------:|:---:|:---------:|
1364-
| Regressions ❌ <br /> (primary) | N/A | N/A | 0 |
1365-
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1364+
| Regressions ❌ <br /> (primary) | - | - | 0 |
1365+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
13661366
| Improvements ✅ <br /> (primary) | -71.7% | -80.0% | 3 |
1367-
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1367+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
13681368
| All ❌✅ (primary) | -71.7% | -80.0% | 3 |
13691369
"#
13701370
.trim_start(),
@@ -1382,11 +1382,11 @@ mod tests {
13821382
r#"
13831383
| | mean[^1] | max | count[^2] |
13841384
|:----------:|:--------:|:---:|:---------:|
1385-
| Regressions ❌ <br /> (primary) | N/A | N/A | 0 |
1386-
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1387-
| Improvements ✅ <br /> (primary) | N/A | N/A | 0 |
1385+
| Regressions ❌ <br /> (primary) | - | - | 0 |
1386+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
1387+
| Improvements ✅ <br /> (primary) | - | - | 0 |
13881388
| Improvements ✅ <br /> (secondary) | -71.7% | -80.0% | 3 |
1389-
| All ❌✅ (primary) | N/A | N/A | 0 |
1389+
| All ❌✅ (primary) | - | - | 0 |
13901390
"#
13911391
.trim_start(),
13921392
);
@@ -1403,11 +1403,11 @@ mod tests {
14031403
r#"
14041404
| | mean[^1] | max | count[^2] |
14051405
|:----------:|:--------:|:---:|:---------:|
1406-
| Regressions ❌ <br /> (primary) | N/A | N/A | 0 |
1406+
| Regressions ❌ <br /> (primary) | - | - | 0 |
14071407
| Regressions ❌ <br /> (secondary) | 146.7% | 200.0% | 3 |
1408-
| Improvements ✅ <br /> (primary) | N/A | N/A | 0 |
1409-
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1410-
| All ❌✅ (primary) | N/A | N/A | 0 |
1408+
| Improvements ✅ <br /> (primary) | - | - | 0 |
1409+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
1410+
| All ❌✅ (primary) | - | - | 0 |
14111411
"#
14121412
.trim_start(),
14131413
);
@@ -1426,9 +1426,9 @@ mod tests {
14261426
| | mean[^1] | max | count[^2] |
14271427
|:----------:|:--------:|:---:|:---------:|
14281428
| Regressions ❌ <br /> (primary) | 150.0% | 200.0% | 2 |
1429-
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1429+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
14301430
| Improvements ✅ <br /> (primary) | -62.5% | -75.0% | 2 |
1431-
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1431+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
14321432
| All ❌✅ (primary) | 43.8% | 200.0% | 4 |
14331433
"#
14341434
.trim_start(),
@@ -1470,9 +1470,9 @@ mod tests {
14701470
| | mean[^1] | max | count[^2] |
14711471
|:----------:|:--------:|:---:|:---------:|
14721472
| Regressions ❌ <br /> (primary) | 20.0% | 20.0% | 1 |
1473-
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1473+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
14741474
| Improvements ✅ <br /> (primary) | -50.0% | -50.0% | 1 |
1475-
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1475+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
14761476
| All ❌✅ (primary) | -15.0% | -50.0% | 2 |
14771477
"#
14781478
.trim_start(),
@@ -1490,9 +1490,9 @@ mod tests {
14901490
| | mean[^1] | max | count[^2] |
14911491
|:----------:|:--------:|:---:|:---------:|
14921492
| Regressions ❌ <br /> (primary) | 100.0% | 100.0% | 1 |
1493-
| Regressions ❌ <br /> (secondary) | N/A | N/A | 0 |
1493+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
14941494
| Improvements ✅ <br /> (primary) | -16.7% | -16.7% | 1 |
1495-
| Improvements ✅ <br /> (secondary) | N/A | N/A | 0 |
1495+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
14961496
| All ❌✅ (primary) | 41.7% | 100.0% | 2 |
14971497
"#
14981498
.trim_start(),

0 commit comments

Comments
 (0)