Skip to content

Commit 2d2a206

Browse files
committed
Remove unneeded transaction when calling get_pstats
The Postgres implementation performs a single query, therefore it shouldn't require a transaction
1 parent f045fac commit 2d2a206

File tree

2 files changed

+5
-6
lines changed

2 files changed

+5
-6
lines changed

database/src/pool/sqlite.rs

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -859,8 +859,9 @@ impl Connection for SqliteConnection {
859859
series: &[u32],
860860
artifact_row_ids: &[Option<ArtifactIdNumber>],
861861
) -> Vec<Vec<Option<f64>>> {
862-
let conn = self.raw_ref();
863-
let mut query = conn
862+
let mut conn = self.raw_ref();
863+
let tx = conn.transaction().unwrap();
864+
let mut query = tx
864865
.prepare_cached("select min(value) from pstat where series = ? and aid = ?;")
865866
.unwrap();
866867
series

site/src/selector.rs

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -374,12 +374,10 @@ impl StatisticSeries {
374374
.map(|aid| aid.lookup(&index))
375375
.collect::<Vec<_>>();
376376

377-
let mut conn = ctxt.conn().await;
378-
let mut tx = conn.transaction().await;
377+
let conn = ctxt.conn().await;
379378

380379
let start = std::time::Instant::now();
381-
let res = tx
382-
.conn()
380+
let res = conn
383381
.get_pstats(&sids, &aids)
384382
.await
385383
.into_iter()

0 commit comments

Comments
 (0)