Skip to content

Commit 32bc42a

Browse files
committed
Change summary header message when benchmark(s) stop compiling
1 parent a6e6762 commit 32bc42a

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

site/src/github/comparison_summary.rs

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,7 +176,8 @@ async fn summarize_run(
176176
let inst_comparison =
177177
calculate_metric_comparison(ctxt, &commit, Metric::InstructionsUser).await?;
178178

179-
let errors = if !inst_comparison.newly_failed_benchmarks.is_empty() {
179+
let has_broken_benchmarks = !inst_comparison.newly_failed_benchmarks.is_empty();
180+
let errors = if has_broken_benchmarks {
180181
let benchmarks = inst_comparison
181182
.newly_failed_benchmarks
182183
.keys()
@@ -209,7 +210,9 @@ async fn summarize_run(
209210
&mut message,
210211
"### Overall result: {}{}\n",
211212
overall_result,
212-
if is_regression {
213+
if has_broken_benchmarks {
214+
" - BENCHMARK(S) FAILED"
215+
} else if is_regression {
213216
" - ACTION NEEDED"
214217
} else {
215218
" - no action needed"

0 commit comments

Comments
 (0)