Skip to content

Commit 42c1f98

Browse files
authored
Merge pull request #1218 from nnethercote/demote-futures
Demote `futures` to only run in the "stable" set.
2 parents 1f1e6c1 + edf4984 commit 42c1f98

File tree

3 files changed

+10
-7
lines changed

3 files changed

+10
-7
lines changed

ci/check-profiling.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ test -f results/eprintln-Test-helloworld-Check-Full
129129
test ! -s results/eprintln-Test-helloworld-Check-Full
130130

131131
# llvm-lines. `Debug` not `Check` because it doesn't support `Check` profiles.
132-
# Including both `helloworld` and `futures` benchmarks, as they exercise the
132+
# Including both `helloworld` and `regex` benchmarks, as they exercise the
133133
# zero dependency and the greater than zero dependency cases, respectively, the
134134
# latter of which has broken before.
135135
RUST_BACKTRACE=1 RUST_LOG=raw_cargo_messages=trace,collector=debug,rust_sysroot=debug \
@@ -138,12 +138,12 @@ RUST_BACKTRACE=1 RUST_LOG=raw_cargo_messages=trace,collector=debug,rust_sysroot=
138138
--id Test \
139139
--profiles Debug \
140140
--cargo $bindir/cargo \
141-
--include helloworld,futures \
141+
--include helloworld,regex \
142142
--scenarios Full
143143
test -f results/ll-Test-helloworld-Debug-Full
144144
grep -q "Lines.*Copies.*Function name" results/ll-Test-helloworld-Debug-Full
145-
test -f results/ll-Test-futures-Debug-Full
146-
grep -q "Lines.*Copies.*Function name" results/ll-Test-futures-Debug-Full
145+
test -f results/ll-Test-regex-Debug-Full
146+
grep -q "Lines.*Copies.*Function name" results/ll-Test-regex-Debug-Full
147147

148148

149149
#----------------------------------------------------------------------------

collector/benchmarks/README.md

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,6 @@ They mostly consist of real-world crates.
2525
ensure a lot of invariants. Stresses anything related to resolving
2626
trait bounds, by having a lot of trait impls for a large number of different
2727
types.
28-
- **futures**: A futures implementation. Used by many Rust programs.
2928
- **helloworld**: A trivial program. Gives a lower bound on compile time.
3029
- **html5ever**: An HTML parser. Stresses macro parsing code significantly.
3130
- **hyper-2**: A fairly large crate. Utilizes async/await, and used by
@@ -124,7 +123,11 @@ Rust code being written today.
124123

125124
- **encoding**: An old crate providing character encoding support. Contains
126125
some large tables.
127-
- **futures**: See above.
126+
- **futures**: v0.1.0 of the popular `futures` crate, which was used by many
127+
Rust programs. Newer versions of this crate (e.g. v0.3.21 from February 2021)
128+
contain very little code, instead relying on sub-crates. This makes them less
129+
interesting as benchmarks, because we only measure final crate compilation.
130+
This is why there is no futures crate among the primary benchmarks.
128131
- **html5ever**: See above.
129132
- **inflate**: An old implementation of the DEFLATE algorithm. Contains
130133
a very large function containing many locals and basic blocks, similar to
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"category": "primary-and-stable"
2+
"category": "stable"
33
}

0 commit comments

Comments
 (0)