Skip to content

Commit 44fe248

Browse files
pnkfelixpnkfelix
committed
manually work around rustc-perf issue and add on the other PRs that were not included in yesterdays report.
1 parent 4c714ca commit 44fe248

File tree

1 file changed

+104
-5
lines changed

1 file changed

+104
-5
lines changed

‎triage/2024-09-23.md

Lines changed: 104 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -1,14 +1,24 @@
11
# 2024-09-23 Triage Log
22

3-
Not much happened this week. Most changes of note were readily
3+
Not too much happened this week. Most regressions of note were readily
44
justified as removing sources of unpredictable/inconsistent behavior
5-
from code-generation.
5+
from code-generation. There was one notable improvement, from PR
6+
#130561: avoiding redoing a redundant normalization of the param-env
7+
ended up improving compile times for 93 primary benchmarks by -1.0% on
8+
average.
69

710
Triage done by **@pnkfelix**.
811
Revision range: [170d6cb8..749f80ab](https://perf.rust-lang.org/?start=170d6cb845c8c3f0dcec5cdd4210df9ecf990244&end=749f80ab051aa0b3724b464130440b0e70a975ac&absolute=false&stat=instructions%3Au)
12+
Revision range: [506f22b4..4cadeda9](https://perf.rust-lang.org/?start=506f22b4663f3e756e1e6a4f66c6309fdc00819c&end=4cadeda932d5c261a9a0b1bbd25c4486e4e0a4c6&absolute=false&stat=instructions%3Au)
913

1014
**Summary**:
1115

16+
Note: Due to issues in how the perf website generates its output and
17+
fails to deal with certain git histories, we have two different base
18+
summaries.
19+
20+
Base Revision range: [170d6cb8..749f80ab](https://perf.rust-lang.org/?start=170d6cb845c8c3f0dcec5cdd4210df9ecf990244&end=749f80ab051aa0b3724b464130440b0e70a975ac&absolute=false&stat=instructions%3Au)
21+
1222
| (instructions:u) | mean | range | count |
1323
|:----------------------------------:|:-----:|:--------------:|:-----:|
1424
| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 2.5%] | 8 |
@@ -17,9 +27,20 @@ Revision range: [170d6cb8..749f80ab](https://perf.rust-lang.org/?start=170d6cb84
1727
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.7%, -0.2%] | 23 |
1828
| All ❌✅ (primary) | 0.2% | [-0.4%, 2.5%] | 17 |
1929

30+
Base Revision range: [506f22b4..4cadeda9](https://perf.rust-lang.org/?start=506f22b4663f3e756e1e6a4f66c6309fdc00819c&end=4cadeda932d5c261a9a0b1bbd25c4486e4e0a4c6&absolute=false&stat=instructions%3Au)
31+
32+
| (instructions:u) | mean | range | count |
33+
|:----------------------------------:|:-----:|:--------------:|:-----:|
34+
| Regressions ❌ <br /> (primary) | 2.7% | [0.1%, 6.7%] | 16 |
35+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 6 |
36+
| Improvements ✅ <br /> (primary) | -1.1% | [-5.1%, -0.2%] | 80 |
37+
| Improvements ✅ <br /> (secondary) | -2.4% | [-5.2%, -0.2%] | 54 |
38+
| All ❌✅ (primary) | -0.5% | [-5.1%, 6.7%] | 96 |
39+
40+
Total:
2041

21-
1 Regression, 0 Improvements, 4 Mixed; 1 of them in rollups
22-
28 artifact comparisons made in total
42+
2 Regression, 2 Improvements, 7 Mixed; 4 of them in rollups
43+
62 artifact comparisons made in total
2344

2445
#### Regressions
2546

@@ -41,9 +62,44 @@ Remove semi-nondeterminism of `DefPathHash` ordering from inliner [#130455](http
4162
[attempted to mark](https://github.com/rust-lang/rust/pull/130455#issuecomment-2354849189) this as triaged (due to it being
4263
acceptable overhead for the benefit of better de
4364

65+
Rollup of 6 pull requests [#130649](https://github.com/rust-lang/rust/pull/130649) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c0838c8ebec23fb87855bb6de3a287981cb1df98&end=74fd001cdae0321144a20133f2216ea8a97da476&stat=instructions:u)
66+
67+
| (instructions:u) | mean | range | count |
68+
|:----------------------------------:|:----:|:------------:|:-----:|
69+
| Regressions ❌ <br /> (primary) | - | - | 0 |
70+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.4%] | 13 |
71+
| Improvements ✅ <br /> (primary) | - | - | 0 |
72+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
73+
| All ❌✅ (primary) | - | - | 0 |
74+
75+
* This was flagged solely because of the *number* of secondary benchmarks that were affected.
76+
* Marking as triaged.
77+
4478
#### Improvements
4579

46-
(nothing of note)
80+
[perf] skip normalizing param env if it is already normalized [#130561](https://github.com/rust-lang/rust/pull/130561) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=506f22b4663f3e756e1e6a4f66c6309fdc00819c&end=5793a9e90289382e447f5bc411cab2bc01c5836f&stat=instructions:u)
81+
82+
| (instructions:u) | mean | range | count |
83+
|:----------------------------------:|:-----:|:--------------:|:-----:|
84+
| Regressions ❌ <br /> (primary) | - | - | 0 |
85+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
86+
| Improvements ✅ <br /> (primary) | -1.0% | [-5.5%, -0.1%] | 93 |
87+
| Improvements ✅ <br /> (secondary) | -2.7% | [-6.5%, -0.2%] | 59 |
88+
| All ❌✅ (primary) | -1.0% | [-5.5%, -0.1%] | 93 |
89+
90+
* This is awesome. :)
91+
92+
Rollup of 7 pull requests [#130768](https://github.com/rust-lang/rust/pull/130768) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f5cd2c5888011d4d80311e5b771c6da507d860dd&end=4cadeda932d5c261a9a0b1bbd25c4486e4e0a4c6&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
98+
| Improvements ✅ <br /> (primary) | - | - | 0 |
99+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.7%, -0.1%] | 14 |
100+
| All ❌✅ (primary) | - | - | 0 |
101+
102+
* This was flagged because of the *number* of secondary benchmarks that were affected.
47103

48104
#### Mixed
49105

@@ -102,3 +158,46 @@ Get rid of niche selection's dependence on fields's order [#130508](https://gith
102158

103159
* primary regression to typenum doc-full (-0.23%)
104160
* marking as triaged; this is a very small (and probably semi-random) cost for a clear win IMO in terms of overall consistency of behavior.
161+
162+
Rollup of 7 pull requests [#130631](https://github.com/rust-lang/rust/pull/130631) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5ba6db1b648d93fbbab4ae0466e40db682fa45fc&end=da889684c80508036ff036db8c159ffdcf27648a&stat=instructions:u)
163+
164+
| (instructions:u) | mean | range | count |
165+
|:----------------------------------:|:-----:|:--------------:|:-----:|
166+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.6%] | 1 |
167+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 5 |
168+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
169+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
170+
| All ❌✅ (primary) | 0.1% | [-0.3%, 0.6%] | 2 |
171+
172+
* sole primary regression is to cargo opt-full by 0.6%.
173+
* no obvious smoking guns in the PR list for this rollup.
174+
* marking as triaged as "not being worth further investigation"
175+
176+
add unqualified_local_imports lint [#125645](https://github.com/rust-lang/rust/pull/125645) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9d6039ccae68a2f1930ed9c1542d387b2c0c0ba6&end=7042c269c166191cd5d8daf0409890903df7af57&stat=instructions:u)
177+
178+
| (instructions:u) | mean | range | count |
179+
|:----------------------------------:|:-----:|:--------------:|:-----:|
180+
| Regressions ❌ <br /> (primary) | - | - | 0 |
181+
| Regressions ❌ <br /> (secondary) | 1.5% | [0.4%, 2.0%] | 11 |
182+
| Improvements ✅ <br /> (primary) | - | - | 0 |
183+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 6 |
184+
| All ❌✅ (primary) | - | - | 0 |
185+
186+
* There was some surprise here for the PR author because this was an allow-by-default lint and so they didn't expect it to have any actual perf impact,
187+
because they assumed that allowed-linted could be skipped (which is not actually the way they work today, but there are PR's in process that try
188+
to get that effect).
189+
* In any case, this PR was flagged solely because of the *number* of secondary benchmarks that were affected.
190+
* Marking as triaged.
191+
192+
Rework `non_local_definitions` lint to only use a syntactic heuristic [#127117](https://github.com/rust-lang/rust/pull/127117) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=35daf8b8aa95dee4296bad117c4cb7ecaea7bf4f&end=f5cd2c5888011d4d80311e5b771c6da507d860dd&stat=instructions:u)
193+
194+
| (instructions:u) | mean | range | count |
195+
|:----------------------------------:|:-----:|:--------------:|:-----:|
196+
| Regressions ❌ <br /> (primary) | 3.3% | [0.6%, 6.6%] | 13 |
197+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.4%] | 3 |
198+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.0%, -0.2%] | 8 |
199+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 3 |
200+
| All ❌✅ (primary) | 1.8% | [-1.0%, 6.6%] | 21 |
201+
202+
* as noted by Urgau: "the version of diesel used by `rustc-perf` is too old and use named `const AA` items instead of un-named `const _` items, making the lint trigger many times (more than 150 times last time). We ruled in the past that given the regression where located in one benchmark only, and only a pathological case that the regressions where fine."
203+
* already marked as triaged.

0 commit comments

Comments
 (0)