Remove unnecessary padding from tables.

The current code tries to pad the table fields, doesn't do a good job of
it, and padding is completely ignored by the Markdown processor anyway.
This commit removes the padding.

Author: nnethercote

site/src/comparison.rs

@@ -587,25 +587,24 @@ pub fn write_summary_table(
     ]);
 
     let column_labels = [
-        "          ".to_string(), // we want at least 10 spaces to accommodate "count[^2]"
-        format!("mean{}", if with_footnotes { "[^1]" } else { "" }),
-        "max".to_string(),
-        format!("count{}", if with_footnotes { "[^2]" } else { "" }),
+        "",
+        &format!("mean{}", if with_footnotes { "[^1]" } else { "" }),
+        "max",
+        &format!("count{}", if with_footnotes { "[^2]" } else { "" }),
     ];
-    let counts: Vec<usize> = column_labels.iter().map(|s| s.chars().count()).collect();
     for column in &column_labels {
         write!(result, "| {} ", column).unwrap();
     }
     result.push_str("|\n");
-    for &count in &counts {
-        write!(result, "|:{}:", "-".repeat(count)).unwrap();
+    for _column in &column_labels {
+        write!(result, "|:---:").unwrap();
     }
     result.push_str("|\n");
 
     let mut render_row = |row: Vec<String>| {
         debug_assert_eq!(row.len(), column_labels.len());
-        for (column, &count) in row.into_iter().zip(&counts) {
-            write!(result, "| {:<1$} ", column, count).unwrap();
+        for column in row.into_iter() {
+            write!(result, "| {} ", column).unwrap();
         }
         result.push_str("|\n");
     };
@@ -1338,13 +1337,13 @@ mod tests {
                 (Category::Primary, 1.0, 3.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | 146.7%   | 200.0% | 3         |
-| Regressions ❌ <br /> (secondary) | -      | - | 0         |
-| Improvements ✅ <br /> (primary) | -      | - | 0         |
-| Improvements ✅ <br /> (secondary) | -      | - | 0         |
-| All ❌✅ (primary) | 146.7%   | 200.0% | 3         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | 146.7% | 200.0% | 3 |
+| Regressions ❌ <br /> (secondary) | - | - | 0 |
+| Improvements ✅ <br /> (primary) | - | - | 0 |
+| Improvements ✅ <br /> (secondary) | - | - | 0 |
+| All ❌✅ (primary) | 146.7% | 200.0% | 3 |
 "#
             .trim_start(),
         );
@@ -1359,13 +1358,13 @@ mod tests {
                 (Category::Primary, 4.0, 1.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | -      | - | 0         |
-| Regressions ❌ <br /> (secondary) | -      | - | 0         |
-| Improvements ✅ <br /> (primary) | -71.7%   | -80.0% | 3         |
-| Improvements ✅ <br /> (secondary) | -      | - | 0         |
-| All ❌✅ (primary) | -71.7%   | -80.0% | 3         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | - | - | 0 |
+| Regressions ❌ <br /> (secondary) | - | - | 0 |
+| Improvements ✅ <br /> (primary) | -71.7% | -80.0% | 3 |
+| Improvements ✅ <br /> (secondary) | - | - | 0 |
+| All ❌✅ (primary) | -71.7% | -80.0% | 3 |
 "#
             .trim_start(),
         );
@@ -1380,13 +1379,13 @@ mod tests {
                 (Category::Secondary, 4.0, 1.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | -      | - | 0         |
-| Regressions ❌ <br /> (secondary) | -      | - | 0         |
-| Improvements ✅ <br /> (primary) | -      | - | 0         |
-| Improvements ✅ <br /> (secondary) | -71.7%   | -80.0% | 3         |
-| All ❌✅ (primary) | -      | - | 0         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | - | - | 0 |
+| Regressions ❌ <br /> (secondary) | - | - | 0 |
+| Improvements ✅ <br /> (primary) | - | - | 0 |
+| Improvements ✅ <br /> (secondary) | -71.7% | -80.0% | 3 |
+| All ❌✅ (primary) | - | - | 0 |
 "#
             .trim_start(),
         );
@@ -1401,13 +1400,13 @@ mod tests {
                 (Category::Secondary, 1.0, 3.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | -      | - | 0         |
-| Regressions ❌ <br /> (secondary) | 146.7%   | 200.0% | 3         |
-| Improvements ✅ <br /> (primary) | -      | - | 0         |
-| Improvements ✅ <br /> (secondary) | -      | - | 0         |
-| All ❌✅ (primary) | -      | - | 0         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | - | - | 0 |
+| Regressions ❌ <br /> (secondary) | 146.7% | 200.0% | 3 |
+| Improvements ✅ <br /> (primary) | - | - | 0 |
+| Improvements ✅ <br /> (secondary) | - | - | 0 |
+| All ❌✅ (primary) | - | - | 0 |
 "#
             .trim_start(),
         );
@@ -1423,13 +1422,13 @@ mod tests {
                 (Category::Primary, 4.0, 1.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | 150.0%   | 200.0% | 2         |
-| Regressions ❌ <br /> (secondary) | -      | - | 0         |
-| Improvements ✅ <br /> (primary) | -62.5%   | -75.0% | 2         |
-| Improvements ✅ <br /> (secondary) | -      | - | 0         |
-| All ❌✅ (primary) | 43.8%    | 200.0% | 4         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | 150.0% | 200.0% | 2 |
+| Regressions ❌ <br /> (secondary) | - | - | 0 |
+| Improvements ✅ <br /> (primary) | -62.5% | -75.0% | 2 |
+| Improvements ✅ <br /> (secondary) | - | - | 0 |
+| All ❌✅ (primary) | 43.8% | 200.0% | 4 |
 "#
             .trim_start(),
         );
@@ -1447,13 +1446,13 @@ mod tests {
                 (Category::Primary, 4.0, 1.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | 150.0%   | 200.0% | 2         |
-| Regressions ❌ <br /> (secondary) | 100.0%   | 100.0% | 1         |
-| Improvements ✅ <br /> (primary) | -62.5%   | -75.0% | 2         |
-| Improvements ✅ <br /> (secondary) | -66.7%   | -66.7% | 1         |
-| All ❌✅ (primary) | 43.8%    | 200.0% | 4         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | 150.0% | 200.0% | 2 |
+| Regressions ❌ <br /> (secondary) | 100.0% | 100.0% | 1 |
+| Improvements ✅ <br /> (primary) | -62.5% | -75.0% | 2 |
+| Improvements ✅ <br /> (secondary) | -66.7% | -66.7% | 1 |
+| All ❌✅ (primary) | 43.8% | 200.0% | 4 |
 "#
             .trim_start(),
         );
@@ -1467,13 +1466,13 @@ mod tests {
                 (Category::Primary, 5.0, 6.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | 20.0%    | 20.0% | 1         |
-| Regressions ❌ <br /> (secondary) | -      | - | 0         |
-| Improvements ✅ <br /> (primary) | -50.0%   | -50.0% | 1         |
-| Improvements ✅ <br /> (secondary) | -      | - | 0         |
-| All ❌✅ (primary) | -15.0%   | -50.0% | 2         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | 20.0% | 20.0% | 1 |
+| Regressions ❌ <br /> (secondary) | - | - | 0 |
+| Improvements ✅ <br /> (primary) | -50.0% | -50.0% | 1 |
+| Improvements ✅ <br /> (secondary) | - | - | 0 |
+| All ❌✅ (primary) | -15.0% | -50.0% | 2 |
 "#
             .trim_start(),
         );
@@ -1487,13 +1486,13 @@ mod tests {
                 (Category::Primary, 6.0, 5.0),
             ],
             r#"
-|            | mean[^1] | max | count[^2] |
-|:----------:|:--------:|:---:|:---------:|
-| Regressions ❌ <br /> (primary) | 100.0%   | 100.0% | 1         |
-| Regressions ❌ <br /> (secondary) | -      | - | 0         |
-| Improvements ✅ <br /> (primary) | -16.7%   | -16.7% | 1         |
-| Improvements ✅ <br /> (secondary) | -      | - | 0         |
-| All ❌✅ (primary) | 41.7%    | 100.0% | 2         |
+|  | mean[^1] | max | count[^2] |
+|:---:|:---:|:---:|:---:|
+| Regressions ❌ <br /> (primary) | 100.0% | 100.0% | 1 |
+| Regressions ❌ <br /> (secondary) | - | - | 0 |
+| Improvements ✅ <br /> (primary) | -16.7% | -16.7% | 1 |
+| Improvements ✅ <br /> (secondary) | - | - | 0 |
+| All ❌✅ (primary) | 41.7% | 100.0% | 2 |
 "#
             .trim_start(),
         );