Skip to content

Commit 57d72e1

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Merge pull request #1521 from Mark-Simulacrum/triage
Add triage for this week
2 parents a8878a5 + d92a0c8 commit 57d72e1

File tree

1 file changed

+169
-0
lines changed

1 file changed

+169
-0
lines changed

‎triage/2023-01-31.md

Lines changed: 169 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,169 @@
1+
# 2023-01-31 Triage Log
2+
3+
Overall a positive week, with relatively few regressions overall and a number of improvements.
4+
5+
Triage done by **@simulacrum**.
6+
Revision range: [c8e6a9e8b6251bbc8276cb78cabe1998deecbed7..a64ef7d07d0411315be85a646586cb85eeb9c136](https://perf.rust-lang.org/?start=c8e6a9e8b6251bbc8276cb78cabe1998deecbed7&end=a64ef7d07d0411315be85a646586cb85eeb9c136&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.6%] | 1 |
13+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.3%] | 1 |
14+
| Improvements ✅ <br /> (primary) | -0.8% | [-2.0%, -0.2%] | 27 |
15+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.9%, -0.5%] | 11 |
16+
| All ❌✅ (primary) | -0.8% | [-2.0%, 0.6%] | 28 |
17+
18+
19+
2 Regressions, 4 Improvements, 6 Mixed; 2 of them in rollups
20+
44 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Fix thin archive reading [#107360](https://github.com/rust-lang/rust/pull/107360) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6cd6bad51fb34a0d89e97c27814041fe4d0838b5&end=252741673b9c2b06267cd3a036d77489e92f963a&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.6%] | 13 |
29+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.4%, 0.5%] | 2 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.4% | [0.3%, 0.6%] | 13 |
33+
34+
Revert of previous PR to fix behavior. Regressions are minor and hopefully the
35+
relanding of the original PR will fix them too.
36+
37+
Use stable metric for const eval limit instead of current terminator-based logic [#106227](https://github.com/rust-lang/rust/pull/106227) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bcb064a7f4aee705c97ce1b74beb9af0f9b5adb2&end=3cdd0197e78e2ca3403157617709bbfe18a3f0b5&stat=instructions:u)
38+
39+
| (instructions:u) | mean | range | count |
40+
|:----------------------------------:|:----:|:------------:|:-----:|
41+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.4%] | 3 |
42+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.5%, 1.0%] | 9 |
43+
| Improvements ✅ <br /> (primary) | - | - | 0 |
44+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
45+
| All ❌✅ (primary) | 0.3% | [0.3%, 0.4%] | 3 |
46+
47+
The new metric adds new MIR instructions, which increases the size of MIR and
48+
slightly hurts performance. However, this is in service of a concrete feature,
49+
so acceptable.
50+
51+
52+
#### Improvements
53+
54+
use `LocalDefId` instead of `HirId` in trait resolution to simplify the obligation clause resolution [#103902](https://github.com/rust-lang/rust/pull/103902) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=95b61d16d4bd2e46b0a110c1bda703f026f0a94f&end=027c8507b4265dcf285b0b503e2a49214b929f7b&stat=instructions:u)
55+
56+
| (instructions:u) | mean | range | count |
57+
|:----------------------------------:|:-----:|:--------------:|:-----:|
58+
| Regressions ❌ <br /> (primary) | - | - | 0 |
59+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
60+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.2%] | 4 |
61+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.5%, -0.3%] | 3 |
62+
| All ❌✅ (primary) | -0.3% | [-0.3%, -0.2%] | 4 |
63+
64+
65+
InstCombine away intrinsic validity assertions [#105582](https://github.com/rust-lang/rust/pull/105582) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2a17174ee639f8e0a3cee307d5685d38beb474ba&end=885bf628879310b885721e1fdd91ea2cbca9311f&stat=instructions:u)
66+
67+
| (instructions:u) | mean | range | count |
68+
|:----------------------------------:|:-----:|:--------------:|:-----:|
69+
| Regressions ❌ <br /> (primary) | - | - | 0 |
70+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
71+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.3%, -0.2%] | 6 |
72+
| Improvements ✅ <br /> (secondary) | -0.6% | [-1.3%, -0.3%] | 4 |
73+
| All ❌✅ (primary) | -0.2% | [-0.3%, -0.2%] | 6 |
74+
75+
76+
Only compute mir_generator_witnesses query in drop_tracking_mir mode. [#107406](https://github.com/rust-lang/rust/pull/107406) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9f82651a5fa4b1d96f55ce5507dd2aa204c7fb61&end=bcb064a7f4aee705c97ce1b74beb9af0f9b5adb2&stat=instructions:u)
77+
78+
| (instructions:u) | mean | range | count |
79+
|:----------------------------------:|:-----:|:--------------:|:-----:|
80+
| Regressions ❌ <br /> (primary) | - | - | 0 |
81+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
82+
| Improvements ✅ <br /> (primary) | - | - | 0 |
83+
| Improvements ✅ <br /> (secondary) | -3.7% | [-5.7%, -1.1%] | 10 |
84+
| All ❌✅ (primary) | - | - | 0 |
85+
86+
87+
Test drop_tracking_mir before querying generator. [#107443](https://github.com/rust-lang/rust/pull/107443) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=487e83b711b96d84ce2edfc4cb4ba792c10b589e&end=dc3e59cb3fe05ebd752d3a2269f501c00327be22&stat=instructions:u)
88+
89+
| (instructions:u) | mean | range | count |
90+
|:----------------------------------:|:-----:|:--------------:|:-----:|
91+
| Regressions ❌ <br /> (primary) | - | - | 0 |
92+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
93+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.2%] | 14 |
94+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.0%, -0.4%] | 8 |
95+
| All ❌✅ (primary) | -0.5% | [-0.6%, -0.2%] | 14 |
96+
97+
98+
#### Mixed
99+
100+
Move format_args!() into AST (and expand it during AST lowering) [#106745](https://github.com/rust-lang/rust/pull/106745) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=40fda7b3fe2b10c6e1a0568b59516f5e7f381886&end=3e977638728922d3a6cc7bea34a2fdb8ae97f7c0&stat=instructions:u)
101+
102+
| (instructions:u) | mean | range | count |
103+
|:----------------------------------:|:-----:|:--------------:|:-----:|
104+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 0.8%] | 4 |
105+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.3%, 1.3%] | 3 |
106+
| Improvements ✅ <br /> (primary) | -0.6% | [-2.3%, -0.2%] | 51 |
107+
| Improvements ✅ <br /> (secondary) | -0.7% | [-0.8%, -0.7%] | 6 |
108+
| All ❌✅ (primary) | -0.6% | [-2.3%, 0.8%] | 55 |
109+
110+
Overall mostly an improvement, not worth further investigation.
111+
112+
Rollup of 8 pull requests [#107343](https://github.com/rust-lang/rust/pull/107343) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=db137ba7d4415ac77e2b7601ef017ff2ca41b335&end=18890f05f6cea40fd25bb4bb9aa6f7372b69f641&stat=instructions:u)
113+
114+
| (instructions:u) | mean | range | count |
115+
|:----------------------------------:|:-----:|:--------------:|:-----:|
116+
| Regressions ❌ <br /> (primary) | 0.7% | [0.5%, 0.8%] | 7 |
117+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
118+
| Improvements ✅ <br /> (primary) | - | - | 0 |
119+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.4%] | 1 |
120+
| All ❌✅ (primary) | 0.7% | [0.5%, 0.8%] | 7 |
121+
122+
Regressions are limited to a single primary benchmark (bitmaps), and don't seem
123+
large enough to warrant spending further time investigating.
124+
125+
rustdoc: Collect "rustdoc-reachable" items during early doc link resolution [#107054](https://github.com/rust-lang/rust/pull/107054) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=18890f05f6cea40fd25bb4bb9aa6f7372b69f641&end=6874f4e3fc2a16be7c78e702d068bbc1daa90e16&stat=instructions:u)
126+
127+
| (instructions:u) | mean | range | count |
128+
|:----------------------------------:|:-----:|:--------------:|:-----:|
129+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.4%] | 2 |
130+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
131+
| Improvements ✅ <br /> (primary) | -0.5% | [-1.0%, -0.3%] | 4 |
132+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.9%, -0.2%] | 14 |
133+
| All ❌✅ (primary) | -0.2% | [-1.0%, 0.4%] | 6 |
134+
135+
Wins generally outweigh small regressions.
136+
137+
Compute generator saved locals on MIR [#101692](https://github.com/rust-lang/rust/pull/101692) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7d4df2d30eb342af1ef136d83d70d281f34adcd7&end=6cd6bad51fb34a0d89e97c27814041fe4d0838b5&stat=instructions:u)
138+
139+
| (instructions:u) | mean | range | count |
140+
|:----------------------------------:|:-----:|:--------------:|:-----:|
141+
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 0.6%] | 14 |
142+
| Regressions ❌ <br /> (secondary) | 2.2% | [0.3%, 6.0%] | 22 |
143+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.7%, -0.2%] | 12 |
144+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
145+
| All ❌✅ (primary) | 0.1% | [-0.7%, 0.6%] | 26 |
146+
147+
Follow-up in #107406 has resolved 5% regression here, leaving ~1% regressions,
148+
but those are likely overall OK.
149+
150+
Rollup of 9 pull requests [#107408](https://github.com/rust-lang/rust/pull/107408) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d8da51366817317d19be9bd138943eafb30bc987&end=bca8b4dc32ec20f9a4e0ca55f54e5b2a531936fc&stat=instructions:u)
151+
152+
| (instructions:u) | mean | range | count |
153+
|:----------------------------------:|:-----:|:--------------:|:-----:|
154+
| Regressions ❌ <br /> (primary) | 1.8% | [1.5%, 2.1%] | 6 |
155+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.2%, 1.8%] | 5 |
156+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.6%, -0.6%] | 2 |
157+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
158+
| All ❌✅ (primary) | 1.2% | [-0.6%, 2.1%] | 8 |
159+
160+
161+
Remove HirId -> LocalDefId map from HIR. [#107206](https://github.com/rust-lang/rust/pull/107206) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bca8b4dc32ec20f9a4e0ca55f54e5b2a531936fc&end=d6f0642827e21a088b0130c84857d84f5433301d&stat=instructions:u)
162+
163+
| (instructions:u) | mean | range | count |
164+
|:----------------------------------:|:-----:|:--------------:|:-----:|
165+
| Regressions ❌ <br /> (primary) | - | - | 0 |
166+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.4%] | 5 |
167+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 7 |
168+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.3%] | 7 |
169+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 7 |

0 commit comments

Comments
 (0)