Skip to content

Commit 5886e2d

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 67739c3 commit 5886e2d

File tree

1 file changed

+165
-0
lines changed

1 file changed

+165
-0
lines changed

‎triage/2024-10-21.md

Lines changed: 165 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,165 @@
1+
# 2024-10-21 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [5ceb623a..3e33bda0](https://perf.rust-lang.org/?start=5ceb623a4abd66e91e7959d25caaf0523f1a7f7c&end=3e33bda0326586a6e1e34d0f5c060ca6d116e6a4&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 0.4% | [0.2%, 0.9%] | 43 |
13+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.7%] | 36 |
14+
| Improvements ✅ <br /> (primary) | -0.8% | [-5.1%, -0.2%] | 92 |
15+
| Improvements ✅ <br /> (secondary) | -0.8% | [-2.0%, -0.1%] | 65 |
16+
| All ❌✅ (primary) | -0.4% | [-5.1%, 0.9%] | 135 |
17+
18+
19+
0 Regressions, 3 Improvements, 6 Mixed; 3 of them in rollups
20+
47 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
25+
26+
#### Improvements
27+
28+
stabilize `-Znext-solver=coherence` again [#130654](https://github.com/rust-lang/rust/pull/130654) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f79fae3069c449993eda6b16934da3b144cb8a66&end=a0c2aba29aa9ea50a7c45c3391dd446f856bef7b&stat=instructions:u)
29+
30+
| (instructions:u) | mean | range | count |
31+
|:----------------------------------:|:-----:|:--------------:|:-----:|
32+
| Regressions ❌ <br /> (primary) | - | - | 0 |
33+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
34+
| Improvements ✅ <br /> (primary) | -1.9% | [-4.5%, -0.2%] | 17 |
35+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 3 |
36+
| All ❌✅ (primary) | -1.9% | [-4.5%, -0.2%] | 17 |
37+
38+
39+
Remove `GenKillAnalysis` [#131481](https://github.com/rust-lang/rust/pull/131481) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1f67a7aa8d5b30c43c28ed9b2621cf4b7b8bb963&end=d829780c4e4ef11f5e09c1c5ed9684c12aad7236&stat=instructions:u)
40+
41+
| (instructions:u) | mean | range | count |
42+
|:----------------------------------:|:-----:|:--------------:|:-----:|
43+
| Regressions ❌ <br /> (primary) | - | - | 0 |
44+
| Regressions ❌ <br /> (secondary) | 1.6% | [1.6%, 1.6%] | 1 |
45+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.7%, -0.2%] | 24 |
46+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.9%, -0.1%] | 19 |
47+
| All ❌✅ (primary) | -0.4% | [-0.7%, -0.2%] | 24 |
48+
49+
50+
Rollup of 8 pull requests [#131792](https://github.com/rust-lang/rust/pull/131792) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bed75e7c21e8d18bd536a0f7c9e479d2f6707db3&end=7342830c05ec0996e9e4b7df550b1043dca7829c&stat=instructions:u)
51+
52+
| (instructions:u) | mean | range | count |
53+
|:----------------------------------:|:-----:|:--------------:|:-----:|
54+
| Regressions ❌ <br /> (primary) | - | - | 0 |
55+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
56+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 5 |
57+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
58+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 5 |
59+
60+
61+
#### Mixed
62+
63+
Add `#[track_caller]` to allocating methods of `Vec` & `VecDeque` [#126557](https://github.com/rust-lang/rust/pull/126557) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5ceb623a4abd66e91e7959d25caaf0523f1a7f7c&end=f6648f252a05a0a46c865d7ec836b46290613bf9&stat=instructions:u)
64+
65+
| (instructions:u) | mean | range | count |
66+
|:----------------------------------:|:-----:|:--------------:|:-----:|
67+
| Regressions ❌ <br /> (primary) | 0.3% | [0.0%, 0.5%] | 26 |
68+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
69+
| Improvements ✅ <br /> (primary) | - | - | 0 |
70+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.2%, -0.1%] | 4 |
71+
| All ❌✅ (primary) | 0.3% | [0.0%, 0.5%] | 26 |
72+
73+
74+
Rollup of 8 pull requests [#131690](https://github.com/rust-lang/rust/pull/131690) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=17a19e684cdf3ca088af8b4da6a6209d128913f4&end=9322d183f45e0fd5a509820874cc5ff27744a479&stat=instructions:u)
75+
76+
| (instructions:u) | mean | range | count |
77+
|:----------------------------------:|:-----:|:--------------:|:-----:|
78+
| Regressions ❌ <br /> (primary) | 0.4% | [0.4%, 0.4%] | 1 |
79+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
80+
| Improvements ✅ <br /> (primary) | -0.6% | [-0.8%, -0.3%] | 2 |
81+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
82+
| All ❌✅ (primary) | -0.2% | [-0.8%, 0.4%] | 3 |
83+
84+
85+
Use `ThinVec` for PredicateObligation storage [#131422](https://github.com/rust-lang/rust/pull/131422) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9ce3675b438aae22ef0c6147cde2003a418ab722&end=9618da7c9995a673af4841149ba2d1f53b69dd92&stat=instructions:u)
86+
87+
| (instructions:u) | mean | range | count |
88+
|:----------------------------------:|:-----:|:--------------:|:-----:|
89+
| Regressions ❌ <br /> (primary) | - | - | 0 |
90+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.5%] | 8 |
91+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.7%, -0.2%] | 15 |
92+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.7%, -0.2%] | 23 |
93+
| All ❌✅ (primary) | -0.3% | [-0.7%, -0.2%] | 15 |
94+
95+
96+
optimize str.replace [#130223](https://github.com/rust-lang/rust/pull/130223) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3a85d3fa785d95a7b7bcf4f160b67bffba7afd4a&end=86bd45979a964678b40b79156744f0057759d840&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:-----:|:--------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | 0.5% | [0.2%, 1.2%] | 5 |
101+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
102+
| Improvements ✅ <br /> (primary) | -0.8% | [-0.8%, -0.8%] | 1 |
103+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.4%, -0.3%] | 6 |
104+
| All ❌✅ (primary) | 0.3% | [-0.8%, 1.2%] | 6 |
105+
106+
107+
Rollup of 8 pull requests [#131934](https://github.com/rust-lang/rust/pull/131934) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=a2a1206811d864df2bb61b2fc27ddc45a3589424&end=8069f8d17a6c86a8fd881939fcce359a90c57ff2&stat=instructions:u)
108+
109+
| (instructions:u) | mean | range | count |
110+
|:----------------------------------:|:-----:|:--------------:|:-----:|
111+
| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.3%] | 2 |
112+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.3%] | 11 |
113+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
114+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
115+
| All ❌✅ (primary) | 0.1% | [-0.2%, 0.3%] | 3 |
116+
117+
118+
Update rustc-hash to version 2 but again [#131949](https://github.com/rust-lang/rust/pull/131949) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=de977a5acf210f7d71ff83f4b8bc42c274ce4ed9&end=662180b34d95f72d05b7c467b0baf4d23d36b1e1&stat=instructions:u)
119+
120+
| (instructions:u) | mean | range | count |
121+
|:----------------------------------:|:-----:|:--------------:|:-----:|
122+
| Regressions ❌ <br /> (primary) | 0.2% | [0.1%, 0.2%] | 8 |
123+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.1%, 0.7%] | 9 |
124+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.5%, -0.2%] | 10 |
125+
| Improvements ✅ <br /> (secondary) | -0.9% | [-1.4%, -0.6%] | 13 |
126+
| All ❌✅ (primary) | -0.1% | [-0.5%, 0.2%] | 18 |
127+
128+
129+
#### Untriaged Pull Requests
130+
131+
- [#131949 Update rustc-hash to version 2 but again](https://github.com/rust-lang/rust/pull/131949)
132+
- [#131934 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/131934)
133+
- [#131690 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/131690)
134+
- [#131422 Use `ThinVec` for PredicateObligation storage](https://github.com/rust-lang/rust/pull/131422)
135+
- [#131263 Introduce SolverRelating type relation to the new solver](https://github.com/rust-lang/rust/pull/131263)
136+
- [#131111 Rollup of 4 pull requests](https://github.com/rust-lang/rust/pull/131111)
137+
- [#130223 optimize str.replace](https://github.com/rust-lang/rust/pull/130223)
138+
- [#130091 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/130091)
139+
- [#129831 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/129831)
140+
- [#129817 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/129817)
141+
- [#129797 Try to reduce space usage in dist CI](https://github.com/rust-lang/rust/pull/129797)
142+
- [#129790 Bump to 1.83](https://github.com/rust-lang/rust/pull/129790)
143+
- [#129632 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/129632)
144+
- [#129063 Apply size optimizations to panic machinery and some cold functions](https://github.com/rust-lang/rust/pull/129063)
145+
- [#128936 Support reading thin archives in ArArchiveBuilder](https://github.com/rust-lang/rust/pull/128936)
146+
- [#128443 Properly mark loop as diverging if it has no breaks](https://github.com/rust-lang/rust/pull/128443)
147+
- [#128357 Detect non-lifetime binder params shadowing item params](https://github.com/rust-lang/rust/pull/128357)
148+
- [#128301 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/128301)
149+
- [#128299 Simplify the canonical clone method and the copy-like forms to copy](https://github.com/rust-lang/rust/pull/128299)
150+
- [#128169 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/128169)
151+
- [#128155 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/128155)
152+
- [#128104 Not lint pub structs without pub constructors intentionally](https://github.com/rust-lang/rust/pull/128104)
153+
- [#127998 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/127998)
154+
- [#127865 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/127865)
155+
- [#127537 Implement a first version of RFC 3525: struct target features](https://github.com/rust-lang/rust/pull/127537)
156+
- [#127528 Replace ASCII control chars with Unicode Control Pictures](https://github.com/rust-lang/rust/pull/127528)
157+
- [#127486 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/127486)
158+
- [#127439 Uplift elaboration into `rustc_type_ir`](https://github.com/rust-lang/rust/pull/127439)
159+
- [#127172 Make `can_eq` process obligations (almost) everywhere](https://github.com/rust-lang/rust/pull/127172)
160+
- [#127096 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/127096)
161+
162+
#### Nags requiring follow up
163+
164+
TODO: Nags
165+

0 commit comments

Comments
 (0)