|
| 1 | +# 2022-03-15 Triage Log |
| 2 | + |
| 3 | +Largely a quiet week. The perf improvement highlight is the use of real world crates such as `syn`, `cargo`, and `serde` in the collecting of profile guided optimization (PGO) profiles for LLVM. Previously only `libcore` was used for LLVM, though rustc PGO had more crates involved. This led to some decent improvement in compilation of real world crates (upwards of 5.5%). |
| 4 | + |
| 5 | +On the regression side, the regressions were all largely small but contained inside of rollups making them hard to diagnose and correct. The perf team continues to work on process improvements that make changes to the compiler land through CI quickly while minimizing perf regressions that can sneak through. |
| 6 | + |
| 7 | +Triage done by **@rylev**. |
| 8 | +Revision range: [10dccdc7fcbdc64ee9efe2c1ed975ab8c1d61287..3ba1ebea122238d1a5c613deb1bf60ce24bd8fd8](https://perf.rust-lang.org/?start=10dccdc7fcbdc64ee9efe2c1ed975ab8c1d61287&end=3ba1ebea122238d1a5c613deb1bf60ce24bd8fd8&absolute=false&stat=instructions%3Au) |
| 9 | + |
| 10 | +2 Regressions, 3 Improvements, 3 Mixed; 3 of them in rollups |
| 11 | +42 comparisons made in total |
| 12 | + |
| 13 | +#### Regressions |
| 14 | + |
| 15 | +Rollup of 8 pull requests [#94814](https://github.com/rust-lang/rust/pull/94814) |
| 16 | +- Arithmetic mean of relevant regressions: 2.1% |
| 17 | +- Arithmetic mean of all relevant changes: 1.8% |
| 18 | +- Largest regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=ba14a836c7038da21f5e102aacc7e6d5964f79a6&end=5f4e0677190b82e61dc507e3e72caf89da8e5e28&stat=instructions:u): 16.8% on `incr-patched: println` builds of `cargo opt` |
| 19 | +* Mostly an extremely large regression in compiling optimized builds of `cargo` in an incremental patch scenario. |
| 20 | +* Looks like in the impacted test case the regression is largely in codegen |
| 21 | +* [#94809](https://github.com/rust-lang/rust/pull/94809) is the only change that meaningful touches codegen and luckily testing whether reverting the change makes a difference should be trivial to do. Left a [comment](https://github.com/rust-lang/rust/pull/94814#issuecomment-1067945114) here. |
| 22 | + |
| 23 | + |
| 24 | +Rollup of 7 pull requests [#94824](https://github.com/rust-lang/rust/pull/94824) |
| 25 | +- Arithmetic mean of relevant regressions: 0.5% |
| 26 | +- Arithmetic mean of relevant improvements: -0.3% |
| 27 | +- Arithmetic mean of all relevant changes: 0.4% |
| 28 | +- Largest regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=5f4e0677190b82e61dc507e3e72caf89da8e5e28&end=352e621368c31d7b4a6362e081586cdb931ba020&stat=instructions:u): 1.5% on `incr-unchanged` builds of `unicode_normalization check` |
| 29 | +* Unfortunately there are many PRs that could plausibly contribute to the performance change: |
| 30 | + * [#93950](https://github.com/rust-lang/rust/pull/93950) (Use modern formatting for format! macros) |
| 31 | + * [#94274](https://github.com/rust-lang/rust/pull/94274) (Treat unstable lints as unknown) |
| 32 | + * [#94368](https://github.com/rust-lang/rust/pull/94368) ([1/2] Implement macro meta-variable expressions) |
| 33 | +* The overall regression seems low enough that I don't think we need to consider reverting though. Unfortunately we don't have a good process for determining the culprit in cases like this where many PRs seem somewhat equally likely to be the cause. |
| 34 | +* Left a comment as such [here](https://github.com/rust-lang/rust/pull/94824#issuecomment-1067957978) |
| 35 | + |
| 36 | + |
| 37 | +#### Improvements |
| 38 | + |
| 39 | +Improve `AdtDef` interning. [#94733](https://github.com/rust-lang/rust/pull/94733) |
| 40 | +- Arithmetic mean of relevant improvements: -0.5% |
| 41 | +- Largest improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=2c6a29af35a81e20f8af4c32bf1b55c59b89eccd&end=012720ffb075a087b781325d17d1822a340a2f2a&stat=instructions:u): -1.2% on `full` builds of `match-stress-enum doc` |
| 42 | + |
| 43 | + |
| 44 | +Queryify `is_doc_hidden` [#94897](https://github.com/rust-lang/rust/pull/94897) |
| 45 | +- Arithmetic mean of relevant improvements: -0.7% |
| 46 | +- Largest improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=7eac19c30c9aa69bc3d85a583c117c37c1579de3&end=4800c7816ee1937d028407066d229f74b4673c92&stat=instructions:u): -1.1% on `full` builds of `projection-caching doc` |
| 47 | + |
| 48 | + |
| 49 | +Gather LLVM PGO profiles from `rustc-perf` suite on real-world crates [#94704](https://github.com/rust-lang/rust/pull/94704) |
| 50 | +- Arithmetic mean of relevant improvements: -2.8% |
| 51 | +- Largest improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=b2763cc4cfa761a1d42cc01c7603ba6a98c09ecd&end=ebed06fcba3b58913a5087039a81478d43b47b2f&stat=instructions:u): -5.6% on `incr-full` builds of `style-servo debug` |
| 52 | + |
| 53 | + |
| 54 | +#### Mixed |
| 55 | + |
| 56 | +Treat constant values as mir::ConstantKind::Val [#94059](https://github.com/rust-lang/rust/pull/94059) |
| 57 | +- Arithmetic mean of relevant regressions: 1.3% |
| 58 | +- Arithmetic mean of relevant improvements: -1.0% |
| 59 | +- Arithmetic mean of all relevant changes: -0.9% |
| 60 | +- Largest improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=01ad0ad653d57a5ccecffb08aff3c5564012f133&end=d7b282b886472413a26ef22c848eda0499d12cd3&stat=instructions:u): -6.6% on `full` builds of `ctfe-stress-4 opt` |
| 61 | +- Largest regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=01ad0ad653d57a5ccecffb08aff3c5564012f133&end=d7b282b886472413a26ef22c848eda0499d12cd3&stat=instructions:u): 1.6% on `full` builds of `keccak check` |
| 62 | +* Since the regressions are all in secondary benchmarks and relatively small, we consider this to be an improvement rather than a mixed result. |
| 63 | + |
| 64 | + |
| 65 | +Change several HashMaps to IndexMap to improve incremental hashing performance [#90253](https://github.com/rust-lang/rust/pull/90253) |
| 66 | +- Arithmetic mean of relevant regressions: 0.3% |
| 67 | +- Arithmetic mean of relevant improvements: -0.8% |
| 68 | +- Arithmetic mean of all relevant changes: -0.2% |
| 69 | +- Largest improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=af8604faddc44b27a59d1a719ff6ceca8bc145eb&end=c9b45e601065c3fb71a4f67481e912391d075621&stat=instructions:u): -7.5% on `incr-full` builds of `clap-rs check` |
| 70 | +- Largest regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=af8604faddc44b27a59d1a719ff6ceca8bc145eb&end=c9b45e601065c3fb71a4f67481e912391d075621&stat=instructions:u): 0.6% on `full` builds of `deep-vector check` |
| 71 | +* Perf was run previously and it was found that there was a large improvements to clap-rs but otherwise an overall performance wash |
| 72 | +* This story has not really changed, so the PR was marked [as triaged](https://github.com/rust-lang/rust/pull/90253#issuecomment-1067975046) |
| 73 | + |
| 74 | + |
| 75 | +Use MaybeUninit in VecDeque to remove the undefined behavior of slice [#94472](https://github.com/rust-lang/rust/pull/94472) |
| 76 | +- Arithmetic mean of relevant regressions: 0.9% |
| 77 | +- Arithmetic mean of all relevant changes: -2.0% |
| 78 | +- Largest improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=c9b45e601065c3fb71a4f67481e912391d075621&end=335ffbfa547df94ac236f5c56130cecf99c8d82b&stat=instructions:u): -10.7% on `incr-patched: println` builds of `tokio-webpush-simple opt` |
| 79 | +- Largest regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=c9b45e601065c3fb71a4f67481e912391d075621&end=335ffbfa547df94ac236f5c56130cecf99c8d82b&stat=instructions:u): 1.1% on `full` builds of `tokio-webpush-simple opt` |
| 80 | +* Dominated by a large improvement in the `tokio-webpush-simple opt incremental patch` test case, the micro benchmarks indicate that this is largely a performance wash (most benchmarks don't seem to show statistical difference and those that do are a mix of small regressions and improvements) |
| 81 | +* Given all this, the PR was marked [as triaged](https://github.com/rust-lang/rust/pull/94472#issuecomment-1067983132). |
| 82 | + |
| 83 | + |
| 84 | +#### Untriaged Pull Requests |
| 85 | + |
| 86 | +- [#94824 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/94824) |
| 87 | +- [#94814 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/94814) |
| 88 | +- [#94402 Revert "Auto merge of #92419 - erikdesjardins:coldland, r=nagisa"](https://github.com/rust-lang/rust/pull/94402) |
| 89 | +- [#94333 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/94333) |
| 90 | +- [#94130 Use undef for (some) partially-uninit constants](https://github.com/rust-lang/rust/pull/94130) |
| 91 | +- [#94103 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/94103) |
| 92 | +- [#94072 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/94072) |
| 93 | +- [#93670 Apply noundef attribute to &T, &mut T, Box<T>, bool](https://github.com/rust-lang/rust/pull/93670) |
| 94 | +- [#93505 safely `transmute<&List<Ty<'tcx>>, &List<GenericArg<'tcx>>>`](https://github.com/rust-lang/rust/pull/93505) |
| 95 | +- [#93466 Make dead code check a query.](https://github.com/rust-lang/rust/pull/93466) |
| 96 | +- [#93312 Return an indexmap in `all_local_trait_impls` query](https://github.com/rust-lang/rust/pull/93312) |
| 97 | +- [#93298 make `find_similar_impl_candidates` even fuzzier](https://github.com/rust-lang/rust/pull/93298) |
| 98 | +- [#93288 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/93288) |
| 99 | +- [#93154 debuginfo: Make sure that type names for closure and generator environments are unique in debuginfo.](https://github.com/rust-lang/rust/pull/93154) |
| 100 | +- [#93148 Overhaul interning.](https://github.com/rust-lang/rust/pull/93148) |
| 101 | +- [#93138 Rollup of 17 pull requests](https://github.com/rust-lang/rust/pull/93138) |
| 102 | +- [#93095 Store a `Symbol` instead of an `Ident` in `AssocItem`](https://github.com/rust-lang/rust/pull/93095) |
| 103 | +- [#92911 Guard against unwinding in cleanup code](https://github.com/rust-lang/rust/pull/92911) |
| 104 | +- [#92896 Update some rustc dependencies to deduplicate them](https://github.com/rust-lang/rust/pull/92896) |
| 105 | +- [#92844 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/92844) |
| 106 | +- [#92816 Remove deprecated LLVM-style inline assembly](https://github.com/rust-lang/rust/pull/92816) |
| 107 | +- [#92805 partially revertish `lazily "compute" anon const default substs`](https://github.com/rust-lang/rust/pull/92805) |
| 108 | +- [#92535 Allow unwinding from OOM hooks](https://github.com/rust-lang/rust/pull/92535) |
| 109 | +- [#92534 Hash `Ident` spans in all HIR structures](https://github.com/rust-lang/rust/pull/92534) |
| 110 | +- [#92356 Add {Add,Sub,Mul,Div,Rem,BitXor,BitOr,BitAnd}{,Assign}<$t> to Saturat…](https://github.com/rust-lang/rust/pull/92356) |
| 111 | +- [#92277 rustc_metadata: Stop passing `CrateMetadataRef` by reference (step 1)](https://github.com/rust-lang/rust/pull/92277) |
| 112 | +- [#92252 Update pulldown-cmark version to 0.9](https://github.com/rust-lang/rust/pull/92252) |
0 commit comments