Skip to content

Commit 60cfb7a

Browse files
committed
Respond to review feedback
1 parent 4c4a5ee commit 60cfb7a

File tree

2 files changed

+4
-2
lines changed

2 files changed

+4
-2
lines changed

collector/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -165,7 +165,7 @@ environments do not permit access to these counters for guest VMs.
165165
You will also need to provide the paths to the xperf and tracelog tools (or have them
166166
available on your PATH). Some common paths to these tools look like:
167167

168-
```
168+
```pwsh
169169
$env:XPERF="C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\xperf.exe"
170170
$env:TRACELOG="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\tracelog.exe"
171171
```
@@ -177,7 +177,7 @@ profiler is the `self-profiler`.
177177
As a complete example, let's run just the `regex` benchmark in the `Debug` build with
178178
self-profiling results available:
179179

180-
```
180+
```pwsh
181181
$env:XPERF="C:\Program Files (x86)\Windows Kits\10\Windows Performance Toolkit\xperf.exe"
182182
$env:TRACELOG="C:\Program Files (x86)\Windows Kits\10\bin\10.0.19041.0\x64\tracelog.exe"
183183
.\target\release\collector.exe bench_local $env:RUST_ORIGINAL Original --builds Debug --include regex --self-profile

collector/src/etw_parser.rs

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,7 @@ fn validate_os_header_line(r: &mut dyn BufRead) -> anyhow::Result<()> {
120120
Ok(())
121121
}
122122

123+
/// An instance of a Performance Monitoring Counter event.
123124
#[derive(Debug, Eq, PartialEq)]
124125
struct Pmc {
125126
timestamp: u64,
@@ -128,6 +129,7 @@ struct Pmc {
128129
total_cycles: u64,
129130
}
130131

132+
/// An instance of a Context Switch event.
131133
#[derive(Debug, Eq, PartialEq)]
132134
struct CSwitch {
133135
timestamp: u64,

0 commit comments

Comments
 (0)