Skip to content

Commit 6634afb

Browse files
committed
Demote futures to only run in the "stable" set.
1 parent e2ec11a commit 6634afb

File tree

3 files changed

+11
-7
lines changed

3 files changed

+11
-7
lines changed

ci/check-profiling.sh

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -129,7 +129,7 @@ test -f results/eprintln-Test-helloworld-Check-Full
129129
test ! -s results/eprintln-Test-helloworld-Check-Full
130130

131131
# llvm-lines. `Debug` not `Check` because it doesn't support `Check` profiles.
132-
# Including both `helloworld` and `futures` benchmarks, as they exercise the
132+
# Including both `helloworld` and `regex` benchmarks, as they exercise the
133133
# zero dependency and the greater than zero dependency cases, respectively, the
134134
# latter of which has broken before.
135135
RUST_BACKTRACE=1 RUST_LOG=raw_cargo_messages=trace,collector=debug,rust_sysroot=debug \
@@ -138,12 +138,12 @@ RUST_BACKTRACE=1 RUST_LOG=raw_cargo_messages=trace,collector=debug,rust_sysroot=
138138
--id Test \
139139
--profiles Debug \
140140
--cargo $bindir/cargo \
141-
--include helloworld,futures \
141+
--include helloworld,regex \
142142
--scenarios Full
143143
test -f results/ll-Test-helloworld-Debug-Full
144144
grep -q "Lines.*Copies.*Function name" results/ll-Test-helloworld-Debug-Full
145-
test -f results/ll-Test-futures-Debug-Full
146-
grep -q "Lines.*Copies.*Function name" results/ll-Test-futures-Debug-Full
145+
test -f results/ll-Test-regex-Debug-Full
146+
grep -q "Lines.*Copies.*Function name" results/ll-Test-regex-Debug-Full
147147

148148

149149
#----------------------------------------------------------------------------

collector/benchmarks/README.md

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,6 @@ They mostly consist of real-world crates.
2626
trait bounds, by having a lot of trait impls for a large number of different
2727
types.
2828
- **encoding**: Character encoding support. Contains some large tables.
29-
- **futures**: A futures implementation. Used by many Rust programs.
3029
- **helloworld**: A trivial program. Gives a lower bound on compile time.
3130
- **html5ever**: An HTML parser. Stresses macro parsing code significantly.
3231
- **hyper-2**: A fairly large crate. Utilizes async/await, and used by
@@ -133,7 +132,12 @@ quite old (e.g. 2017 or earlier), and not necessarily reflective of typical
133132
Rust code being written today.
134133

135134
- **encoding**: See above.
136-
- **futures**: See above.
135+
- **futures**: v0.1.0 of the popular `futures` crate, which was used by many
136+
Rust programs. Note that newer versions of this crate (e.g. v0.3.21 from
137+
February 2021) contain very little code, instead relying on sub-crates, which
138+
makes them uninteresting as benchmarks (because we only measure final crate
139+
compilation). That explains why there is no `futures-X.Y.Z` crate among the
140+
primary benchmarks.
137141
- **html5ever**: See above.
138142
- **inflate**: See above.
139143
- **regex**: See above.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,3 @@
11
{
2-
"category": "primary-and-stable"
2+
"category": "stable"
33
}

0 commit comments

Comments
 (0)