Skip to content

Commit 68945f7

Browse files
pnkfelixpnkfelix
committed
Initial triage report template.
1 parent 420cfca commit 68945f7

File tree

1 file changed

+262
-0
lines changed

1 file changed

+262
-0
lines changed

‎triage/2024-07-02.md

Lines changed: 262 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,262 @@
1+
# 2024-07-02 Triage Log
2+
3+
TODO: Summary
4+
5+
Triage done by **@???**.
6+
Revision range: [c3d7fb39..cf2df68d](https://perf.rust-lang.org/?start=c3d7fb398569407350abe044e786bc7890c90397&end=cf2df68d1f5e56803c97d91e2b1a9f1c9923c533&absolute=false&stat=instructions%3Au)
7+
8+
**Summary**:
9+
10+
| (instructions:u) | mean | range | count |
11+
|:----------------------------------:|:-----:|:--------------:|:-----:|
12+
| Regressions ❌ <br /> (primary) | 1.0% | [0.2%, 2.8%] | 109 |
13+
| Regressions ❌ <br /> (secondary) | 1.4% | [0.3%, 8.0%] | 50 |
14+
| Improvements ✅ <br /> (primary) | -1.3% | [-4.3%, -0.2%] | 41 |
15+
| Improvements ✅ <br /> (secondary) | -1.3% | [-4.4%, -0.2%] | 75 |
16+
| All ❌✅ (primary) | 0.4% | [-4.3%, 2.8%] | 150 |
17+
18+
19+
4 Regressions, 3 Improvements, 11 Mixed; 7 of them in rollups
20+
59 artifact comparisons made in total
21+
22+
#### Regressions
23+
24+
Rollup of 7 pull requests [#126951](https://github.com/rust-lang/rust/pull/126951) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fda509e817abeeecb5b76bc1de844f355675c81e&end=31f8b70d2e18a0339c034e44c52aa3791c29f53c&stat=instructions:u)
25+
26+
| (instructions:u) | mean | range | count |
27+
|:----------------------------------:|:----:|:------------:|:-----:|
28+
| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.6%] | 3 |
29+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
30+
| Improvements ✅ <br /> (primary) | - | - | 0 |
31+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
32+
| All ❌✅ (primary) | 0.5% | [0.5%, 0.6%] | 3 |
33+
34+
35+
Let's `#[expect]` some lints: Stabilize `lint_reasons` (RFC 2383) [#120924](https://github.com/rust-lang/rust/pull/120924) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d7c59370cea68cd17006ec3440a43254fd0eda7d&end=4bc39f028d14c24b04dd17dc425432c6ec354536&stat=instructions:u)
36+
37+
| (instructions:u) | mean | range | count |
38+
|:----------------------------------:|:----:|:------------:|:-----:|
39+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.9%] | 142 |
40+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.1%, 1.5%] | 79 |
41+
| Improvements ✅ <br /> (primary) | - | - | 0 |
42+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
43+
| All ❌✅ (primary) | 0.6% | [0.2%, 1.9%] | 142 |
44+
45+
46+
Update browser-ui-test version to `0.18.0` [#127010](https://github.com/rust-lang/rust/pull/127010) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9c3bc805dd9cb84019c124b9a50fdff1e62a7ec9&end=42add88d2275b95c98e512ab680436ede691e853&stat=instructions:u)
47+
48+
| (instructions:u) | mean | range | count |
49+
|:----------------------------------:|:----:|:------------:|:-----:|
50+
| Regressions ❌ <br /> (primary) | - | - | 0 |
51+
| Regressions ❌ <br /> (secondary) | 7.2% | [7.2%, 7.2%] | 1 |
52+
| Improvements ✅ <br /> (primary) | - | - | 0 |
53+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
54+
| All ❌✅ (primary) | - | - | 0 |
55+
56+
57+
Implement new effects desugaring [#120639](https://github.com/rust-lang/rust/pull/120639) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d1b7355d3d7b4ead564dbecb1d240fcc74fff21b&end=ba1d7f4a083e6402679105115ded645512a7aea8&stat=instructions:u)
58+
59+
| (instructions:u) | mean | range | count |
60+
|:----------------------------------:|:----:|:------------:|:-----:|
61+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.6%] | 72 |
62+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.1%, 0.9%] | 24 |
63+
| Improvements ✅ <br /> (primary) | - | - | 0 |
64+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
65+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.6%] | 72 |
66+
67+
68+
#### Improvements
69+
70+
Save 2 pointers in `TerminatorKind` (96 → 80 bytes) [#126784](https://github.com/rust-lang/rust/pull/126784) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5a3e2a4e921097c8f2bf6ea7565f8abe878cdbd4&end=d8d5732456d375f7c4bdc2f6ad771989a5e0ae02&stat=instructions:u)
71+
72+
| (instructions:u) | mean | range | count |
73+
|:----------------------------------:|:-----:|:--------------:|:-----:|
74+
| Regressions ❌ <br /> (primary) | - | - | 0 |
75+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
76+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.2%] | 9 |
77+
| Improvements ✅ <br /> (secondary) | -0.1% | [-0.1%, -0.1%] | 4 |
78+
| All ❌✅ (primary) | -0.4% | [-0.5%, -0.2%] | 9 |
79+
80+
81+
rustdoc: use current stage if download-rustc enabled [#126728](https://github.com/rust-lang/rust/pull/126728) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=127fa2261b730a42e6d98b7927c3888ecd08f3e0&end=a4ce33c0b232deda1cbce447e80f187cd34952a6&stat=instructions:u)
82+
83+
| (instructions:u) | mean | range | count |
84+
|:----------------------------------:|:-----:|:--------------:|:-----:|
85+
| Regressions ❌ <br /> (primary) | - | - | 0 |
86+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
87+
| Improvements ✅ <br /> (primary) | - | - | 0 |
88+
| Improvements ✅ <br /> (secondary) | -8.0% | [-8.0%, -8.0%] | 1 |
89+
| All ❌✅ (primary) | - | - | 0 |
90+
91+
92+
Rollup of 9 pull requests [#127174](https://github.com/rust-lang/rust/pull/127174) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ef3d6fd7002500af0a985f70d3ac5152623c1396&end=6868c831a1eb45c5150ff623cef5e42a8b8946d0&stat=instructions:u)
93+
94+
| (instructions:u) | mean | range | count |
95+
|:----------------------------------:|:-----:|:--------------:|:-----:|
96+
| Regressions ❌ <br /> (primary) | - | - | 0 |
97+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
98+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.1%, -0.2%] | 46 |
99+
| Improvements ✅ <br /> (secondary) | -1.3% | [-2.9%, -0.2%] | 36 |
100+
| All ❌✅ (primary) | -0.4% | [-1.1%, -0.2%] | 46 |
101+
102+
103+
#### Mixed
104+
105+
Rollup of 9 pull requests [#126878](https://github.com/rust-lang/rust/pull/126878) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=33422e72c8a66bdb5ee21246a948a1a02ca91674&end=bcf94dec5ba6838e435902120c0384c360126a26&stat=instructions:u)
106+
107+
| (instructions:u) | mean | range | count |
108+
|:----------------------------------:|:-----:|:--------------:|:-----:|
109+
| Regressions ❌ <br /> (primary) | - | - | 0 |
110+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.5%] | 6 |
111+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.3%] | 4 |
112+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
113+
| All ❌✅ (primary) | -0.4% | [-0.5%, -0.3%] | 4 |
114+
115+
116+
Add `SliceLike` to `rustc_type_ir`, use it in the generic solver code (+ some other changes) [#126813](https://github.com/rust-lang/rust/pull/126813) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6b0f4b5ec3aa707ecaa78230722117324a4ce23c&end=5b270e1198e911247244b035a6f06ce3af0a4420&stat=instructions:u)
117+
118+
| (instructions:u) | mean | range | count |
119+
|:----------------------------------:|:-----:|:--------------:|:-----:|
120+
| Regressions ❌ <br /> (primary) | - | - | 0 |
121+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.4%, 0.8%] | 7 |
122+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.6%, -0.3%] | 12 |
123+
| Improvements ✅ <br /> (secondary) | -0.7% | [-2.2%, -0.2%] | 9 |
124+
| All ❌✅ (primary) | -0.4% | [-0.6%, -0.3%] | 12 |
125+
126+
127+
Also get `add nuw` from `uN::checked_add` [#126852](https://github.com/rust-lang/rust/pull/126852) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=5b270e1198e911247244b035a6f06ce3af0a4420&end=fc555cd832ee743ff5410c35de2b0dd59ec4322e&stat=instructions:u)
128+
129+
| (instructions:u) | mean | range | count |
130+
|:----------------------------------:|:-----:|:--------------:|:-----:|
131+
| Regressions ❌ <br /> (primary) | 0.6% | [0.3%, 0.9%] | 4 |
132+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 0.4%] | 2 |
133+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.3%, -0.3%] | 1 |
134+
| Improvements ✅ <br /> (secondary) | -1.3% | [-1.4%, -0.9%] | 7 |
135+
| All ❌✅ (primary) | 0.4% | [-0.3%, 0.9%] | 5 |
136+
137+
138+
ast: Standardize visiting order for attributes and node IDs [#125741](https://github.com/rust-lang/rust/pull/125741) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c2d2bb38c9067d983d13505c47e761308b1694db&end=d929a42a664c026167800801b26d734db925314f&stat=instructions:u)
139+
140+
| (instructions:u) | mean | range | count |
141+
|:----------------------------------:|:-----:|:--------------:|:-----:|
142+
| Regressions ❌ <br /> (primary) | - | - | 0 |
143+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.2%, 0.3%] | 3 |
144+
| Improvements ✅ <br /> (primary) | - | - | 0 |
145+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.4%, -0.2%] | 12 |
146+
| All ❌✅ (primary) | - | - | 0 |
147+
148+
149+
Rollup of 8 pull requests [#126965](https://github.com/rust-lang/rust/pull/126965) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c290e9de32e8ba6a673ef125fde40eadd395d170&end=fda509e817abeeecb5b76bc1de844f355675c81e&stat=instructions:u)
150+
151+
| (instructions:u) | mean | range | count |
152+
|:----------------------------------:|:-----:|:--------------:|:-----:|
153+
| Regressions ❌ <br /> (primary) | - | - | 0 |
154+
| Regressions ❌ <br /> (secondary) | 3.3% | [1.7%, 5.8%] | 9 |
155+
| Improvements ✅ <br /> (primary) | - | - | 0 |
156+
| Improvements ✅ <br /> (secondary) | -3.0% | [-5.7%, -0.3%] | 2 |
157+
| All ❌✅ (primary) | - | - | 0 |
158+
159+
160+
Remove more `PtrToPtr` casts in GVN [#126844](https://github.com/rust-lang/rust/pull/126844) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4bdf8d2d5877f20b54c1506a607ad8c4744cc387&end=d7c59370cea68cd17006ec3440a43254fd0eda7d&stat=instructions:u)
161+
162+
| (instructions:u) | mean | range | count |
163+
|:----------------------------------:|:-----:|:--------------:|:-----:|
164+
| Regressions ❌ <br /> (primary) | 1.3% | [0.3%, 2.9%] | 4 |
165+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
166+
| Improvements ✅ <br /> (primary) | -0.7% | [-1.1%, -0.4%] | 2 |
167+
| Improvements ✅ <br /> (secondary) | -0.3% | [-0.3%, -0.3%] | 1 |
168+
| All ❌✅ (primary) | 0.6% | [-1.1%, 2.9%] | 6 |
169+
170+
171+
Rollup of 6 pull requests [#127014](https://github.com/rust-lang/rust/pull/127014) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=536235f07e57c9108c6c3b1eacb323164e0f4cfb&end=127fa2261b730a42e6d98b7927c3888ecd08f3e0&stat=instructions:u)
172+
173+
| (instructions:u) | mean | range | count |
174+
|:----------------------------------:|:-----:|:--------------:|:-----:|
175+
| Regressions ❌ <br /> (primary) | - | - | 0 |
176+
| Regressions ❌ <br /> (secondary) | 8.2% | [8.2%, 8.2%] | 1 |
177+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
178+
| Improvements ✅ <br /> (secondary) | -2.2% | [-5.0%, -0.2%] | 13 |
179+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
180+
181+
182+
Rollup of 6 pull requests [#127076](https://github.com/rust-lang/rust/pull/127076) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=42add88d2275b95c98e512ab680436ede691e853&end=99f77a2eda555b50b518f74823ab636a20efb87f&stat=instructions:u)
183+
184+
| (instructions:u) | mean | range | count |
185+
|:----------------------------------:|:-----:|:--------------:|:-----:|
186+
| Regressions ❌ <br /> (primary) | 1.4% | [0.6%, 2.1%] | 2 |
187+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
188+
| Improvements ✅ <br /> (primary) | -1.8% | [-2.7%, -0.8%] | 2 |
189+
| Improvements ✅ <br /> (secondary) | -0.7% | [-6.2%, -0.2%] | 17 |
190+
| All ❌✅ (primary) | -0.2% | [-2.7%, 2.1%] | 4 |
191+
192+
193+
Rollup of 11 pull requests [#127096](https://github.com/rust-lang/rust/pull/127096) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9ed2ab3790ff41bf741dd690befd6a1c1e2b23ca&end=d38cd229b75a7a608e4971c46d1fb5a99343e430&stat=instructions:u)
194+
195+
| (instructions:u) | mean | range | count |
196+
|:----------------------------------:|:-----:|:--------------:|:-----:|
197+
| Regressions ❌ <br /> (primary) | 0.5% | [0.3%, 0.7%] | 7 |
198+
| Regressions ❌ <br /> (secondary) | 1.1% | [0.2%, 1.6%] | 7 |
199+
| Improvements ✅ <br /> (primary) | -3.4% | [-6.2%, -1.2%] | 12 |
200+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
201+
| All ❌✅ (primary) | -1.9% | [-6.2%, 0.7%] | 19 |
202+
203+
204+
Automatically taint InferCtxt when errors are emitted [#126996](https://github.com/rust-lang/rust/pull/126996) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f92a6c41e644d6222be77b20396daec5e77661f3&end=7b21c18fe4de32a7d2faa468e6ef69abff013f85&stat=instructions:u)
205+
206+
| (instructions:u) | mean | range | count |
207+
|:----------------------------------:|:-----:|:--------------:|:-----:|
208+
| Regressions ❌ <br /> (primary) | - | - | 0 |
209+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.4%, 0.9%] | 7 |
210+
| Improvements ✅ <br /> (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
211+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
212+
| All ❌✅ (primary) | -0.2% | [-0.2%, -0.2%] | 1 |
213+
214+
215+
Avoid MIR bloat in inlining [#127113](https://github.com/rust-lang/rust/pull/127113) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c3774be7411722d3695de2ab1da9a358d0d5c82c&end=221e2741c39515a5de6da42d8c76ee1e132c2c74&stat=instructions:u)
216+
217+
| (instructions:u) | mean | range | count |
218+
|:----------------------------------:|:-----:|:--------------:|:-----:|
219+
| Regressions ❌ <br /> (primary) | 1.1% | [0.3%, 2.8%] | 6 |
220+
| Regressions ❌ <br /> (secondary) | 1.6% | [1.5%, 1.9%] | 6 |
221+
| Improvements ✅ <br /> (primary) | -0.8% | [-2.2%, -0.2%] | 17 |
222+
| Improvements ✅ <br /> (secondary) | -1.6% | [-4.5%, -0.2%] | 18 |
223+
| All ❌✅ (primary) | -0.3% | [-2.2%, 2.8%] | 23 |
224+
225+
226+
#### Untriaged Pull Requests
227+
228+
- [#127113 Avoid MIR bloat in inlining](https://github.com/rust-lang/rust/pull/127113)
229+
- [#127096 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/127096)
230+
- [#127076 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/127076)
231+
- [#126996 Automatically taint InferCtxt when errors are emitted](https://github.com/rust-lang/rust/pull/126996)
232+
- [#126965 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/126965)
233+
- [#126951 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/126951)
234+
- [#126878 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/126878)
235+
- [#126852 Also get `add nuw` from `uN::checked_add`](https://github.com/rust-lang/rust/pull/126852)
236+
- [#126844 Remove more `PtrToPtr` casts in GVN](https://github.com/rust-lang/rust/pull/126844)
237+
- [#126813 Add `SliceLike` to `rustc_type_ir`, use it in the generic solver code (+ some other changes)](https://github.com/rust-lang/rust/pull/126813)
238+
- [#126591 [perf] More span update benchmarking](https://github.com/rust-lang/rust/pull/126591)
239+
- [#126578 Account for things that optimize out in inlining costs](https://github.com/rust-lang/rust/pull/126578)
240+
- [#126134 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/126134)
241+
- [#125968 Store the types of `ty::Expr` arguments in the `ty::Expr`](https://github.com/rust-lang/rust/pull/125968)
242+
- [#125824 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/125824)
243+
- [#125741 ast: Standardize visiting order for attributes and node IDs](https://github.com/rust-lang/rust/pull/125741)
244+
- [#125144 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/125144)
245+
- [#125120 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/125120)
246+
- [#125069 Extend SCC construction to enable extra functionality ](https://github.com/rust-lang/rust/pull/125069)
247+
- [#124700 Remove an unnecessary cast](https://github.com/rust-lang/rust/pull/124700)
248+
- [#124417 Make early lints translatable](https://github.com/rust-lang/rust/pull/124417)
249+
- [#124241 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/124241)
250+
- [#124032 Replace sort implementations](https://github.com/rust-lang/rust/pull/124032)
251+
- [#123909 Stabilize `Utf8Chunks`](https://github.com/rust-lang/rust/pull/123909)
252+
- [#123865 Update `expr` matcher for Edition 2024 and add `expr_2021` nonterminal](https://github.com/rust-lang/rust/pull/123865)
253+
- [#123812 Follow-up fixes to `report_return_mismatched_types`](https://github.com/rust-lang/rust/pull/123812)
254+
- [#123147 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/123147)
255+
- [#122976 Remove len argument from RawVec::reserve_for_push](https://github.com/rust-lang/rust/pull/122976)
256+
- [#122900 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/122900)
257+
- [#122671 Codegen const panic messages as function calls](https://github.com/rust-lang/rust/pull/122671)
258+
259+
#### Nags requiring follow up
260+
261+
TODO: Nags
262+

0 commit comments

Comments
 (0)