Skip to content

Commit 69fb50d

Browse files
committed
Add summary for this week's triage.
1 parent 127cc12 commit 69fb50d

File tree

1 file changed

+7
-2
lines changed

1 file changed

+7
-2
lines changed

triage/2024-03-11.md

Lines changed: 7 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,10 @@
11
# 2024-03-11 Triage Log
22

3-
TODO: Summary
3+
A mixed week, with a vast number of improvements (in large part due to PR
4+
#122010, which undoes a prior regression; PR #120985, a host LLVM update).
5+
But also three admittedly small-ish regressions which seemed unanticipated and
6+
were still large enough that I did not feel comfortable rubber-stamping them
7+
with a perf-regression-triaged marking.
48

59
Triage done by **@pnkfelix**.
610
Revision range: [41d97c8a..e919669d](https://perf.rust-lang.org/?start=41d97c8a5dea2731b0e56fe97cd7cb79e21cff79&end=e919669d42dfb8950866d4cb268c5359eb3f7c54&absolute=false&stat=instructions%3Au)
@@ -157,7 +161,8 @@ Rollup of 8 pull requests [#122182](https://github.com/rust-lang/rust/pull/12218
157161
* improvements obviously outweigh the regressions
158162
* ... but oh, there is also a bootstrap regression that may be of concern: "Bootstrap: 648.483s -> 652.903s (0.68%)"
159163
* kobzol has hypothesized that PR #122099 may be the cause of the bootstrap regression.
160-
* not marking as triaged for now.
164+
* after some discussion on the rollup PR, decided to mark as triaged; the author
165+
may well choose to do some followup, but we will not hound them about it. :)
161166

162167
Replace `TypeWalker` usage with `TypeVisitor` in `wf.rs` [#122150](https://github.com/rust-lang/rust/pull/122150) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=9d272a1b0501f96da0ed10caa1b2eb6dbb653686&end=b054da815501bafb24a08284151d32862f7a3a13&stat=instructions:u)
163168

0 commit comments

Comments
 (0)