Skip to content

Commit 7390310

Browse files
rylevrylev
authored
Merge pull request #1529 from pnkfelix/triage-2023-02-28
triage for this week.
2 parents 3ed6e53 + f3e2553 commit 7390310

File tree

1 file changed

+256
-0
lines changed

1 file changed

+256
-0
lines changed

‎triage/2023-02-28.md

Lines changed: 256 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,256 @@
1+
# 2023-03-01 Triage Log
2+
3+
Some noisy benchmarks impeded performance review this week. There was a notable
4+
improvement to a broad range of primary benchmarks, first from PR #108440, which
5+
revised the encodable proc macro to handle the discriminant separately from its
6+
fields, and second from PR #108375, which inlined a number of methods that had
7+
only a single caller. Both of these PR's were authored by the same contributor;
8+
many thanks Zoxc!
9+
10+
Triage done by **@pnkfelix**.
11+
Revision range: [3fee48c1..31f858d9](https://perf.rust-lang.org/?start=3fee48c161a48b0c142d3998fff56faee96bd56c&end=31f858d9a511f24fedb8ed997b28304fec809630&absolute=false&stat=instructions%3Au)
12+
13+
**Summary**:
14+
15+
| (instructions:u) | mean | range | count |
16+
|:----------------------------------:|:-----:|:---------------:|:-----:|
17+
| Regressions ❌ <br /> (primary) | 0.6% | [0.4%, 1.5%] | 16 |
18+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.3%, 0.9%] | 18 |
19+
| Improvements ✅ <br /> (primary) | -0.8% | [-17.1%, -0.3%] | 112 |
20+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.8%, -0.1%] | 50 |
21+
| All ❌✅ (primary) | -0.6% | [-17.1%, 1.5%] | 128 |
22+
23+
24+
5 Regressions, 4 Improvements, 6 Mixed; 6 of them in rollups
25+
39 artifact comparisons made in total
26+
27+
#### Regressions
28+
29+
errors: generate typed identifiers in each crate [#103042](https://github.com/rust-lang/rust/pull/103042) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3b4d6e080404560f63599deeb328dfa27fe081a6&end=b869e84e581612f4a30a4bca63bd9e90e9a17003&stat=instructions:u)
30+
31+
| (instructions:u) | mean | range | count |
32+
|:----------------------------------:|:----:|:------------:|:-----:|
33+
| Regressions ❌ <br /> (primary) | 1.1% | [1.0%, 1.2%] | 2 |
34+
| Regressions ❌ <br /> (secondary) | 2.2% | [2.0%, 2.6%] | 6 |
35+
| Improvements ✅ <br /> (primary) | - | - | 0 |
36+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
37+
| All ❌✅ (primary) | 1.1% | [1.0%, 1.2%] | 2 |
38+
39+
* already triaged, believed to be noise.
40+
41+
Rollup of 10 pull requests [#108421](https://github.com/rust-lang/rust/pull/108421) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=07c993eba8b76eae497e98433ae075b00f01be10&end=c5c7d2b37780dac1092e75f12ab97dd56c30861d&stat=instructions:u)
42+
43+
| (instructions:u) | mean | range | count |
44+
|:----------------------------------:|:----:|:------------:|:-----:|
45+
| Regressions ❌ <br /> (primary) | 0.7% | [0.3%, 1.3%] | 4 |
46+
| Regressions ❌ <br /> (secondary) | 2.2% | [2.0%, 2.6%] | 6 |
47+
| Improvements ✅ <br /> (primary) | - | - | 0 |
48+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
49+
| All ❌✅ (primary) | 0.7% | [0.3%, 1.3%] | 4 |
50+
51+
* already triaged, believed to be noise.
52+
53+
Print a backtrace when query forcing fails. [#91742](https://github.com/rust-lang/rust/pull/91742) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c5c7d2b37780dac1092e75f12ab97dd56c30861d&end=f0bc76ac41a0a832c9ee621e31aaf1f515d3d6a5&stat=instructions:u)
54+
55+
| (instructions:u) | mean | range | count |
56+
|:----------------------------------:|:----:|:------------:|:-----:|
57+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.7%] | 65 |
58+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 2.3%] | 14 |
59+
| Improvements ✅ <br /> (primary) | - | - | 0 |
60+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
61+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.7%] | 65 |
62+
63+
* The compiler team [anticipated fallout here](https://github.com/rust-lang/rust/pull/91742#issuecomment-1435790317)
64+
* the [actual fallout](https://github.com/rust-lang/rust/pull/91742#issuecomment-1444980590) seems to roughly match.
65+
* marked as triaged.
66+
67+
Rollup of 9 pull requests [#108488](https://github.com/rust-lang/rust/pull/108488) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=43ee4d15bf201f72c36abd7f02961df87dead441&end=c4e0cd966062ca67daed20775f4e8a60c28e57df&stat=instructions:u)
68+
69+
| (instructions:u) | mean | range | count |
70+
|:----------------------------------:|:----:|:------------:|:-----:|
71+
| Regressions ❌ <br /> (primary) | 1.4% | [0.8%, 2.0%] | 2 |
72+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
73+
| Improvements ✅ <br /> (primary) | - | - | 0 |
74+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
75+
| All ❌✅ (primary) | 1.4% | [0.8%, 2.0%] | 2 |
76+
77+
* two doc,full regressions: 2% on hyper, 0.76% on serde...
78+
* not worth teasing out of rollup; marked as triaged
79+
80+
MIR-Validate StorageLive. [#108175](https://github.com/rust-lang/rust/pull/108175) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=49b9cc5139dd4d11ef78dc08c1f9170de5b1ca39&end=7d782b7ff4d57170e110211565209ecc5bbb3907&stat=instructions:u)
81+
82+
| (instructions:u) | mean | range | count |
83+
|:----------------------------------:|:----:|:------------:|:-----:|
84+
| Regressions ❌ <br /> (primary) | 0.6% | [0.6%, 0.7%] | 3 |
85+
| Regressions ❌ <br /> (secondary) | 0.3% | [0.3%, 0.5%] | 4 |
86+
| Improvements ✅ <br /> (primary) | - | - | 0 |
87+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
88+
| All ❌✅ (primary) | 0.6% | [0.6%, 0.7%] | 3 |
89+
90+
* regressed helloworld check by 0.6% in three incremental scenarios.
91+
* note though that these regressions did not show up in the timer run before the PR landed.
92+
* marked as triaged.
93+
94+
#### Improvements
95+
96+
Rollup of 6 pull requests [#108357](https://github.com/rust-lang/rust/pull/108357) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fdbc4329cb781c7768ffa6d76c8fa2d032d3fe20&end=da439d98749e7c94f3ecf355fdd616253ee08359&stat=instructions:u)
97+
98+
| (instructions:u) | mean | range | count |
99+
|:----------------------------------:|:-----:|:--------------:|:-----:|
100+
| Regressions ❌ <br /> (primary) | - | - | 0 |
101+
| Regressions ❌ <br /> (secondary) | 1.8% | [1.8%, 1.8%] | 1 |
102+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
103+
| Improvements ✅ <br /> (secondary) | -2.2% | [-2.5%, -1.9%] | 6 |
104+
| All ❌✅ (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
105+
106+
107+
Use `tcx.ty_error_with_guaranteed` in more places, rename variants [#108369](https://github.com/rust-lang/rust/pull/108369) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eb909d81464900597b91f3bbf2a6bef10006c9ff&end=07c993eba8b76eae497e98433ae075b00f01be10&stat=instructions:u)
108+
109+
| (instructions:u) | mean | range | count |
110+
|:----------------------------------:|:-----:|:--------------:|:-----:|
111+
| Regressions ❌ <br /> (primary) | - | - | 0 |
112+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
113+
| Improvements ✅ <br /> (primary) | -1.1% | [-1.2%, -1.0%] | 2 |
114+
| Improvements ✅ <br /> (secondary) | -2.2% | [-2.5%, -2.0%] | 6 |
115+
| All ❌✅ (primary) | -1.1% | [-1.2%, -1.0%] | 2 |
116+
117+
118+
Emit the enum discriminant separately for the Encodable macro [#108440](https://github.com/rust-lang/rust/pull/108440) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=d962ea57899d64dc8a57040142c6b498a57c8064&end=58136ffa92c81ec9e6ac1f91773254914da2ca01&stat=instructions:u)
119+
120+
| (instructions:u) | mean | range | count |
121+
|:----------------------------------:|:-----:|:--------------:|:-----:|
122+
| Regressions ❌ <br /> (primary) | - | - | 0 |
123+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
124+
| Improvements ✅ <br /> (primary) | -0.6% | [-1.0%, -0.3%] | 91 |
125+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.9%, -0.4%] | 22 |
126+
| All ❌✅ (primary) | -0.6% | [-1.0%, -0.3%] | 91 |
127+
128+
129+
rustdoc: reduce allocations when generating tooltips [#108098](https://github.com/rust-lang/rust/pull/108098) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=fd1f1fa0d10430885478276341e4afa2e2875adb&end=5157d938c49af1248a21e7ed2fbc5c6f71963276&stat=instructions:u)
130+
131+
| (instructions:u) | mean | range | count |
132+
|:----------------------------------:|:-----:|:---------------:|:-----:|
133+
| Regressions ❌ <br /> (primary) | - | - | 0 |
134+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
135+
| Improvements ✅ <br /> (primary) | -5.1% | [-17.0%, -0.6%] | 4 |
136+
| Improvements ✅ <br /> (secondary) | -0.9% | [-0.9%, -0.9%] | 1 |
137+
| All ❌✅ (primary) | -5.1% | [-17.0%, -0.6%] | 4 |
138+
139+
140+
#### Mixed
141+
142+
Rollup of 8 pull requests [#108339](https://github.com/rust-lang/rust/pull/108339) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bd4a96a12d0bf6dc12edf20a45df3a33052c9d7d&end=3b4d6e080404560f63599deeb328dfa27fe081a6&stat=instructions:u)
143+
144+
| (instructions:u) | mean | range | count |
145+
|:----------------------------------:|:-----:|:--------------:|:-----:|
146+
| Regressions ❌ <br /> (primary) | 0.4% | [0.3%, 0.6%] | 4 |
147+
| Regressions ❌ <br /> (secondary) | 0.8% | [0.7%, 0.9%] | 6 |
148+
| Improvements ✅ <br /> (primary) | -0.8% | [-3.0%, -0.2%] | 8 |
149+
| Improvements ✅ <br /> (secondary) | -0.2% | [-0.3%, -0.2%] | 2 |
150+
| All ❌✅ (primary) | -0.4% | [-3.0%, 0.6%] | 12 |
151+
152+
153+
* seems like a wash, in terms of mix of regressions and improvements. the one outlier was the 3% improvement to opt-full on cranelift-codegen.
154+
* the primary regressions were to ripgrep opt-full (0.59%), image opt-full (0.51%), cranelift-codegen check-full (0.42%), and cranelift-codegen check-incr-full (0.27%)
155+
* I do not think its worth trying to dissect the rollup at this point though. Marking as triaged.
156+
157+
diagnostics: if AssocFn has self argument, describe as method [#108324](https://github.com/rust-lang/rust/pull/108324) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=da439d98749e7c94f3ecf355fdd616253ee08359&end=0978711950b77582e4f8f334f6e9848d48ab7790&stat=instructions:u)
158+
159+
| (instructions:u) | mean | range | count |
160+
|:----------------------------------:|:-----:|:--------------:|:-----:|
161+
| Regressions ❌ <br /> (primary) | 1.1% | [1.0%, 1.2%] | 2 |
162+
| Regressions ❌ <br /> (secondary) | 2.2% | [2.0%, 2.6%] | 6 |
163+
| Improvements ✅ <br /> (primary) | - | - | 0 |
164+
| Improvements ✅ <br /> (secondary) | -2.3% | [-2.3%, -2.3%] | 1 |
165+
| All ❌✅ (primary) | 1.1% | [1.0%, 1.2%] | 2 |
166+
167+
* already triaged as noise.
168+
169+
Update cargo [#108330](https://github.com/rust-lang/rust/pull/108330) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=0978711950b77582e4f8f334f6e9848d48ab7790&end=8b1dbf728add722d4db894b9b986ec24e1cdb0a1&stat=instructions:u)
170+
171+
| (instructions:u) | mean | range | count |
172+
|:----------------------------------:|:-----:|:--------------:|:-----:|
173+
| Regressions ❌ <br /> (primary) | - | - | 0 |
174+
| Regressions ❌ <br /> (secondary) | 2.5% | [2.5%, 2.5%] | 1 |
175+
| Improvements ✅ <br /> (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
176+
| Improvements ✅ <br /> (secondary) | -2.2% | [-2.5%, -1.9%] | 6 |
177+
| All ❌✅ (primary) | -1.0% | [-1.1%, -0.9%] | 2 |
178+
179+
* already triaged as noise
180+
181+
Rollup of 7 pull requests [#108386](https://github.com/rust-lang/rust/pull/108386) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=8b1dbf728add722d4db894b9b986ec24e1cdb0a1&end=eb909d81464900597b91f3bbf2a6bef10006c9ff&stat=instructions:u)
182+
183+
| (instructions:u) | mean | range | count |
184+
|:----------------------------------:|:-----:|:--------------:|:-----:|
185+
| Regressions ❌ <br /> (primary) | 1.0% | [0.9%, 1.1%] | 2 |
186+
| Regressions ❌ <br /> (secondary) | 2.0% | [0.4%, 2.6%] | 7 |
187+
| Improvements ✅ <br /> (primary) | - | - | 0 |
188+
| Improvements ✅ <br /> (secondary) | -2.5% | [-2.5%, -2.5%] | 1 |
189+
| All ❌✅ (primary) | 1.0% | [0.9%, 1.1%] | 2 |
190+
191+
* primary cranelift-codegen; secondary keccak, coercions, unused-warnings
192+
* seems like the same cases that were already categorized as noise by nnethercote in several other cases
193+
* marking as triaged.
194+
195+
Rollup of 7 pull requests [#108464](https://github.com/rust-lang/rust/pull/108464) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=34e6673a0473e90ef01a18eb575392c9e3859747&end=f37f9f6512cb6b295acb70938302704a80c29b2b&stat=instructions:u)
196+
197+
| (instructions:u) | mean | range | count |
198+
|:----------------------------------:|:-----:|:--------------:|:-----:|
199+
| Regressions ❌ <br /> (primary) | - | - | 0 |
200+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 1 |
201+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.9%, -0.6%] | 6 |
202+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
203+
| All ❌✅ (primary) | -0.7% | [-0.9%, -0.6%] | 6 |
204+
205+
* already triaged
206+
207+
Add inlining attributes for query system functions [#108375](https://github.com/rust-lang/rust/pull/108375) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=70fd012439d75fd6ce561a6518b9b8fd399f455f&end=43ee4d15bf201f72c36abd7f02961df87dead441&stat=instructions:u)
208+
209+
| (instructions:u) | mean | range | count |
210+
|:----------------------------------:|:-----:|:--------------:|:-----:|
211+
| Regressions ❌ <br /> (primary) | - | - | 0 |
212+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.2%, 0.7%] | 5 |
213+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.1%, -0.2%] | 38 |
214+
| Improvements ✅ <br /> (secondary) | -0.4% | [-0.7%, -0.2%] | 12 |
215+
| All ❌✅ (primary) | -0.4% | [-1.1%, -0.2%] | 38 |
216+
217+
* wins clearly outweigh losses here.
218+
* marking as triaged.
219+
220+
#### Untriaged Pull Requests
221+
222+
- [#108386 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/108386)
223+
- [#108375 Add inlining attributes for query system functions](https://github.com/rust-lang/rust/pull/108375)
224+
- [#108339 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/108339)
225+
- [#108175 MIR-Validate StorageLive.](https://github.com/rust-lang/rust/pull/108175)
226+
- [#108025 rustdoc: add more tooltips to intra-doc links](https://github.com/rust-lang/rust/pull/108025)
227+
- [#107833 Factor query arena allocation out from query caches](https://github.com/rust-lang/rust/pull/107833)
228+
- [#107783 rustdoc: simplify DOM for `.item-table`](https://github.com/rust-lang/rust/pull/107783)
229+
- [#107765 rustc/rustdoc: Perform name resolver cleanups enabled by #94857](https://github.com/rust-lang/rust/pull/107765)
230+
- [#107672 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/107672)
231+
- [#107408 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/107408)
232+
- [#107143 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/107143)
233+
- [#107103 Use new solver in `evaluate_obligation` query (when new solver is enabled)](https://github.com/rust-lang/rust/pull/107103)
234+
- [#107101 Filter param-env predicates for errors before calling `to_opt_poly_trait_pred`](https://github.com/rust-lang/rust/pull/107101)
235+
- [#106757 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/106757)
236+
- [#105657 Guard ProjectionTy creation against passing the wrong number of substs](https://github.com/rust-lang/rust/pull/105657)
237+
- [#105472 Make encode_info_for_trait_item use queries instead of accessing the HIR](https://github.com/rust-lang/rust/pull/105472)
238+
- [#105426 Catch panics/unwinding in destruction of TLS values](https://github.com/rust-lang/rust/pull/105426)
239+
- [#105378 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/105378)
240+
- [#105323 Perform SimplifyLocals before ConstProp.](https://github.com/rust-lang/rust/pull/105323)
241+
- [#105147 Allow unsafe through inline const](https://github.com/rust-lang/rust/pull/105147)
242+
- [#104566 couple of clippy::perf fixes](https://github.com/rust-lang/rust/pull/104566)
243+
- [#104533 Clean up and harden various methods around trait substs](https://github.com/rust-lang/rust/pull/104533)
244+
- [#104017 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/104017)
245+
- [#103998 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/103998)
246+
- [#103975 Some tracing and comment cleanups](https://github.com/rust-lang/rust/pull/103975)
247+
- [#103934 std: sync "Dependencies of the `backtrace` crate" with `backtrace`](https://github.com/rust-lang/rust/pull/103934)
248+
- [#103880 Use non-ascribed type as field's type in mir](https://github.com/rust-lang/rust/pull/103880)
249+
- [#103841 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/103841)
250+
- [#103650 rustdoc: change `.src-line-numbers > span` to `.src-line-numbers > a`](https://github.com/rust-lang/rust/pull/103650)
251+
- [#103562 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/103562)
252+
253+
#### Nags requiring follow up
254+
255+
TODO: Nags
256+

0 commit comments

Comments
 (0)