You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: triage/README.md
+2-9Lines changed: 2 additions & 9 deletions
Original file line number
Diff line number
Diff line change
@@ -5,7 +5,6 @@ usage.
5
5
6
6
## Roster
7
7
8
-
- ecstatic-morse
9
8
- Mark-Simulacrum
10
9
- rylev
11
10
- pnkfelix
@@ -67,13 +66,7 @@ Understanding the comparison page:
67
66
*Warning*: max rss is much more variable than instruction count. Recheck the "Absolute
68
67
data" checkbox otherwise the noise becomes unmanageable.
69
68
70
-
- A change isn't significant unless one or more of the benchmarks changed by at
71
-
least 1%.
72
-
73
-
#### Dealing with noise
74
-
75
-
Some benchmarks are noisy. Those that are known to be noisy typically have their results
76
-
labeled as such with a `?`. These results can usually be dismissed if they are below 2.5% and are not accompanied by other regressions in other benchmarks.
69
+
For help understanding how to interpret results, consult the [comparison analysis documentation](../docs/comparison-analysis.md).
77
70
78
71
## Action
79
72
@@ -91,7 +84,7 @@ Difficult cases: the merge was a rollup of multiple PRs.
91
84
- Look through the PRs and try to determine which was the cause. Often you
92
85
can easily tell that one or more PRs could not have caused the change, e.g.
93
86
because they made trivial changes, documentation-only changes, etc.
94
-
- If there are still PRs left over, look at the 'detailed-query' page on perf.rlo: often, there is a single timing pass that improved significantly, and the name may give you a hint. You can find the page by expanding the dropdown for the build with the greatest change, then clicking on the percent change. Note that this does not work for `-doc` builds.
87
+
- If there are still PRs left over, look at the 'detailed-query' page on perf.rlo: often, there is a single timing pass that improved significantly, and the name may give you a hint. You can find the page by expanding the dropdown for the build with the greatest change, then clicking on the percent change.
95
88
- If you can't narrow it down to a single PR, in the rollup PR ask all the
96
89
authors who might be responsible.
97
90
- Once you have narrowed it down to a single PR, treat it like an easy case,
0 commit comments