Skip to content

Commit 9dee921

Browse files
rylevrylev
authored
Merge pull request #1355 from Mark-Simulacrum/triage
Add triage report for 2022-07-12
2 parents 4b1dbfc + 337853c commit 9dee921

File tree

1 file changed

+183
-0
lines changed

1 file changed

+183
-0
lines changed

‎triage/2022-07-12.md

Lines changed: 183 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,183 @@
1+
# 2022-07-12 Triage Log
2+
3+
A fairly noisy week (many entries below dropped and untagged as regressions),
4+
largely driven by tt-muncher and html5ever. Our sensitivity assessment currently
5+
takes roughly a week since new noise starts to learn the noise level, so it can
6+
take some time for oscillations to stop reporting somewhat spurious results.
7+
8+
Otherwise, this week had a number of solid improvements, and was overall
9+
positive, with improvements across many benchmarks.
10+
11+
Triage done by **@simulacrum**.
12+
Revision range: [880646ca9c6dc21e04efe2f1940369a45b71ff2d..b3f4c3119957aa0a250cab08ab586b7a9a680ef1](https://perf.rust-lang.org/?start=880646ca9c6dc21e04efe2f1940369a45b71ff2d&end=b3f4c3119957aa0a250cab08ab586b7a9a680ef1&absolute=false&stat=instructions%3Au)
13+
14+
**Summary**:
15+
16+
| | mean | max | count |
17+
|:----------:|:----:|:---:|:-----:|
18+
| Regressions 😿 <br /> (primary) | 0.7% | 1.4% | 19 |
19+
| Regressions 😿 <br /> (secondary) | 2.1% | 5.3% | 13 |
20+
| Improvements 🎉 <br /> (primary) | -1.1% | -2.5% | 153 |
21+
| Improvements 🎉 <br /> (secondary) | -2.1% | -9.9% | 121 |
22+
| All 😿🎉 (primary) | -0.9% | -2.5% | 172 |
23+
24+
25+
3 Regressions, 6 Improvements, 3 Mixed; 3 of them in rollups
26+
53 artifact comparisons made in total
27+
28+
#### Regressions
29+
30+
Make lowering a query [#95573](https://github.com/rust-lang/rust/pull/95573)
31+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3e51277fe638dc0c8ceb6d1d3acc5aa247277c29&end=0f573a0c5474ad65bc9f0b0fd3a94d1b06dcfdfa&stat=instructions:u)
32+
33+
| | mean | max | count |
34+
|:----------:|:----:|:---:|:-----:|
35+
| Regressions 😿 <br /> (primary) | 0.5% | 1.1% | 76 |
36+
| Regressions 😿 <br /> (secondary) | 0.8% | 2.4% | 57 |
37+
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
38+
| Improvements 🎉 <br /> (secondary) | -0.2% | -0.2% | 1 |
39+
| All 😿🎉 (primary) | 0.5% | 1.1% | 76 |
40+
41+
These results may partially be noise, and are overall limited enough in impact
42+
that further investigation is not warranted at this time. Marked as triaged.
43+
44+
Rollup of 6 pull requests [#99047](https://github.com/rust-lang/rust/pull/99047)
45+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=eba361ae36be41e42fb8fdf138455307e0ad407c&end=0f97e02bdc7a53176aa96a53ff8b533947d7649c&stat=instructions:u)
46+
47+
| | mean | max | count |
48+
|:----------:|:----:|:---:|:-----:|
49+
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
50+
| Regressions 😿 <br /> (secondary) | 1.9% | 4.0% | 13 |
51+
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
52+
| Improvements 🎉 <br /> (secondary) | N/A | N/A | 0 |
53+
| All 😿🎉 (primary) | N/A | N/A | 0 |
54+
55+
Looks to be a genuine regression, far exceeding the noise bound for the
56+
[deeply-nested-multi benchmark][noise-graph-99047]. (This is the 4% spike on
57+
that graph). Maybe caused by #98795, needs a little further investigation.
58+
59+
[noise-graph-99047]: https://perf.rust-lang.org/index.html?start=2022-06-08&end=2022-07-12&benchmark=deeply-nested-multi&profile=check&scenario=full&stat=instructions:u&kind=percentrelative
60+
61+
Enforce that layout size fits in isize in Layout [#95295](https://github.com/rust-lang/rust/pull/95295)
62+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=95e77648e466c780a9adce2fa3d3eb5e423dc04e&end=4ec97d991b1bd86dc89fee761d79ac8e85239a08&stat=instructions:u)
63+
64+
| | mean | max | count |
65+
|:----------:|:----:|:---:|:-----:|
66+
| Regressions 😿 <br /> (primary) | 0.5% | 1.5% | 106 |
67+
| Regressions 😿 <br /> (secondary) | 0.6% | 1.7% | 39 |
68+
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
69+
| Improvements 🎉 <br /> (secondary) | -1.3% | -1.5% | 6 |
70+
| All 😿🎉 (primary) | 0.5% | 1.5% | 106 |
71+
72+
As noted on the PR (thanks for triaging perf regressions!), this is a limited
73+
in magnitude and a justified regression for a soundness fix. See
74+
this [comment](https://github.com/rust-lang/rust/pull/95295#issuecomment-1179744091) for details.
75+
76+
#### Improvements
77+
78+
continue nll transition by removing stuff [#98584](https://github.com/rust-lang/rust/pull/98584)
79+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=54f79babae06d3772c067f696e5b12db822ae25f&end=efb171e2350de2bec6dd1f035b99bc00535c1c15&stat=instructions:u)
80+
81+
| | mean | max | count |
82+
|:----------:|:----:|:---:|:-----:|
83+
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
84+
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
85+
| Improvements 🎉 <br /> (primary) | -1.0% | -2.3% | 66 |
86+
| Improvements 🎉 <br /> (secondary) | -1.2% | -3.6% | 63 |
87+
| All 😿🎉 (primary) | -1.0% | -2.3% | 66 |
88+
89+
90+
interpret: remove support for unsized_locals [#98831](https://github.com/rust-lang/rust/pull/98831)
91+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7665c3543079ebc3710b676d0fd6951bedfd4b29&end=8824d131619e58a38bde8bcf56401629b91a204a&stat=instructions:u)
92+
93+
| | mean | max | count |
94+
|:----------:|:----:|:---:|:-----:|
95+
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
96+
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
97+
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
98+
| Improvements 🎉 <br /> (secondary) | -0.6% | -0.8% | 11 |
99+
| All 😿🎉 (primary) | N/A | N/A | 0 |
100+
101+
Use a bitset instead of a hash map in HIR ID validator [#98841](https://github.com/rust-lang/rust/pull/98841)
102+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=e78e747f53c36e53ff99c94438d2efa26830fc4b&end=c461f7a16e8372216dbf7a54ab86ee958bec83b5&stat=instructions:u)
103+
104+
| | mean | max | count |
105+
|:----------:|:----:|:---:|:-----:|
106+
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
107+
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
108+
| Improvements 🎉 <br /> (primary) | -0.8% | -1.7% | 123 |
109+
| Improvements 🎉 <br /> (secondary) | -0.8% | -2.0% | 82 |
110+
| All 😿🎉 (primary) | -0.8% | -1.7% | 123 |
111+
112+
don't use `commit_if_ok` during `higher_ranked_sub` [#99056](https://github.com/rust-lang/rust/pull/99056)
113+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f893495e3da91dc319d37861b803eed9d6c8c7c7&end=6dba4ed215e7a60f0a2a19c04f3f73691f89c509&stat=instructions:u)
114+
115+
| | mean | max | count |
116+
|:----------:|:----:|:---:|:-----:|
117+
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
118+
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
119+
| Improvements 🎉 <br /> (primary) | -0.7% | -0.7% | 7 |
120+
| Improvements 🎉 <br /> (secondary) | -0.8% | -0.9% | 6 |
121+
| All 😿🎉 (primary) | -0.7% | -0.7% | 7 |
122+
123+
More derive output improvements [#98758](https://github.com/rust-lang/rust/pull/98758)
124+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1dcff2d5077244f49687ea25070958f23bd9edc6&end=fbdb07f4e7f4666085aec4b1ed2fd05817dc42cf&stat=instructions:u)
125+
126+
| | mean | max | count |
127+
|:----------:|:----:|:---:|:-----:|
128+
| Regressions 😿 <br /> (primary) | 0.6% | 0.8% | 2 |
129+
| Regressions 😿 <br /> (secondary) | 1.6% | 2.3% | 10 |
130+
| Improvements 🎉 <br /> (primary) | -0.4% | -0.6% | 55 |
131+
| Improvements 🎉 <br /> (secondary) | -2.1% | -8.0% | 34 |
132+
| All 😿🎉 (primary) | -0.4% | 0.8% | 57 |
133+
134+
Regressions appear primarily in tt-muncher and are spurious noise; cargo and
135+
image also show slight regressions but much smaller in comparative magnitude.
136+
Overall a small, but solid improvement.
137+
138+
Miscellaneous inlining improvements [#99028](https://github.com/rust-lang/rust/pull/99028)
139+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=db78ab70a88a0a5e89031d7ee4eccec835dcdbde&end=86b8dd5389cd9d545418a60902222a4ba859365f&stat=instructions:u)
140+
141+
| | mean | max | count |
142+
|:----------:|:----:|:---:|:-----:|
143+
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
144+
| Regressions 😿 <br /> (secondary) | 0.7% | 1.4% | 13 |
145+
| Improvements 🎉 <br /> (primary) | -0.4% | -0.9% | 124 |
146+
| Improvements 🎉 <br /> (secondary) | -0.5% | -1.0% | 62 |
147+
| All 😿🎉 (primary) | -0.4% | -0.9% | 124 |
148+
149+
#### Mixed
150+
151+
Rollup of 7 pull requests [#98987](https://github.com/rust-lang/rust/pull/98987)
152+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=3dcb616888aac50d55160b025266d555dad937d9&end=7665c3543079ebc3710b676d0fd6951bedfd4b29&stat=instructions:u)
153+
154+
| | mean | max | count |
155+
|:----------:|:----:|:---:|:-----:|
156+
| Regressions 😿 <br /> (primary) | 0.6% | 0.6% | 1 |
157+
| Regressions 😿 <br /> (secondary) | N/A | N/A | 0 |
158+
| Improvements 🎉 <br /> (primary) | -0.2% | -0.2% | 1 |
159+
| Improvements 🎉 <br /> (secondary) | -0.3% | -0.6% | 9 |
160+
| All 😿🎉 (primary) | 0.2% | 0.6% | 2 |
161+
162+
163+
Rollup of 8 pull requests [#99014](https://github.com/rust-lang/rust/pull/99014)
164+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=20dd6930134d07a5ef90393a040a1594ac8d714c&end=3e51277fe638dc0c8ceb6d1d3acc5aa247277c29&stat=instructions:u)
165+
166+
| | mean | max | count |
167+
|:----------:|:----:|:---:|:-----:|
168+
| Regressions 😿 <br /> (primary) | 0.5% | 0.5% | 1 |
169+
| Regressions 😿 <br /> (secondary) | 0.3% | 0.3% | 1 |
170+
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
171+
| Improvements 🎉 <br /> (secondary) | -1.3% | -1.5% | 6 |
172+
| All 😿🎉 (primary) | 0.5% | 0.5% | 1 |
173+
174+
Don't allow ZST in ScalarInt [#98957](https://github.com/rust-lang/rust/pull/98957)
175+
[(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6c20ab744b0f82646d90ce9d25894823abc9c669&end=f893495e3da91dc319d37861b803eed9d6c8c7c7&stat=instructions:u)
176+
177+
| | mean | max | count |
178+
|:----------:|:----:|:---:|:-----:|
179+
| Regressions 😿 <br /> (primary) | N/A | N/A | 0 |
180+
| Regressions 😿 <br /> (secondary) | 4.4% | 4.4% | 2 |
181+
| Improvements 🎉 <br /> (primary) | N/A | N/A | 0 |
182+
| Improvements 🎉 <br /> (secondary) | -0.4% | -0.4% | 2 |
183+
| All 😿🎉 (primary) | N/A | N/A | 0 |

0 commit comments

Comments
 (0)