finish report

Author: Mark-Simulacrum

triage/2021-01-26.md

@@ -1,19 +1,27 @@
-2021-01-26 Triage Log
+# 2021-01-26 Triage Log
 
-TODO: Summary
+This week continues a trend of relatively large rollups, which often contain
+perf-sensitive PRs. We need to get better at marking PRs as rollup=never or
+otherwise not including them, but it is unclear how precisely to go about doing
+so. The tooling for testing individual PRs merged in rollups should also be
+improved to work better in the next few days, though.
 
-Triage done by **@rylevick**.
+Other than that, this week saw several regressions, most of which were not
+easily explained. We are seeking feedback from PR authors and reviewers on
+whether the results are expected and if anything can be done.
+
+Triage done by **@rylevick** and **@simulacrum**.
 Revision range: [e05409a02c6e73a3dea6da98798468db2910ca59..1483e67addd37d9bd20ba3b4613b678ee9ad4d68](https://perf.rust-lang.org/?start=e05409a02c6e73a3dea6da98798468db2910ca59&end=1483e67addd37d9bd20ba3b4613b678ee9ad4d68&absolute=false&stat=instructions%3Au)
 
-5 Regressions, 2 Improvements, 2 Mixed
-??? of them in rollups
+5 Regressions, 2 Improvements, 1 Mixed;
+3 of them in rollups
 
 #### Regressions
 
 Deprecate-in-future the constants superceded by RFC 2700 [#80958](https://github.com/rust-lang/rust/issues/80958)
 - Small regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=57a71ac0e17e4f7070b090ab7bdc5474d8e37ecc&end=339e19697a39a78f4d669c217b7d21109215de41&stat=instructions:u) (up to 2.4% on `incr-patched: Job` builds of `regex-check`)
-- Unsure why this might be causing performance regressions as this change does not touch much code and only produces lint warnings when the user opts into them. 
-- The author of the PR [was asked why this might be the case](https://github.com/rust-lang/rust/pull/80958#issuecomment-767837811).
+- Unsure why this might be causing performance regressions as this change does not touch much code and only produces lint warnings when the user opts into them.
+- The author of the PR [was asked why this might be the case](https://github.com/rust-lang/rust/pull/80958#issuecomment-767837811), and a nag noted.
 
 Rollup of 11 pull requests [#81240](https://github.com/rust-lang/rust/issues/81240)
 - Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=339e19697a39a78f4d669c217b7d21109215de41&end=a243ad280a4ac57c1b8427e30e31c5b505cf10de&stat=instructions:u) (up to 2.0% on `full` builds of `keccak-check`)
@@ -29,6 +37,7 @@ Rollup of 14 pull requests [#81355](https://github.com/rust-lang/rust/issues/813
 Prevent query cycles in the MIR inliner [#68828](https://github.com/rust-lang/rust/issues/68828)
 - Moderate regression in [instruction counts](https://perf.rust-lang.org/compare.html?start=7fba12bb1d3877870758a7a53e2fe766bb19bd60&end=f4eb5d9f719cd3c849befc8914ad8ce0ddcf34ed&stat=instructions:u) (up to 2.1% on `full` builds of `keccak-check`)
 - Moderate improvement in [instruction counts](https://perf.rust-lang.org/compare.html?start=7fba12bb1d3877870758a7a53e2fe766bb19bd60&end=f4eb5d9f719cd3c849befc8914ad8ce0ddcf34ed&stat=instructions:u) (up to -1.8% on `full` builds of `ctfe-stress-4-check`)
+- Nag filed
 
 #### Improvements
 
@@ -46,6 +55,6 @@ mark raw_vec::ptr with inline [#79113](https://github.com/rust-lang/rust/issues/
 
 #### Nags requiring follow up
 
-TODO: Nags
-
-
+- Deprecate in future regression [#80958](https://github.com/rust-lang/rust/pull/80958#issuecomment-767837811)
+- Waiting on [response](https://github.com/rust-lang/rust/pull/80919#issuecomment-767854932) to inquiry.
+- Regression in prevent query cycles in the MIR inliner - expected? [#68828](https://github.com/rust-lang/rust/pull/68828#issuecomment-767872361)