Skip to content

Commit ac6559f

Browse files
Mark-SimulacrumMark-Simulacrum
authored
Merge pull request #1473 from Mark-Simulacrum/triage
Add triage for this week
2 parents baa4ce2 + 260422f commit ac6559f

File tree

1 file changed

+145
-0
lines changed

1 file changed

+145
-0
lines changed

‎triage/2022-10-18.md

Lines changed: 145 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,145 @@
1+
# 2022-10-18 Triage Log
2+
3+
Overall a fairly busy week, with many improvements and regressions, though the
4+
net result ends up being a small regression. Pretty busy week in terms of
5+
regressions in rollups as well, which unfortunately mostly were not followed up
6+
on prior to the report being put together, despite the relative ease of running
7+
perf against individual PRs now.
8+
9+
Triage done by **@simulacrum**.
10+
Revision range: [1e926f06528ecb2503f026e2fd53cb735d487b10..e0f8e60dddfecfc9093ee9d9f42557d8260c0355](https://perf.rust-lang.org/?start=1e926f06528ecb2503f026e2fd53cb735d487b10&end=e0f8e60dddfecfc9093ee9d9f42557d8260c0355&absolute=false&stat=instructions%3Au)
11+
12+
**Summary**:
13+
14+
| (instructions:u) | mean | range | count |
15+
|:----------------:|:----:|:-----:|:-----:|
16+
| Regressions ❌ <br /> (primary) | 1.7% | [0.2%, 6.3%] | 46 |
17+
| Regressions ❌ <br /> (secondary) | 1.6% | [0.3%, 5.4%] | 46 |
18+
| Improvements ✅ <br /> (primary) | -0.6% | [-2.3%, -0.2%] | 45 |
19+
| Improvements ✅ <br /> (secondary) | -2.0% | [-9.2%, -0.2%] | 32 |
20+
| All ❌✅ (primary) | 0.6% | [-2.3%, 6.3%] | 91 |
21+
22+
2 Regressions, 4 Improvements, 4 Mixed; 4 of them in rollups
23+
47 artifact comparisons made in total
24+
25+
#### Regressions
26+
27+
Populate effective visibilities in 'rustc_resolve' [#102026](https://github.com/rust-lang/rust/pull/102026) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=bf286a82e236e065c67909657e3a35d1511d1864&end=b8b5caee04116c7383eb1c6470fcf15c437a60d4&stat=instructions:u)
28+
29+
| (instructions:u) | mean | range | count |
30+
|:----------------:|:----:|:-----:|:-----:|
31+
| Regressions ❌ <br /> (primary) | 1.1% | [0.2%, 5.6%] | 65 |
32+
| Regressions ❌ <br /> (secondary) | 0.9% | [0.2%, 3.7%] | 32 |
33+
| Improvements ✅ <br /> (primary) | - | - | 0 |
34+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
35+
| All ❌✅ (primary) | 1.1% | [0.2%, 5.6%] | 65 |
36+
37+
The compiler is doing more work after this PR, but haven't yet narrowed in on a
38+
fix or exact cause for the regression. @petrochenkov expects that we probably
39+
ought to be able to reduce the impact.
40+
41+
Rollup of 7 pull requests [#102915](https://github.com/rust-lang/rust/pull/102915) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=1e926f06528ecb2503f026e2fd53cb735d487b10&end=bb93450ec4af83c20e9ba6c8e575aca55423001a&stat=instructions:u)
42+
43+
| (instructions:u) | mean | range | count |
44+
|:----------------:|:----:|:-----:|:-----:|
45+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.1%] | 12 |
46+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
47+
| Improvements ✅ <br /> (primary) | -0.7% | [-0.9%, -0.6%] | 6 |
48+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
49+
| All ❌✅ (primary) | 0.2% | [-0.9%, 1.1%] | 18 |
50+
51+
The improvements here are in diesel, which is noise; the regressions look
52+
plausibly real. Queued an additional perf run for further investigation.
53+
54+
#### Improvements
55+
56+
Rollup of 11 pull requests [#102926](https://github.com/rust-lang/rust/pull/102926) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=cde693cf962f0f606e33eb21242f6bcd2d8d8b7a&end=db0597f5619d5ed93feca28e61226d3581cc7867&stat=instructions:u)
57+
58+
| (instructions:u) | mean | range | count |
59+
|:----------------:|:----:|:-----:|:-----:|
60+
| Regressions ❌ <br /> (primary) | - | - | 0 |
61+
| Regressions ❌ <br /> (secondary) | 0.2% | [0.2%, 0.2%] | 1 |
62+
| Improvements ✅ <br /> (primary) | -0.4% | [-1.0%, -0.2%] | 20 |
63+
| Improvements ✅ <br /> (secondary) | -0.5% | [-0.6%, -0.3%] | 7 |
64+
| All ❌✅ (primary) | -0.4% | [-1.0%, -0.2%] | 20 |
65+
66+
This may not be as much of an improvement as it looks; the diesel-related
67+
changes are all spurious (we are seeing an uptick in noise there).
68+
69+
Remove `TokenStreamBuilder` [#102692](https://github.com/rust-lang/rust/pull/102692) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=7e8d64e792543fedb8574ac0a27522dbab66aa52&end=2b91cbe2d4ce90d30520674876e9d700cf7a561b&stat=instructions:u)
70+
71+
| (instructions:u) | mean | range | count |
72+
|:----------------:|:----:|:-----:|:-----:|
73+
| Regressions ❌ <br /> (primary) | - | - | 0 |
74+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
75+
| Improvements ✅ <br /> (primary) | -0.5% | [-0.6%, -0.3%] | 4 |
76+
| Improvements ✅ <br /> (secondary) | -4.1% | [-9.5%, -1.2%] | 9 |
77+
| All ❌✅ (primary) | -0.5% | [-0.6%, -0.3%] | 4 |
78+
79+
remove type traversal for mir constants [#102355](https://github.com/rust-lang/rust/pull/102355) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=abd77441010d74430be5c34a2e62002e578fa165&end=a9d1cafa878ecc04a4aa7aaa7df0414a29a2bd0b&stat=instructions:u)
80+
81+
| (instructions:u) | mean | range | count |
82+
|:----------------:|:----:|:-----:|:-----:|
83+
| Regressions ❌ <br /> (primary) | - | - | 0 |
84+
| Regressions ❌ <br /> (secondary) | - | - | 0 |
85+
| Improvements ✅ <br /> (primary) | -0.4% | [-0.8%, -0.2%] | 36 |
86+
| Improvements ✅ <br /> (secondary) | -1.3% | [-3.7%, -0.2%] | 37 |
87+
| All ❌✅ (primary) | -0.4% | [-0.8%, -0.2%] | 36 |
88+
89+
Rollup of 7 pull requests [#103026](https://github.com/rust-lang/rust/pull/103026) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=60bd3f96779dbe6bd206dae09395e9af7d580552&end=edabf59ca4646b3fc1a961c26431215001043f6a&stat=instructions:u)
90+
91+
| (instructions:u) | mean | range | count |
92+
|:----------------:|:----:|:-----:|:-----:|
93+
| Regressions ❌ <br /> (primary) | 0.9% | [0.7%, 1.1%] | 6 |
94+
| Regressions ❌ <br /> (secondary) | 0.4% | [0.4%, 0.4%] | 1 |
95+
| Improvements ✅ <br /> (primary) | - | - | 0 |
96+
| Improvements ✅ <br /> (secondary) | -0.5% | [-1.5%, -0.3%] | 7 |
97+
| All ❌✅ (primary) | 0.9% | [0.7%, 1.1%] | 6 |
98+
99+
Regressions are essentially all in diesel, which are spurious.
100+
101+
#### Mixed
102+
103+
104+
Rollup of 7 pull requests [#102975](https://github.com/rust-lang/rust/pull/102975) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=538f118da1409759ba198acc0ff62070bc6d2dce&end=c0983a9aac889d16722a12602ac678051e62c3fb&stat=instructions:u)
105+
106+
| (instructions:u) | mean | range | count |
107+
|:----------------:|:----:|:-----:|:-----:|
108+
| Regressions ❌ <br /> (primary) | 0.6% | [0.2%, 1.0%] | 19 |
109+
| Regressions ❌ <br /> (secondary) | 1.3% | [0.2%, 3.8%] | 41 |
110+
| Improvements ✅ <br /> (primary) | -0.9% | [-1.7%, -0.4%] | 14 |
111+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
112+
| All ❌✅ (primary) | -0.0% | [-1.7%, 1.0%] | 33 |
113+
114+
115+
Check hidden types in dead code [#102700](https://github.com/rust-lang/rust/pull/102700) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=6b3ede3f7bc502eba7bbd202b4b9312d812adcd7&end=60bd3f96779dbe6bd206dae09395e9af7d580552&stat=instructions:u)
116+
117+
| (instructions:u) | mean | range | count |
118+
|:----------------:|:----:|:-----:|:-----:|
119+
| Regressions ❌ <br /> (primary) | - | - | 0 |
120+
| Regressions ❌ <br /> (secondary) | 1.2% | [1.0%, 1.3%] | 4 |
121+
| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.2%] | 13 |
122+
| Improvements ✅ <br /> (secondary) | -0.6% | [-0.7%, -0.5%] | 4 |
123+
| All ❌✅ (primary) | -0.3% | [-0.4%, -0.2%] | 13 |
124+
125+
126+
Get rid of `rustc_query_description!` [#102895](https://github.com/rust-lang/rust/pull/102895) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=c93ef33700e4e4f84fd85690df71b14c1d2b0aa3&end=b8c35ca26b191bb9a9ac669a4b3f4d3d52d97fb1&stat=instructions:u)
127+
128+
| (instructions:u) | mean | range | count |
129+
|:----------------:|:----:|:-----:|:-----:|
130+
| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.5%] | 9 |
131+
| Regressions ❌ <br /> (secondary) | 0.6% | [0.3%, 0.8%] | 5 |
132+
| Improvements ✅ <br /> (primary) | - | - | 0 |
133+
| Improvements ✅ <br /> (secondary) | -0.7% | [-1.2%, -0.2%] | 6 |
134+
| All ❌✅ (primary) | 0.3% | [0.2%, 0.5%] | 9 |
135+
136+
137+
Make `overlapping_impls` not generic [#102931](https://github.com/rust-lang/rust/pull/102931) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=ddc7fd983736bef0e610e02f5ef08955ecd562bb&end=75dbd5b8c3e3e3e7673caa890422e654d39b815e&stat=instructions:u)
138+
139+
| (instructions:u) | mean | range | count |
140+
|:----------------:|:----:|:-----:|:-----:|
141+
| Regressions ❌ <br /> (primary) | - | - | 0 |
142+
| Regressions ❌ <br /> (secondary) | 0.5% | [0.5%, 0.5%] | 2 |
143+
| Improvements ✅ <br /> (primary) | -1.6% | [-2.3%, -1.1%] | 7 |
144+
| Improvements ✅ <br /> (secondary) | - | - | 0 |
145+
| All ❌✅ (primary) | -1.6% | [-2.3%, -1.1%] | 7 |

0 commit comments

Comments
 (0)