Skip to content

Commit b231273

Browse files
committed
Add No results/regressions/improvements labels when there is no data
1 parent e8295df commit b231273

File tree

1 file changed

+20
-7
lines changed

1 file changed

+20
-7
lines changed

site/static/compare/script.js

Lines changed: 20 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -445,7 +445,10 @@ app.component('summary-table', {
445445
}
446446
},
447447
template: `
448-
<table class="summary-table">
448+
<div v-if="summary.all.count === 0" style="flex-grow: 1; display: flex; flex-direction: column; justify-content: center;">
449+
<span>No results</span>
450+
</div>
451+
<table v-else class="summary-table">
449452
<thead v-if="withLegend">
450453
<th><!-- icon --></th>
451454
<th>Range</th>
@@ -455,15 +458,25 @@ app.component('summary-table', {
455458
<tbody>
456459
<tr class="positive">
457460
<td title="Regressions" v-if="withLegend">❌</td>
458-
<td><SummaryRange :range="summary.regressions.range" /></td>
459-
<td><SummaryPercentValue :value="summary.regressions.average" /></td>
460-
<td><SummaryCount :cases="summary.regressions.count" :benchmarks="summary.regressions.benchmarks" /></td>
461+
<template v-if="summary.regressions.count !== 0">
462+
<td><SummaryRange :range="summary.regressions.range" /></td>
463+
<td><SummaryPercentValue :value="summary.regressions.average" /></td>
464+
<td><SummaryCount :cases="summary.regressions.count" :benchmarks="summary.regressions.benchmarks" /></td>
465+
</template>
466+
<template v-else>
467+
<td colspan="3" style="text-align: center;">No regressions</td>
468+
</template>
461469
</tr>
462470
<tr class="negative">
463471
<td title="Improvements" v-if="withLegend">✅</td>
464-
<td><SummaryRange :range="summary.improvements.range" /></td>
465-
<td><SummaryPercentValue :value="summary.improvements.average" /></td>
466-
<td><SummaryCount :cases="summary.improvements.count" :benchmarks="summary.improvements.benchmarks" /></td>
472+
<template v-if="summary.improvements.count !== 0">
473+
<td><SummaryRange :range="summary.improvements.range" /></td>
474+
<td><SummaryPercentValue :value="summary.improvements.average" /></td>
475+
<td><SummaryCount :cases="summary.improvements.count" :benchmarks="summary.improvements.benchmarks" /></td>
476+
</template>
477+
<template v-else>
478+
<td colspan="3" style="text-align: center;">No improvements</td>
479+
</template>
467480
</tr>
468481
<tr>
469482
<td title="All changes" v-if="withLegend">❌,✅</td>

0 commit comments

Comments
 (0)