Load artifact sizes from the DB in the /get endpoint

Author: Kobzol

database/src/pool.rs

@@ -91,6 +91,9 @@ pub trait Connection: Send + Sync {
     /// bytes.
     async fn record_artifact_size(&self, artifact: ArtifactIdNumber, component: &str, size: u64);
 
+    /// Returns the sizes of individual components of a single artifact.
+    async fn get_artifact_size(&self, aid: ArtifactIdNumber) -> HashMap<String, u64>;
+
     /// Returns vector of bootstrap build times for the given artifacts. The kth
     /// element is the minimum build time for the kth artifact in `aids`, across
     /// all collections for the artifact, or none if there is no bootstrap data

database/src/pool/postgres.rs

@@ -337,6 +337,7 @@ pub struct CachedStatements {
     insert_runtime_pstat: Statement,
     get_runtime_pstat: Statement,
     record_artifact_size: Statement,
+    get_artifact_size: Statement,
 }
 
 pub struct PostgresTransaction<'a> {
@@ -530,6 +531,10 @@ impl PostgresConnection {
                     do update
                     set size = excluded.size
                 ").await.unwrap(),
+                get_artifact_size: conn.prepare("
+                    select component, size from artifact_size
+                    where aid = $1
+                ").await.unwrap()
             }),
             conn,
         }
@@ -930,6 +935,18 @@ where
             .unwrap();
     }
 
+    async fn get_artifact_size(&self, aid: ArtifactIdNumber) -> HashMap<String, u64> {
+        let rows = self
+            .conn()
+            .query(&self.statements().get_artifact_size, &[&aid.0])
+            .await
+            .unwrap();
+
+        rows.into_iter()
+            .map(|row| (row.get::<_, String>(0), row.get::<_, u32>(1) as u64))
+            .collect()
+    }
+
     async fn artifact_id(&self, artifact: &ArtifactId) -> ArtifactIdNumber {
         let (name, date, ty) = match artifact {
             ArtifactId::Commit(commit) => (

database/src/pool/sqlite.rs

@@ -812,6 +812,18 @@ impl Connection for SqliteConnection {
             .unwrap();
     }
 
+    async fn get_artifact_size(&self, aid: ArtifactIdNumber) -> HashMap<String, u64> {
+        self.raw_ref()
+            .prepare("select component, size from artifact_size where aid = ?")
+            .unwrap()
+            .query_map(params![&aid.0], |row| {
+                Ok((row.get::<_, String>(0)?, row.get::<_, u64>(1)?))
+            })
+            .unwrap()
+            .map(|r| r.unwrap())
+            .collect()
+    }
+
     async fn get_bootstrap(&self, aids: &[ArtifactIdNumber]) -> Vec<Option<Duration>> {
         aids.iter()
             .map(|aid| {

site/frontend/src/pages/compare/types.ts

@@ -22,6 +22,7 @@ export interface ArtifactDescription {
   pr: number | null;
   bootstrap: Dict<number>;
   bootstrap_total: number;
+  component_sizes: Dict<number>;
 }
 
 export interface StatComparison {

site/src/api.rs

@@ -187,6 +187,7 @@ pub mod comparison {
         pub pr: Option<u32>,
         pub bootstrap: HashMap<String, u64>,
         pub bootstrap_total: u64,
+        pub component_sizes: HashMap<String, u64>,
     }
 
     #[derive(Debug, Clone, Serialize)]

site/src/comparison.rs

@@ -925,6 +925,7 @@ pub struct ArtifactDescription {
     /// Bootstrap data in the form "$crate" -> nanoseconds
     pub bootstrap: HashMap<String, u64>,
     pub bootstrap_total: u64,
+    pub component_sizes: HashMap<String, u64>,
 }
 
 type StatisticsMap<TestCase> = HashMap<TestCase, f64>;
@@ -939,9 +940,8 @@ impl ArtifactDescription {
         artifact: ArtifactId,
         master_commits: &[collector::MasterCommit],
     ) -> Self {
-        let bootstrap = conn
-            .get_bootstrap_by_crate(&[conn.artifact_id(&artifact).await])
-            .await;
+        let aid = conn.artifact_id(&artifact).await;
+        let bootstrap = conn.get_bootstrap_by_crate(&[aid]).await;
         let bootstrap_total = bootstrap
             .values()
             .filter_map(|v| {
@@ -979,11 +979,14 @@ impl ArtifactDescription {
             None
         };
 
+        let component_sizes = conn.get_artifact_size(aid).await.into_iter().collect();
+
         Self {
             pr,
             artifact,
             bootstrap,
             bootstrap_total,
+            component_sizes,
         }
     }
 }
@@ -1023,6 +1026,7 @@ impl From<ArtifactDescription> for api::comparison::ArtifactDescription {
             pr: data.pr,
             bootstrap: data.bootstrap,
             bootstrap_total: data.bootstrap_total,
+            component_sizes: data.component_sizes,
         }
     }
 }