Skip to content

Commit b7fe200

Browse files
Finish removal of script-servo by polishing CI
1 parent ad354f4 commit b7fe200

File tree

3 files changed

+3
-6
lines changed

3 files changed

+3
-6
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -37,9 +37,8 @@ jobs:
3737
strategy:
3838
matrix:
3939
BENCH_INCLUDE_EXCLUDE_OPTS: [
40-
"--exclude script-servo,webrender-wrench,style-servo,cargo",
40+
"--exclude webrender-wrench,style-servo,cargo",
4141
"--include webrender-wrench,style-servo,cargo",
42-
"--include script-servo",
4342
]
4443
BUILD_KINDS: [
4544
"Check,Doc,Debug",

collector/benchmarks/README.md

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -24,9 +24,6 @@ These are real programs that are important in some way, and worth tracking.
2424
- **piston-image**: A modular game engine. An interesting Rust program.
2525
- **regex**: A regular expression parser. Used by many Rust programs.
2626
- **ripgrep**: A line-oriented search tool. A widely-used utility.
27-
- **script-servo-2**: Servo's `script` crate. A particularly large crate. At
28-
5ad7e5b4fbd58, with [PR#27063](https://github.com/servo/servo/pull/27063)
29-
applied atop.
3027
- **serde**: A serialization/deserialization crate. Used by many other
3128
Rust programs.
3229
- **style-servo**: Servo's `style` crate. A large crate, and one used by

collector/src/execute.rs

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1032,7 +1032,8 @@ impl Benchmark {
10321032
// configuration, script-servo-2 took 2995s without this parallelization
10331033
// and 2915s with. This is a small win, admittedly, but even a few
10341034
// minutes shaved off is important -- and there's not too much mangling
1035-
// of our code needed to get this to work.
1035+
// of our code needed to get this to work. This benchmark has since been
1036+
// deleted, but the optimization holds for other crates as well.
10361037
//
10371038
// Ideally we would not separately build build-script's (which are
10381039
// otherwise shared between the configurations), but there's no good way

0 commit comments

Comments
 (0)