|
| 1 | +# 2023-11-21 Triage Log |
| 2 | + |
| 3 | +Pretty quiet week, with only a small number of statistically significant changes landing. |
| 4 | + |
| 5 | +Triage done by **@simulacrum**. |
| 6 | +Revision range: [173b6e686b158dbad7d072c64bef3ced2052312b..4f3da903a43f22ea33d2ca4435a24b42fc1f842a](https://perf.rust-lang.org/?start=173b6e686b158dbad7d072c64bef3ced2052312b&end=4f3da903a43f22ea33d2ca4435a24b42fc1f842a&absolute=false&stat=instructions%3Au) |
| 7 | + |
| 8 | +**Summary**: |
| 9 | + |
| 10 | +| (instructions:u) | mean | range | count | |
| 11 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 12 | +| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.9%] | 33 | |
| 13 | +| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 1.1%] | 17 | |
| 14 | +| Improvements ✅ <br /> (primary) | - | - | 0 | |
| 15 | +| Improvements ✅ <br /> (secondary) | -0.4% | [-0.6%, -0.3%] | 7 | |
| 16 | +| All ❌✅ (primary) | 0.3% | [0.2%, 0.9%] | 33 | |
| 17 | + |
| 18 | +1 Regressions, 1 Improvements, 1 Mixed; 0 of them in rollups |
| 19 | +60 artifact comparisons made in total |
| 20 | + |
| 21 | +#### Regressions |
| 22 | + |
| 23 | +some additional region refactorings [#117944](https://github.com/rust-lang/rust/pull/117944) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=4d7f952a02d0bca67c98a6b74895b7e3fbe38341&end=069a4af48b4b2111ff65f3895edb425683e6ae8a&stat=instructions:u) |
| 24 | + |
| 25 | +| (instructions:u) | mean | range | count | |
| 26 | +|:----------------------------------:|:----:|:------------:|:-----:| |
| 27 | +| Regressions ❌ <br /> (primary) | 0.1% | [0.1%, 0.1%] | 1 | |
| 28 | +| Regressions ❌ <br /> (secondary) | 0.4% | [0.3%, 1.0%] | 10 | |
| 29 | +| Improvements ✅ <br /> (primary) | - | - | 0 | |
| 30 | +| Improvements ✅ <br /> (secondary) | - | - | 0 | |
| 31 | +| All ❌✅ (primary) | 0.1% | [0.1%, 0.1%] | 1 | |
| 32 | + |
| 33 | +Slight regression to diesel incr-full in the primary benchmarks. That appears |
| 34 | +to be real, but the limitation to incr-full makes me suspect it's not worth |
| 35 | +further investigation, since that scenario is relatively rare. |
| 36 | + |
| 37 | +#### Improvements |
| 38 | + |
| 39 | +Update to LLVM 17.0.5 [#117907](https://github.com/rust-lang/rust/pull/117907) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=49b27f4efbb63b0a35c8d5504e2f38efec8b4d14&end=dd430bc8c22f57992ec1457a87437d14283fdd65&stat=instructions:u) |
| 40 | + |
| 41 | +| (instructions:u) | mean | range | count | |
| 42 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 43 | +| Regressions ❌ <br /> (primary) | - | - | 0 | |
| 44 | +| Regressions ❌ <br /> (secondary) | - | - | 0 | |
| 45 | +| Improvements ✅ <br /> (primary) | -2.9% | [-2.9%, -2.9%] | 2 | |
| 46 | +| Improvements ✅ <br /> (secondary) | - | - | 0 | |
| 47 | +| All ❌✅ (primary) | -2.9% | [-2.9%, -2.9%] | 2 | |
| 48 | + |
| 49 | + |
| 50 | +#### Mixed |
| 51 | + |
| 52 | +Reenable effects in libcore [#117825](https://github.com/rust-lang/rust/pull/117825) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=547ace805166137052b2b76ee6770ef7cc8aa7c1&end=e6dade96f4f16b2c0f621d657130b90b4bb519a2&stat=instructions:u) |
| 53 | + |
| 54 | +| (instructions:u) | mean | range | count | |
| 55 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 56 | +| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.8%] | 6 | |
| 57 | +| Regressions ❌ <br /> (secondary) | 0.6% | [0.3%, 0.8%] | 3 | |
| 58 | +| Improvements ✅ <br /> (primary) | - | - | 0 | |
| 59 | +| Improvements ✅ <br /> (secondary) | -1.3% | [-1.3%, -1.3%] | 1 | |
| 60 | +| All ❌✅ (primary) | 0.3% | [0.2%, 0.8%] | 6 | |
| 61 | + |
| 62 | +Regressions seem real, likely due to downstream effects from libcore's metadata |
| 63 | +getting larger? But not entirely clear; the PR does not appear to directly |
| 64 | +change any functions/types in core. |
0 commit comments