Skip to content

Commit ca9f64d

Browse files
committed
add note that GH comment parsing seems buggy
1 parent 1cd4e41 commit ca9f64d

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

site/src/request_handlers/github.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,10 @@ use std::sync::Arc;
1010
use regex::Regex;
1111

1212
lazy_static::lazy_static! {
13+
// FIXME: the BODY_TIMER_BUILD regex handling looks broken when mixing multiple commands with
14+
// and without parameters/trailing text. To reproduce the issue, in the `captures_all_shas` test
15+
// at the bottom of this file, remove the link at the end of the first `build` command, and the
16+
// second command's SHA won't be captured.
1317
static ref BODY_TIMER_BUILD: Regex =
1418
Regex::new(r"(?:\W|^)@rust-timer\s+build\s+(\w+)(?:\W|$)(?:include=(\S+))?\s*(?:exclude=(\S+))?\s*(?:runs=(\d+))?\s*(?:backends=(\S+))?").unwrap();
1519
static ref BODY_TIMER_QUEUE: Regex =

0 commit comments

Comments
 (0)