Remove unused errors field in Index

Author: Kobzol

database/src/lib.rs

@@ -406,8 +406,6 @@ pub struct Index {
     commits: Indexed<Commit>,
     /// Id lookup of published release artifacts
     artifacts: Indexed<Box<str>>,
-    /// Id lookup of the errors for a crate
-    errors: Indexed<Benchmark>,
     /// Id lookup of compile stat description ids
     /// For legacy reasons called `pstat_series` in the database, and so the name is kept here.
     pstat_series: Indexed<(Benchmark, Profile, Scenario, Metric)>,
@@ -607,10 +605,6 @@ impl Index {
             .collect()
     }
 
-    pub fn all_errors(&self) -> impl Iterator<Item = Benchmark> + '_ {
-        self.errors.map.keys().copied()
-    }
-
     // FIXME: in theory this won't scale indefinitely as there's potentially
     // millions of queries and labels and iterating all of them is eventually
     // going to be impractical. But for now it performs quite well, so we'll go

database/src/pool/postgres.rs

@@ -570,19 +570,6 @@ where
                     )
                 })
                 .collect(),
-            errors: self
-                .conn()
-                .query("select id, crate from error_series", &[])
-                .await
-                .unwrap()
-                .into_iter()
-                .map(|row| {
-                    (
-                        row.get::<_, i32>(0) as u32,
-                        row.get::<_, String>(1).as_str().into(),
-                    )
-                })
-                .collect(),
             pstat_series: self
                 .conn()
                 .query(

database/src/pool/sqlite.rs

@@ -449,19 +449,6 @@ impl Connection for SqliteConnection {
             .unwrap()
             .map(|r| r.unwrap())
             .collect();
-        let errors = self
-            .raw()
-            .prepare("select id, crate from error_series")
-            .unwrap()
-            .query_map(params![], |row| {
-                Ok((
-                    row.get::<_, i32>(0)? as u32,
-                    row.get::<_, String>(1)?.as_str().into(),
-                ))
-            })
-            .unwrap()
-            .map(|r| r.unwrap())
-            .collect();
         let pstat_series = self
             .raw()
             .prepare("select id, crate, profile, cache, statistic from pstat_series;")
@@ -499,7 +486,6 @@ impl Connection for SqliteConnection {
         Index {
             commits,
             artifacts,
-            errors,
             pstat_series,
             runtime_pstat_series,
         }