|
| 1 | +# 2024-09-23 Triage Log |
| 2 | + |
| 3 | +TODO: Summary |
| 4 | + |
| 5 | +Triage done by **@???**. |
| 6 | +Revision range: [170d6cb8..749f80ab](https://perf.rust-lang.org/?start=170d6cb845c8c3f0dcec5cdd4210df9ecf990244&end=749f80ab051aa0b3724b464130440b0e70a975ac&absolute=false&stat=instructions%3Au) |
| 7 | + |
| 8 | +**Summary**: |
| 9 | + |
| 10 | +| (instructions:u) | mean | range | count | |
| 11 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 12 | +| Regressions ❌ <br /> (primary) | 0.7% | [0.2%, 2.5%] | 8 | |
| 13 | +| Regressions ❌ <br /> (secondary) | 1.2% | [0.1%, 3.2%] | 4 | |
| 14 | +| Improvements ✅ <br /> (primary) | -0.3% | [-0.4%, -0.3%] | 9 | |
| 15 | +| Improvements ✅ <br /> (secondary) | -0.9% | [-1.7%, -0.2%] | 23 | |
| 16 | +| All ❌✅ (primary) | 0.2% | [-0.4%, 2.5%] | 17 | |
| 17 | + |
| 18 | + |
| 19 | +1 Regression, 0 Improvements, 4 Mixed; 1 of them in rollups |
| 20 | +28 artifact comparisons made in total |
| 21 | + |
| 22 | +#### Regressions |
| 23 | + |
| 24 | +Remove semi-nondeterminism of `DefPathHash` ordering from inliner [#130455](https://github.com/rust-lang/rust/pull/130455) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=2e367d94f05f3c6170f4d49f5e387cfaa0c42c32&end=46b0f8bafcf11fa1d6b6c172f4f5c1b95c11ebdb&stat=instructions:u) |
| 25 | + |
| 26 | +| (instructions:u) | mean | range | count | |
| 27 | +|:----------------------------------:|:----:|:------------:|:-----:| |
| 28 | +| Regressions ❌ <br /> (primary) | 0.8% | [0.3%, 2.5%] | 5 | |
| 29 | +| Regressions ❌ <br /> (secondary) | 0.6% | [0.1%, 1.0%] | 3 | |
| 30 | +| Improvements ✅ <br /> (primary) | - | - | 0 | |
| 31 | +| Improvements ✅ <br /> (secondary) | - | - | 0 | |
| 32 | +| All ❌✅ (primary) | 0.8% | [0.3%, 2.5%] | 5 | |
| 33 | + |
| 34 | + |
| 35 | +#### Improvements |
| 36 | + |
| 37 | + |
| 38 | + |
| 39 | +#### Mixed |
| 40 | + |
| 41 | +read_volatile __rust_no_alloc_shim_is_unstable in alloc_zeroed [#130497](https://github.com/rust-lang/rust/pull/130497) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=aaed38b2a631dfc593454abf471d75d84033773e&end=7fc70f870a1d11c3b104274d3a18112996cdec9a&stat=instructions:u) |
| 42 | + |
| 43 | +| (instructions:u) | mean | range | count | |
| 44 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 45 | +| Regressions ❌ <br /> (primary) | 0.5% | [0.5%, 0.5%] | 1 | |
| 46 | +| Regressions ❌ <br /> (secondary) | - | - | 0 | |
| 47 | +| Improvements ✅ <br /> (primary) | -0.5% | [-0.7%, -0.3%] | 2 | |
| 48 | +| Improvements ✅ <br /> (secondary) | - | - | 0 | |
| 49 | +| All ❌✅ (primary) | -0.2% | [-0.7%, 0.5%] | 3 | |
| 50 | + |
| 51 | + |
| 52 | +Rollup of 9 pull requests [#130534](https://github.com/rust-lang/rust/pull/130534) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=f79a912d9edc3ad4db910c0e93672ed5c65133fa&end=a5cf8bbd4e1c8edeae08778c85c6f806dd00e853&stat=instructions:u) |
| 53 | + |
| 54 | +| (instructions:u) | mean | range | count | |
| 55 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 56 | +| Regressions ❌ <br /> (primary) | 0.3% | [0.2%, 0.3%] | 3 | |
| 57 | +| Regressions ❌ <br /> (secondary) | - | - | 0 | |
| 58 | +| Improvements ✅ <br /> (primary) | - | - | 0 | |
| 59 | +| Improvements ✅ <br /> (secondary) | -1.1% | [-1.2%, -0.6%] | 4 | |
| 60 | +| All ❌✅ (primary) | 0.3% | [0.2%, 0.3%] | 3 | |
| 61 | + |
| 62 | + |
| 63 | +Support `char::encode_utf8` in const scenarios. [#130511](https://github.com/rust-lang/rust/pull/130511) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=df7f77811c8806f85522a38878c57fde221138c9&end=f8192ba0d00bbbc58a10c45823ba010e98ea4474&stat=instructions:u) |
| 64 | + |
| 65 | +| (instructions:u) | mean | range | count | |
| 66 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 67 | +| Regressions ❌ <br /> (primary) | 0.3% | [0.3%, 0.4%] | 3 | |
| 68 | +| Regressions ❌ <br /> (secondary) | - | - | 0 | |
| 69 | +| Improvements ✅ <br /> (primary) | -0.4% | [-0.5%, -0.3%] | 2 | |
| 70 | +| Improvements ✅ <br /> (secondary) | - | - | 0 | |
| 71 | +| All ❌✅ (primary) | 0.0% | [-0.5%, 0.4%] | 5 | |
| 72 | + |
| 73 | + |
| 74 | +Get rid of niche selection's dependence on fields's order [#130508](https://github.com/rust-lang/rust/pull/130508) [(Comparison Link)](https://perf.rust-lang.org/compare.html?start=749f80ab051aa0b3724b464130440b0e70a975ac&end=902f2956a627bd1bd44557b7fe6427a099bf8c48&stat=instructions:u) |
| 75 | + |
| 76 | +| (instructions:u) | mean | range | count | |
| 77 | +|:----------------------------------:|:-----:|:--------------:|:-----:| |
| 78 | +| Regressions ❌ <br /> (primary) | 0.2% | [0.2%, 0.2%] | 1 | |
| 79 | +| Regressions ❌ <br /> (secondary) | 0.5% | [0.2%, 0.9%] | 3 | |
| 80 | +| Improvements ✅ <br /> (primary) | -0.6% | [-0.6%, -0.6%] | 1 | |
| 81 | +| Improvements ✅ <br /> (secondary) | - | - | 0 | |
| 82 | +| All ❌✅ (primary) | -0.2% | [-0.6%, 0.2%] | 2 | |
| 83 | + |
| 84 | + |
| 85 | +#### Untriaged Pull Requests |
| 86 | + |
| 87 | +- [#130649 Rollup of 6 pull requests](https://github.com/rust-lang/rust/pull/130649) |
| 88 | +- [#130631 Rollup of 7 pull requests](https://github.com/rust-lang/rust/pull/130631) |
| 89 | +- [#130534 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/130534) |
| 90 | +- [#130511 Support `char::encode_utf8` in const scenarios.](https://github.com/rust-lang/rust/pull/130511) |
| 91 | +- [#130508 Get rid of niche selection's dependence on fields's order](https://github.com/rust-lang/rust/pull/130508) |
| 92 | +- [#130497 read_volatile __rust_no_alloc_shim_is_unstable in alloc_zeroed](https://github.com/rust-lang/rust/pull/130497) |
| 93 | +- [#130455 Remove semi-nondeterminism of `DefPathHash` ordering from inliner](https://github.com/rust-lang/rust/pull/130455) |
| 94 | +- [#130091 Rollup of 10 pull requests](https://github.com/rust-lang/rust/pull/130091) |
| 95 | +- [#129831 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/129831) |
| 96 | +- [#129817 Rollup of 12 pull requests](https://github.com/rust-lang/rust/pull/129817) |
| 97 | +- [#129797 Try to reduce space usage in dist CI](https://github.com/rust-lang/rust/pull/129797) |
| 98 | +- [#129790 Bump to 1.83](https://github.com/rust-lang/rust/pull/129790) |
| 99 | +- [#129632 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/129632) |
| 100 | +- [#129063 Apply size optimizations to panic machinery and some cold functions](https://github.com/rust-lang/rust/pull/129063) |
| 101 | +- [#128936 Support reading thin archives in ArArchiveBuilder](https://github.com/rust-lang/rust/pull/128936) |
| 102 | +- [#128443 Properly mark loop as diverging if it has no breaks](https://github.com/rust-lang/rust/pull/128443) |
| 103 | +- [#128357 Detect non-lifetime binder params shadowing item params](https://github.com/rust-lang/rust/pull/128357) |
| 104 | +- [#128301 Rollup of 3 pull requests](https://github.com/rust-lang/rust/pull/128301) |
| 105 | +- [#128299 Simplify the canonical clone method and the copy-like forms to copy](https://github.com/rust-lang/rust/pull/128299) |
| 106 | +- [#128169 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/128169) |
| 107 | +- [#128155 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/128155) |
| 108 | +- [#128104 Not lint pub structs without pub constructors intentionally](https://github.com/rust-lang/rust/pull/128104) |
| 109 | +- [#127998 Rollup of 9 pull requests](https://github.com/rust-lang/rust/pull/127998) |
| 110 | +- [#127865 Rollup of 8 pull requests](https://github.com/rust-lang/rust/pull/127865) |
| 111 | +- [#127537 Implement a first version of RFC 3525: struct target features](https://github.com/rust-lang/rust/pull/127537) |
| 112 | +- [#127528 Replace ASCII control chars with Unicode Control Pictures](https://github.com/rust-lang/rust/pull/127528) |
| 113 | +- [#127486 Rollup of 5 pull requests](https://github.com/rust-lang/rust/pull/127486) |
| 114 | +- [#127439 Uplift elaboration into `rustc_type_ir`](https://github.com/rust-lang/rust/pull/127439) |
| 115 | +- [#127172 Make `can_eq` process obligations (almost) everywhere](https://github.com/rust-lang/rust/pull/127172) |
| 116 | +- [#127096 Rollup of 11 pull requests](https://github.com/rust-lang/rust/pull/127096) |
| 117 | + |
| 118 | +#### Nags requiring follow up |
| 119 | + |
| 120 | +TODO: Nags |
| 121 | + |
0 commit comments